Skip to content

Commit 7f5c649

Browse files
kirich1409claude
andauthored
fix(firebase): wrap RuntimeException in FetchException; remove missing ADR doc reference (#151)
- FirebaseConfigValueProvider.fetch() was re-throwing RuntimeException bare, bypassing the FetchException wrapper the tests and docs contract requires - Remove ADR 001 nav entry from mkdocs.yml and dead link from best-practices.md (the file was never created, causing mkdocs --strict to abort) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 8d09942 commit 7f5c649

3 files changed

Lines changed: 0 additions & 5 deletions

File tree

docs/guides/best-practices.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ class CheckoutViewModel @Inject constructor(
165165
}
166166
```
167167

168-
See [ADR 001](../adr/001-configvalues-multi-module.md) for the rationale behind this design.
169168

170169
---
171170

mkdocs.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,5 +63,3 @@ nav:
6363
- iOS Dead-Code Elimination: ios-integration.md
6464
- API Reference: api/index.md
6565
- Changelog: changelog.md
66-
- ADRs:
67-
- "ADR 001: ConfigValues Multi-Module": adr/001-configvalues-multi-module.md

providers/firebase/src/main/kotlin/dev/androidbroadcast/featured/firebase/FirebaseConfigValueProvider.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,6 @@ public class FirebaseConfigValueProvider(
9898

9999
try {
100100
task.await()
101-
} catch (e: RuntimeException) {
102-
throw e
103101
} catch (e: Exception) {
104102
throw FetchException("Firebase Remote Config fetch failed", e)
105103
}

0 commit comments

Comments
 (0)