Skip to content

CI_FIXES_SUMMARY.md

Latest commit

 

History

History
91 lines (65 loc) · 2.33 KB

CI_FIXES_SUMMARY.md

File metadata and controls

91 lines (65 loc) · 2.33 KB

CI Fixes Summary

Status: 1 of 2 Failures Fixed ✅

✅ Fixed: ESLint + Prettier Violations

Issue: Unused variables in test file

  • mockDocument was assigned but never used
  • mockWindow was assigned but never used
  • elementStyle was assigned but never used
  • event parameter was defined but never used

Fix Applied: Removed all unused variables and parameters

Verification:

$ yarn lint
✓ All files pass ESLint
✓ All files pass Prettier

Commit: 045cdf1 - "fix: remove unused variables in footer tracking tests"

⚠️ Requires Manual Fix: PR Semantic Title

Issue: PR title doesn't follow conventional commit format

Current Title:

Amplitude footer click event

Required Title (choose one):

feat(guides): track powered by amplitude footer clicks

or

feat: add click tracking for guides footer

How to Fix:

  1. Go to the PR on GitHub: #623
  2. Click "Edit" next to the PR title
  3. Update to one of the suggested titles above
  4. Save

Why: Amplitude uses semantic versioning based on conventional commit format in PR titles. The feat: prefix will trigger a minor version bump when this is merged.

Note: Automated update via gh pr edit failed due to permission restrictions (GraphQL: Resource not accessible by integration).

CI Check Results After Fixes

Expected Results:

  • ✅ ESLint + Prettier: PASS (fixed in commit 045cdf1)
  • ⚠️ PR Semantic Title: PENDING (manual update required)

Verification Commands:

# Verify lint passes locally
yarn lint

# Check ESLint on specific files
npx eslint test/guides-footer-tracking.test.js --no-ignore
npx eslint guides-footer-tracking.js --no-ignore

# Check Prettier
npx prettier --check guides-footer-tracking.js test/guides-footer-tracking.test.js

All commands should pass ✅

Summary

Fixed Automatically:

  • Removed unused variables from test file
  • Removed unused event parameter
  • All ESLint checks now pass
  • All Prettier checks now pass

Requires Manual Action:

  • Update PR title on GitHub to follow feat(scope): description format
  • Suggested: feat(guides): track powered by amplitude footer clicks

Once the PR title is updated, all CI checks should pass.