-
Notifications
You must be signed in to change notification settings - Fork 155
Expand file tree
/
Copy pathOrchestrator.ts
More file actions
388 lines (331 loc) · 13 KB
/
Orchestrator.ts
File metadata and controls
388 lines (331 loc) · 13 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
import { ethers, waffle } from 'hardhat'
import { Contract, Signer } from 'ethers'
import { increaseTime } from '../utils/utils'
import { expect } from 'chai'
import { TransactionResponse } from '@ethersproject/providers'
let orchestrator: Contract, mockPolicy: Contract, mockDownstream: Contract
let r: Promise<TransactionResponse>
let deployer: Signer, user: Signer
async function mockedOrchestrator() {
await increaseTime(86400)
// get signers
const [deployer, user] = await ethers.getSigners()
// deploy mocks
const mockPolicy = await (
await ethers.getContractFactory('MockUFragmentsPolicy')
)
.connect(deployer)
.deploy()
const orchestrator = await (await ethers.getContractFactory('Orchestrator'))
.connect(deployer)
.deploy(mockPolicy.address)
const mockDownstream = await (
await ethers.getContractFactory('MockDownstream')
)
.connect(deployer)
.deploy()
await orchestrator.connect(deployer).setRebaseCaller(await deployer.getAddress())
return {
deployer,
user,
orchestrator,
mockPolicy,
mockDownstream,
}
}
describe('Orchestrator', function () {
before('setup Orchestrator contract', async () => {
; ({ deployer, user, orchestrator, mockPolicy, mockDownstream } =
await waffle.loadFixture(mockedOrchestrator))
})
describe('when sent ether', async function () {
it('should reject', async function () {
await expect(user.sendTransaction({ to: orchestrator.address, value: 1 }))
.to.be.reverted
})
})
describe('when rebase called by unauthorized address', function () {
it('should fail when called by a contract', async function () {
const rebaseCallerContract = await (
await ethers.getContractFactory('RebaseCallerContract')
)
.connect(deployer)
.deploy()
await expect(rebaseCallerContract.callRebase(orchestrator.address)).to.be
.reverted
})
it('should fail when called by unauthorized user', async function () {
await expect(orchestrator.connect(user).rebase()).to.be.revertedWith(
'Unauthorized rebase caller',
)
})
})
describe('when rebase called by a contract which is being constructed', function () {
it('should fail', async function () {
await expect(
(await ethers.getContractFactory('ConstructorRebaseCallerContract'))
.connect(deployer)
.deploy(orchestrator.address),
).to.be.reverted
})
})
describe('when transaction list is empty', async function () {
before('calling rebase', async function () {
r = orchestrator.rebase()
})
it('should have no transactions', async function () {
expect(await orchestrator.transactionsSize()).to.eq(0)
})
it('should call rebase on policy', async function () {
await expect(r)
.to.emit(mockPolicy, 'FunctionCalled')
.withArgs('UFragmentsPolicy', 'rebase', orchestrator.address)
})
it('should not have any subsequent logs', async function () {
expect((await (await r).wait()).logs.length).to.eq(1)
})
})
describe('when there is a single transaction', async function () {
before('adding a transaction', async function () {
const updateOneArgEncoded =
await mockDownstream.populateTransaction.updateOneArg(12345)
await orchestrator
.connect(deployer)
.addTransaction(mockDownstream.address, updateOneArgEncoded.data)
r = orchestrator.connect(deployer).rebase()
})
it('should have 1 transaction', async function () {
expect(await orchestrator.transactionsSize()).to.eq(1)
})
it('should call rebase on policy', async function () {
await expect(r)
.to.emit(mockPolicy, 'FunctionCalled')
.withArgs('UFragmentsPolicy', 'rebase', orchestrator.address)
})
it('should call the transaction', async function () {
await expect(r)
.to.emit(mockDownstream, 'FunctionCalled')
.withArgs('MockDownstream', 'updateOneArg', orchestrator.address)
await expect(r)
.to.emit(mockDownstream, 'FunctionArguments')
.withArgs([12345], [])
})
it('should not have any subsequent logs', async function () {
expect((await (await r).wait()).logs.length).to.eq(3)
})
})
describe('when there are two transactions', async function () {
before('adding a transaction', async function () {
const updateTwoArgsEncoded =
await mockDownstream.populateTransaction.updateTwoArgs(12345, 23456)
await orchestrator
.connect(deployer)
.addTransaction(mockDownstream.address, updateTwoArgsEncoded.data)
r = orchestrator.connect(deployer).rebase()
})
it('should have 2 transactions', async function () {
expect(await orchestrator.transactionsSize()).to.eq(2)
})
it('should call rebase on policy', async function () {
await expect(r)
.to.emit(mockPolicy, 'FunctionCalled')
.withArgs('UFragmentsPolicy', 'rebase', orchestrator.address)
})
it('should call first transaction', async function () {
await expect(r)
.to.emit(mockDownstream, 'FunctionCalled')
.withArgs('MockDownstream', 'updateOneArg', orchestrator.address)
await expect(r)
.to.emit(mockDownstream, 'FunctionArguments')
.withArgs([12345], [])
})
it('should call second transaction', async function () {
await expect(r)
.to.emit(mockDownstream, 'FunctionCalled')
.withArgs('MockDownstream', 'updateTwoArgs', orchestrator.address)
await expect(r)
.to.emit(mockDownstream, 'FunctionArguments')
.withArgs([12345], [23456])
})
it('should not have any subsequent logs', async function () {
expect((await (await r).wait()).logs.length).to.eq(5)
})
})
describe('when 1st transaction is disabled', async function () {
before('disabling a transaction', async function () {
await orchestrator.connect(deployer).setTransactionEnabled(0, false)
r = orchestrator.connect(deployer).rebase()
})
it('should have 2 transactions', async function () {
expect(await orchestrator.transactionsSize()).to.eq(2)
})
it('should call rebase on policy', async function () {
await expect(r)
.to.emit(mockPolicy, 'FunctionCalled')
.withArgs('UFragmentsPolicy', 'rebase', orchestrator.address)
})
it('should call second transaction', async function () {
await expect(r)
.to.emit(mockDownstream, 'FunctionCalled')
.withArgs('MockDownstream', 'updateTwoArgs', orchestrator.address)
await expect(r)
.to.emit(mockDownstream, 'FunctionArguments')
.withArgs([12345], [23456])
})
it('should not have any subsequent logs', async function () {
expect(await (await (await r).wait()).logs.length).to.eq(3)
})
})
describe('when a transaction is removed', async function () {
before('removing 1st transaction', async function () {
await orchestrator.connect(deployer).removeTransaction(0)
r = orchestrator.connect(deployer).rebase()
})
it('should have 1 transaction', async function () {
expect(await orchestrator.transactionsSize()).to.eq(1)
})
it('should call rebase on policy', async function () {
await expect(r)
.to.emit(mockPolicy, 'FunctionCalled')
.withArgs('UFragmentsPolicy', 'rebase', orchestrator.address)
})
it('should call the transaction', async function () {
await expect(r)
.to.emit(mockDownstream, 'FunctionCalled')
.withArgs('MockDownstream', 'updateTwoArgs', orchestrator.address)
await expect(r)
.to.emit(mockDownstream, 'FunctionArguments')
.withArgs([12345], [23456])
})
it('should not have any subsequent logs', async function () {
expect((await (await r).wait()).logs.length).to.eq(3)
})
})
describe('when all transactions are removed', async function () {
before('removing 1st transaction', async function () {
await orchestrator.connect(deployer).removeTransaction(0)
r = orchestrator.connect(deployer).rebase()
})
it('should have 0 transactions', async function () {
expect(await orchestrator.transactionsSize()).to.eq(0)
})
it('should call rebase on policy', async function () {
await expect(r)
.to.emit(mockPolicy, 'FunctionCalled')
.withArgs('UFragmentsPolicy', 'rebase', orchestrator.address)
})
it('should not have any subsequent logs', async function () {
expect((await (await r).wait()).logs.length).to.eq(1)
})
})
describe('when a transaction reverts', async function () {
before('adding 3 transactions', async function () {
const updateOneArgEncoded =
await mockDownstream.populateTransaction.updateOneArg(123)
await orchestrator
.connect(deployer)
.addTransaction(mockDownstream.address, updateOneArgEncoded.data)
const revertsEncoded = await mockDownstream.populateTransaction.reverts()
await orchestrator
.connect(deployer)
.addTransaction(mockDownstream.address, revertsEncoded.data)
const updateTwoArgsEncoded =
await mockDownstream.populateTransaction.updateTwoArgs(12345, 23456)
await orchestrator
.connect(deployer)
.addTransaction(mockDownstream.address, updateTwoArgsEncoded.data)
await expect(orchestrator.connect(deployer).rebase()).to.be.reverted
})
it('should have 3 transactions', async function () {
expect(await orchestrator.transactionsSize()).to.eq(3)
})
})
describe('Access Control', function () {
describe('addTransaction', async function () {
it('should be callable by owner', async function () {
const updateNoArgEncoded =
await mockDownstream.populateTransaction.updateNoArg()
await expect(
orchestrator
.connect(deployer)
.addTransaction(mockDownstream.address, updateNoArgEncoded.data),
).to.not.be.reverted
})
it('should not be callable by others', async function () {
const updateNoArgEncoded =
await mockDownstream.populateTransaction.updateNoArg()
await expect(
orchestrator
.connect(user)
.addTransaction(mockDownstream.address, updateNoArgEncoded.data),
).to.be.reverted
})
})
describe('setTransactionEnabled', async function () {
it('should be callable by owner', async function () {
expect(await orchestrator.transactionsSize()).to.gt(0)
await expect(
orchestrator.connect(deployer).setTransactionEnabled(0, true),
).to.not.be.reverted
})
it('should revert if index out of bounds', async function () {
expect(await orchestrator.transactionsSize()).to.lt(5)
await expect(
orchestrator.connect(deployer).setTransactionEnabled(5, true),
).to.be.reverted
})
it('should not be callable by others', async function () {
expect(await orchestrator.transactionsSize()).to.gt(0)
await expect(orchestrator.connect(user).setTransactionEnabled(0, true))
.to.be.reverted
})
})
describe('removeTransaction', async function () {
it('should not be callable by others', async function () {
expect(await orchestrator.transactionsSize()).to.gt(0)
await expect(orchestrator.connect(user).removeTransaction(0)).to.be
.reverted
})
it('should revert if index out of bounds', async function () {
expect(await orchestrator.transactionsSize()).to.lt(5)
await expect(orchestrator.connect(deployer).removeTransaction(5)).to.be
.reverted
})
it('should be callable by owner', async function () {
expect(await orchestrator.transactionsSize()).to.gt(0)
await expect(orchestrator.connect(deployer).removeTransaction(0)).to.not
.be.reverted
})
})
describe('setRebaseCaller', async function () {
it('should be callable by owner', async function () {
const newCaller = await user.getAddress()
await expect(
orchestrator.connect(deployer).setRebaseCaller(newCaller),
).to.not.be.reverted
expect(await orchestrator.rebaseCaller()).to.eq(newCaller)
})
it('should not be callable by others', async function () {
const newCaller = await user.getAddress()
await expect(orchestrator.connect(user).setRebaseCaller(newCaller)).to
.be.reverted
})
it('should reject zero address', async function () {
await expect(
orchestrator
.connect(deployer)
.setRebaseCaller('0x0000000000000000000000000000000000000000'),
).to.be.revertedWith('Invalid rebase caller')
})
})
describe('transferOwnership', async function () {
it('should transfer ownership', async function () {
expect(await orchestrator.owner()).to.eq(await deployer.getAddress())
await orchestrator
.connect(deployer)
.transferOwnership(user.getAddress())
expect(await orchestrator.owner()).to.eq(await user.getAddress())
})
})
})
})