add initialization of pages in BaseTest with fixture

Author: amielnoy

.vscode/launch.json

@@ -0,0 +1,24 @@
+{
+  "version": "0.2.0",
+  "configurations": [
+    {
+      "name": "🐞 Debug Pytest",
+      "type": "python",
+      "request": "launch",
+      "program": "${workspaceFolder}/venv/bin/pytest",
+      "args": [
+        "Ultimateqa/tests",       // ← הנתיב לתיקיית הטסטים שלך
+        "-n", "auto",             // ← להרצה מקבילית אם xdist מותקן
+        "--maxfail=3", "--tb=short"
+      ],
+      "console": "integratedTerminal",
+      "justMyCode": false,
+      "envFile": "${workspaceFolder}/.env",
+      "env": {
+        "PYTHONPATH": "${workspaceFolder}",
+        "PYTHONBREAKPOINT": "1" // ← מאפשר לך לשים נקודות שבירה בקוד שלך
+      }
+      
+    }
+  ]
+}

.vscode/settings.json

@@ -0,0 +1,9 @@
+{
+    "playwright.reuseBrowser": true,
+    "python.pythonPath": "ForcePoint/venv/bin/python",
+  "python.testing.pytestEnabled": true,
+  "python.testing.pytestArgs": [
+    "Ultimateqa/ui_tests",
+    "api_tests",
+  ]
+}

Ultimateqa/pages/SubPages/section_sub_page.py

@@ -5,28 +5,19 @@
 from sub_page_buttons import SubPageButtons
 
 class SectionSubPage:
-    def setup(self, page: Page, goto):
-        # Add the project path to sys.path
-        sys.path.append('/')
-
-        # Load environment variables
-        load_dotenv()
-
-        # Retrieve the base URL from environment variables
-        base_url = os.getenv("BASE_URL")
-
-        # Navigate to the base URL
-        goto(base_url)
-
-        # Initialize the sub-page buttons object
-        self.sub_page_buttons = SubPageButtons(page)
+    def __init__(self,page: Page):
+        self.page=page
+        self.name_element =self.page.locator('#et_pb_contact_name_0')
+        self.email_element = self.page.locator('#et_pb_contact_email_0')
+        self.message_element = self.page.locator('#et_pb_contact_message_0')
+        self.contact_submit_button= self.page.locator('.et_pb_contact_submit')
 
     def fill_contact_form(self, name: str, email: str, message: str):
         # Fill the contact form fields
-        self.page.fill('#et_pb_contact_name_0', name)
-        self.page.fill('#et_pb_contact_email_0', email)
-        self.page.fill('#et_pb_contact_message_0', message)
+        self.name_element.fill(name)
+        self.email_element.fill(email)
+        self.message_element.fill(message)
 
     def submit_contact_form(self):
         # Submit the contact form
-        self.page.click('.et_pb_contact_submit')
+        self.contact_submit_button.click()

Ultimateqa/pages/SubPages/sub_page_social_media.py

@@ -5,3 +5,4 @@ class SubPageSocialMedia:
     def __init__(self, page: Page):
         self.page = page
         self.section = page.query_selector('.et_pb_row.et_pb_row_4')
+

Ultimateqa/ui_tests/base_test.py

@@ -1,19 +1,14 @@
-import sys
-import os
 import pytest
-from dotenv import load_dotenv
-from playwright.sync_api import Page
+from Ultimateqa.pages.SubPages.sub_page_buttons import SubPageButtons
+from Ultimateqa.pages.SubPages.sub_page_social_media import SubPageSocialMedia
+from Ultimateqa.pages.SubPages.sub_page_forms import SubPageForms
 
-class TestBase:
-    @pytest.fixture(scope="function")
-    def setup(self,page: Page):
+class BaseTest:
+    @pytest.fixture(autouse=True)
+    def setup(self, page, base_url_fe):
         self.page = page
-        load_dotenv()
-        self.base_url = os.getenv("BASE_URL")
-        yield
-
-        # Load environment variables
-
-        # Retrieve the base URL from environment variables
-        
-        # Teardown code
+        self.base_url_fe = base_url_fe
+        self.sub_page_buttons = SubPageButtons(self.page)
+        self.sub_page_social_media = SubPageSocialMedia(self.page)
+        self.sub_page_forms = SubPageForms(self.page)
+        self.page.goto(self.base_url_fe)

Ultimateqa/ui_tests/test_fe.py

@@ -1,75 +1,46 @@
 import pytest
-from playwright.sync_api import Page
-from Ultimateqa.pages.SubPages.sub_page_buttons import SubPageButtons
-from Ultimateqa.pages.SubPages.sub_page_social_media import SubPageSocialMedia
-from Ultimateqa.pages.SubPages.sub_page_forms import SubPageForms
 import Ultimateqa.ui_tests.consts as consts
-
-
-def test_count_buttons(page: Page, base_url_fe):
-    page.goto(base_url_fe)
-    sub_page_buttons = SubPageButtons(page)
-
-    count_of_buttons = sub_page_buttons.count_buttons()
-
-    assert count_of_buttons == consts.NUN_OF_BUTTONS_TO_FIND, \
-        f"Found: {count_of_buttons} buttons, expected: {consts.NUN_OF_BUTTONS_TO_FIND}"
-
-    count_all_buttons_using_css = sub_page_buttons.all_buttons.count()
-    assert count_all_buttons_using_css == consts.NUN_OF_BUTTONS_TO_FIND, \
-        f"Found: {count_of_buttons} buttons, expected: {consts.NUN_OF_BUTTONS_TO_FIND}"
-
-def test_count_buttons_using_css(page: Page, base_url_fe):
-    page.goto(base_url_fe)
-    sub_page_buttons = SubPageButtons(page)
-
-    count_all_buttons_using_css = sub_page_buttons.all_buttons.count()
-    assert count_all_buttons_using_css == consts.NUN_OF_BUTTONS_TO_FIND, \
-        f"Found: {count_all_buttons_using_css} buttons, expected: {consts.NUN_OF_BUTTONS_TO_FIND}"
-
-
-def test_verify_href_link(page: Page, base_url_fe):
-    # load_dotenv()
-    # base_url = os.getenv("BASE_URL")
-    page.goto(base_url_fe)
-    sub_page_social_media = SubPageSocialMedia(page)
-
-    facebook_buttons = sub_page_social_media.section.query_selector_all('a[title="Follow on Facebook"]')
-
-    for button in facebook_buttons:
-        href = button.get_attribute('href')
-        assert href == consts.SOCIAL_MEDIA_LINK, f"href is: {href}, expected: {consts.SOCIAL_MEDIA_LINK} "
-
-@pytest.mark.parametrize('name, email, message, exercise_result, message_after_submit', [
-    ('Haim Moshe', 'haim.moshe@gmail.com', 'I am singer', None, 'Thanks for contacting us'),
-    ('Haim Cohen', 'adam@gmail.com', 'I am Adam', None, 'Thanks for contacting us'),
-    ('Asaf Levi', 'asaf@gmail.com', 'I am Asaf', '0', 'You entered the wrong number in captcha.'),
-])
-def test_forms(page: Page, name, email, message, exercise_result, message_after_submit, base_url_fe):
-    #load_dotenv()
-    #base_url = os.getenv("BASE_URL")
-    page.goto(base_url_fe)
-    sub_page_social_forms = SubPageForms(page)
-
-    sub_page_social_forms.set_name(name)
-    sub_page_social_forms.set_email(email)
-    sub_page_social_forms.set_message(message)
-
-    if exercise_result != '0':
-        exercise_result = sub_page_social_forms.extract_and_calculate_result()
-
-    #page.pause()
-
-    sub_page_social_forms.set_result(result=str(exercise_result))
-    sub_page_social_forms.click_submit()
-
-
-
-    if exercise_result != '0':
-        response_message = sub_page_social_forms.get_submit_response()
-    else:
-        response_message = sub_page_social_forms.get_submit_fail_response()
-
-    assert response_message == message_after_submit
-
-
+from Ultimateqa.ui_tests.base_test import BaseTest
+
+class TestUI(BaseTest):
+
+    def test_count_buttons(self):
+        count_of_buttons = self.sub_page_buttons.count_buttons()
+        assert count_of_buttons == consts.NUN_OF_BUTTONS_TO_FIND, \
+            f"Found: {count_of_buttons} buttons, expected: {consts.NUN_OF_BUTTONS_TO_FIND}"
+
+    def test_count_buttons_using_css(self):
+        count_all_buttons_using_css = self.sub_page_buttons.all_buttons.count()
+        assert count_all_buttons_using_css == consts.NUN_OF_BUTTONS_TO_FIND, \
+            f"Found: {count_all_buttons_using_css} buttons, expected: {consts.NUN_OF_BUTTONS_TO_FIND}"
+    #One link of facebook is not equal
+    # Expected  'https://www.facebook.com/Ultimateqa1/'
+    # Actual   :'https://www.facebook.com/Ultimateqa1'
+    def test_verify_href_link(self):
+        facebook_buttons = self.sub_page_social_media.page.query_selector_all('a[title="Follow on Facebook"]')
+        for button in facebook_buttons:
+            href = button.get_attribute('href')
+            assert href == consts.SOCIAL_MEDIA_LINK, f"href is: {href}, expected: {consts.SOCIAL_MEDIA_LINK} "
+
+    @pytest.mark.parametrize('name, email, message, exercise_result, message_after_submit', [
+        ('Haim Moshe', 'haim.moshe@gmail.com', 'I am singer', None, 'Thanks for contacting us'),
+        ('Haim Cohen', 'adam@gmail.com', 'I am Adam', None, 'Thanks for contacting us'),
+        ('Asaf Levi', 'asaf@gmail.com', 'I am Asaf', '0', 'You entered the wrong number in captcha.'),
+    ])
+    def test_forms(self, name, email, message, exercise_result, message_after_submit):
+        self.sub_page_forms.set_name(name)
+        self.sub_page_forms.set_email(email)
+        self.sub_page_forms.set_message(message)
+
+        if exercise_result != '0':
+            exercise_result = self.sub_page_forms.extract_and_calculate_result()
+
+        self.sub_page_forms.set_result(result=str(exercise_result))
+        self.sub_page_forms.click_submit()
+
+        if exercise_result != '0':
+            response_message = self.sub_page_forms.get_submit_response()
+        else:
+            response_message = self.sub_page_forms.get_submit_fail_response()
+
+        assert response_message == message_after_submit

api_tests/Integration_tests/test_user_alboms.py

@@ -1,3 +1,8 @@
+
+from fields.extras import ValidationError
+from schema import Schema
+from marshmallow import Schema, fields, ValidationError
+
 from api_tests.globals import ApiHttpConstants
 
 
@@ -32,3 +37,24 @@ def test_user_albums_schema(api):
         assert isinstance(album["id"], int), f"id is not int: {album['id']}"
         assert isinstance(album["title"], str), f"title is not str: {album['title']}"
         assert isinstance(album["userId"], int), f"userId is not int: {album['userId']}"
+
+class AlbumSchema(Schema):
+    id = fields.Int(required=True)
+    title = fields.Str(required=True)
+    userId = fields.Int(required=True)
+
+def test_user_albums_schema_with_marshmellow(api):
+    """
+    Test that the user albums API returns data matching the expected schema.
+    """
+    response = api.get("/albums")
+    assert response.status_code == 200
+    data = response.json()
+    assert isinstance(data, list), "Response should be a list of albums"
+
+    schema = AlbumSchema()
+    for album in data:
+        try:
+            schema.load(album)
+        except ValidationError as err:
+            assert False, f"Schema validation failed for album: {album}\nErrors: {err.messages}"

conftest.py

@@ -16,4 +16,11 @@ def base_url_fe():
 @pytest.fixture(scope='session',autouse=True)
 def base_url_api():
     load_dotenv()
-    APIClient.BASE_URL_API = os.getenv('BASE_URL_API')
+    APIClient.BASE_URL_API = os.getenv('BASE_URL_API')
+    
+@pytest.fixture(scope="session")
+def browser_type_launch_args():
+    return {
+        "headless": False,
+        "slow_mo": 250  # מאט את הפעולות כדי שתוכל לראות מה קורה
+    }

requirements.txt

@@ -18,3 +18,6 @@ python-dotenv
 pytest-xdist
 requests
 zipp>=3.19.1 # not directly required, pinned by Snyk to avoid a vulnerability
+fields
+schema
+marshmallow