From 5ba9e81454f34ea7eaa71bc67b19eb7b72dec08c Mon Sep 17 00:00:00 2001
From: Dhairya <sharmadhairya024@gmail.com>
Date: Sat, 21 Feb 2026 18:50:25 +0530
Subject: [PATCH 1/4] Fix : Graphing_Calculator

---
 web/templates/graphing_calculator.html | 47 ++++++++++++++++++++------
 1 file changed, 37 insertions(+), 10 deletions(-)

diff --git a/web/templates/graphing_calculator.html b/web/templates/graphing_calculator.html
index fd7efb2cb..d9468a48d 100644
--- a/web/templates/graphing_calculator.html
+++ b/web/templates/graphing_calculator.html
@@ -315,9 +315,9 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
 
       // Plot explicit functions: y = f(x)
       function plotExplicit(equation, color) {
-          let exprStr = equation.trim();
-          if (exprStr.startsWith("y=")) {
-              exprStr = exprStr.substring(2);
+          let exprStr = equation;
+          if (exprStr.includes("=")) {
+              exprStr = equation.split("=")[1].trim();
           }
           let compiled;
           try {
@@ -330,6 +330,7 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
           ctx.lineWidth = 2;
           ctx.beginPath();
           let firstPoint = true;
+          let prevY = null;
           const xMin = toMathCoords(0, 0).x;
           const xMax = toMathCoords(canvas.width, 0).x;
           const step = (xMax - xMin) / canvas.width;
@@ -347,6 +348,11 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
                   firstPoint = true;
                   continue;
               }
+
+              if (prevY !== null && Math.abs(y - prevY) > (canvas.height / scale)) {
+                  firstPoint = true;
+              }
+              prevY = y;
               const {
                   x: cx,
                   y: cy
@@ -373,7 +379,7 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
       // Plot implicit functions using marching squares: f(x,y)=0
       function plotImplicit(equation, color) {
           const parts = equation.split("=");
-          if (parts.length !== 2) {
+          if (parts.length !== 2 || parts[0].trim() === "" || parts[1].trim() === "") {
               alert("Invalid implicit equation format.");
               return;
           }
@@ -416,7 +422,11 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
                   if (v4 > 0) index |= 8;
                   if (index === 0 || index === 15) continue;
                   let points = [];
-                  if ((index & 1) !== (index & 2)) {
+                  const b1 = v1 > 0;
+                  const b2 = v2 > 0;
+                  const b3 = v3 > 0;
+                  const b4 = v4 > 0;
+                  if (b1 !== b2) {
                       points.push(interpolate({
                           x: i,
                           y: j
@@ -425,7 +435,7 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
                           y: j
                       }, v1, v2));
                   }
-                  if ((index & 2) !== (index & 4)) {
+                  if (b2 !== b3) {
                       points.push(interpolate({
                           x: i + gridStep,
                           y: j
@@ -434,7 +444,7 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
                           y: j + gridStep
                       }, v2, v3));
                   }
-                  if ((index & 8) !== (index & 4)) {
+                  if (b3 !== b4) {
                       points.push(interpolate({
                           x: i,
                           y: j + gridStep
@@ -443,7 +453,7 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
                           y: j + gridStep
                       }, v4, v3));
                   }
-                  if ((index & 1) !== (index & 8)) {
+                  if (b1 !== b4) {
                       points.push(interpolate({
                           x: i,
                           y: j
@@ -468,12 +478,29 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
 
       // Determine whether to plot explicit or implicit based on input format
       function plotEquation(equation, color) {
-          if (equation.trim().startsWith("y=")) {
+          if (equation.split("=")[0].trim() === "y") {
               plotExplicit(equation, color);
           } else if (equation.includes("=")) {
               plotImplicit(equation, color);
           } else {
-              plotExplicit("y=" + equation, color);
+              let hasYVariable = false;
+
+              try {
+                  const parseMath = math.parse(equation);
+
+                  const yNodes = parseMath.filter(function(node) {
+                      return node.isSymbolNode && node.name === "y";
+                  });
+                  if (yNodes.length > 0) {
+                      hasYVariable = true;
+                  }
+              } catch (err) {}
+
+              if (hasYVariable) {
+                  alert("Invalid implicit equation format.");
+              } else {
+                  plotExplicit("y=" + equation, color);
+              }
           }
       }
 

From 31bf40658967a73584e490982e7c18e410bdfb4d Mon Sep 17 00:00:00 2001
From: Dhairya <sharmadhairya024@gmail.com>
Date: Mon, 16 Mar 2026 12:59:39 +0530
Subject: [PATCH 2/4] Fix graphing calculator minor errors

---
 web/templates/graphing_calculator.html | 44 ++++++++++++++++++++++----
 1 file changed, 37 insertions(+), 7 deletions(-)

diff --git a/web/templates/graphing_calculator.html b/web/templates/graphing_calculator.html
index d9468a48d..6ca5f7ee7 100644
--- a/web/templates/graphing_calculator.html
+++ b/web/templates/graphing_calculator.html
@@ -1,6 +1,8 @@
 {% extends "base.html" %}
 
-{% block title %}Graphing Calculator{% endblock %}
+{% block title %}
+  Graphing Calculator
+{% endblock title %}
 {% block content %}
   <div class="flex flex-col md:flex-row h-screen bg-gray-100 dark:bg-gray-900">
     <!-- Sidebar -->
@@ -319,11 +321,20 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
           if (exprStr.includes("=")) {
               exprStr = equation.split("=")[1].trim();
           }
+          // Validate that the RHS does not reference 'y' (would be circular)
+          try {
+              const parsedRhs = math.parse(exprStr);
+              const yNodes = parsedRhs.filter(n => n.isSymbolNode && n.name.toLowerCase() === "y");
+              if (yNodes.length > 0) {
+                  alert("Explicit equations cannot reference 'y' on the right-hand side.");
+                  return;
+              }
+          } catch (err) {}
           let compiled;
           try {
               compiled = math.compile(exprStr);
           } catch (err) {
-              alert("Error in equation: " + err);
+              alert("Error in equation: " + err.message);
               return;
           }
           ctx.strokeStyle = color;
@@ -342,10 +353,12 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
                   });
                   if (!isFinite(y)) {
                       firstPoint = true;
+                      prevY = null;
                       continue;
                   }
               } catch (err) {
                   firstPoint = true;
+                  prevY = null;
                   continue;
               }
 
@@ -385,8 +398,14 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
           }
           const lhs = parts[0].trim();
           const rhs = parts[1].trim();
-          const lhsCompiled = math.compile(lhs);
-          const rhsCompiled = math.compile(rhs);
+          let lhsCompiled, rhsCompiled;
+          try {
+              lhsCompiled = math.compile(lhs);
+              rhsCompiled = math.compile(rhs);
+          } catch (err) {
+              alert("Error in equation: " + err.message);
+              return;
+          }
 
           function f(x, y) {
               try {
@@ -478,7 +497,7 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
 
       // Determine whether to plot explicit or implicit based on input format
       function plotEquation(equation, color) {
-          if (equation.split("=")[0].trim() === "y") {
+          if (equation.split("=")[0].trim().toLowerCase() === "y") {
               plotExplicit(equation, color);
           } else if (equation.includes("=")) {
               plotImplicit(equation, color);
@@ -504,6 +523,11 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
           }
       }
 
+      // Allow submitting an equation by pressing Enter
+      document.getElementById('equationInput').addEventListener('keydown', function(e) {
+          if (e.key === 'Enter') addEquation();
+      });
+
       // Equation list manipulation
       function addEquation() {
           const eqInput = document.getElementById('equationInput');
@@ -629,8 +653,14 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
           redraw();
       }
 
+      // gridDensity is a separate multiplier so the slider doesn't override the zoom level
+      let gridDensity = 1;
+
       function updateGridSize(value) {
-          scale = parseInt(value);
+          // Map slider (20-80) to a density multiplier; 40 = 1x (neutral)
+          gridDensity = parseInt(value) / 40;
+          // Re-derive scale from the current base zoom and density
+          scale = 40 * gridDensity;
           redraw();
       }
 
@@ -662,4 +692,4 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
           attributeFilter: ['class']
       });
   </script>
-{% endblock %}
+{% endblock content %}

From 03450bb9b0d7f2de2b598538b57d33195f63acab Mon Sep 17 00:00:00 2001
From: Dhairya <sharmadhairya024@gmail.com>
Date: Mon, 16 Mar 2026 13:25:10 +0530
Subject: [PATCH 3/4] Resolve conversations

---
 web/templates/graphing_calculator.html | 41 ++++++++++++++++----------
 1 file changed, 26 insertions(+), 15 deletions(-)

diff --git a/web/templates/graphing_calculator.html b/web/templates/graphing_calculator.html
index 6ca5f7ee7..6c2b15691 100644
--- a/web/templates/graphing_calculator.html
+++ b/web/templates/graphing_calculator.html
@@ -158,7 +158,9 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
       window.addEventListener('resize', resizeCanvas);
 
       // Coordinate system settings
-      let scale = 40; // pixels per unit
+      let baseScale = 40; // zoom level in pixels per unit
+      let gridDensity = 1; // multiplier from the grid-size slider
+      let scale = baseScale * gridDensity; // effective scale used for drawing
       let origin = {
           x: canvas.width / 2,
           y: canvas.height / 2
@@ -220,10 +222,10 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
           const mouseY = e.clientY - rect.top;
           const mousePos = toMathCoords(mouseX, mouseY);
           const zoomFactor = e.deltaY > 0 ? 0.9 : 1.1;
-          const newScale = scale * zoomFactor;
-          origin.x = mouseX - mousePos.x * newScale;
-          origin.y = mouseY + mousePos.y * newScale;
-          scale = newScale;
+          baseScale *= zoomFactor;
+          scale = baseScale * gridDensity;
+          origin.x = mouseX - mousePos.x * scale;
+          origin.y = mouseY + mousePos.y * scale;
           redraw();
       });
 
@@ -329,7 +331,9 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
                   alert("Explicit equations cannot reference 'y' on the right-hand side.");
                   return;
               }
-          } catch (err) {}
+          } catch (err) {
+              console.warn("[plotExplicit] math.parse failed for expression:", exprStr, err);
+          }
           let compiled;
           try {
               compiled = math.compile(exprStr);
@@ -513,7 +517,10 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
                   if (yNodes.length > 0) {
                       hasYVariable = true;
                   }
-              } catch (err) {}
+              } catch (err) {
+                  console.error("[plotEquation] Failed to parse expression:", equation, err);
+                  hasYVariable = true; // treat parse failure as invalid to prevent falling through to plotExplicit
+              }
 
               if (hasYVariable) {
                   alert("Invalid implicit equation format.");
@@ -612,19 +619,26 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
 
       // Pan/Zoom and Control functions
       function zoomIn() {
-          scale *= 1.2;
+          baseScale *= 1.2;
+          scale = baseScale * gridDensity;
           redraw();
       }
 
       function zoomOut() {
-          scale *= 0.8;
+          baseScale *= 0.8;
+          scale = baseScale * gridDensity;
           redraw();
       }
 
       function resetView() {
-          scale = 40;
+          baseScale = 40;
+          gridDensity = 1;
+          scale = baseScale * gridDensity;
           origin.x = canvas.width / 2;
           origin.y = canvas.height / 2;
+          // Sync the slider UI back to neutral (value 40 = midpoint)
+          const slider = document.getElementById('gridSize');
+          if (slider) slider.value = 40;
           redraw();
       }
 
@@ -653,14 +667,11 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
           redraw();
       }
 
-      // gridDensity is a separate multiplier so the slider doesn't override the zoom level
-      let gridDensity = 1;
-
       function updateGridSize(value) {
           // Map slider (20-80) to a density multiplier; 40 = 1x (neutral)
           gridDensity = parseInt(value) / 40;
-          // Re-derive scale from the current base zoom and density
-          scale = 40 * gridDensity;
+          // Recompute effective scale without touching baseScale (zoom)
+          scale = baseScale * gridDensity;
           redraw();
       }
 

From 873608887ded0dab05e2048aa68ee004a5579a43 Mon Sep 17 00:00:00 2001
From: Dhairya <sharmadhairya024@gmail.com>
Date: Mon, 16 Mar 2026 13:39:40 +0530
Subject: [PATCH 4/4] Resolve conversations

---
 web/templates/graphing_calculator.html | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/web/templates/graphing_calculator.html b/web/templates/graphing_calculator.html
index 6c2b15691..ece82c021 100644
--- a/web/templates/graphing_calculator.html
+++ b/web/templates/graphing_calculator.html
@@ -161,6 +161,8 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
       let baseScale = 40; // zoom level in pixels per unit
       let gridDensity = 1; // multiplier from the grid-size slider
       let scale = baseScale * gridDensity; // effective scale used for drawing
+      const MIN_SCALE = 2; // prevent zooming out to nothing
+      const MAX_SCALE = 500; // prevent zooming in to the point of overdraw
       let origin = {
           x: canvas.width / 2,
           y: canvas.height / 2
@@ -222,7 +224,7 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
           const mouseY = e.clientY - rect.top;
           const mousePos = toMathCoords(mouseX, mouseY);
           const zoomFactor = e.deltaY > 0 ? 0.9 : 1.1;
-          baseScale *= zoomFactor;
+          baseScale = Math.min(MAX_SCALE, Math.max(MIN_SCALE, baseScale * zoomFactor));
           scale = baseScale * gridDensity;
           origin.x = mouseX - mousePos.x * scale;
           origin.y = mouseY + mousePos.y * scale;
@@ -321,7 +323,12 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
       function plotExplicit(equation, color) {
           let exprStr = equation;
           if (exprStr.includes("=")) {
-              exprStr = equation.split("=")[1].trim();
+              const eqParts = equation.split("=");
+              if (eqParts.length !== 2) {
+                  alert("Invalid equation: expected exactly one '=' sign.");
+                  return;
+              }
+              exprStr = eqParts[1].trim();
           }
           // Validate that the RHS does not reference 'y' (would be circular)
           try {
@@ -619,13 +626,13 @@ <h2 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">Settings</h
 
       // Pan/Zoom and Control functions
       function zoomIn() {
-          baseScale *= 1.2;
+          baseScale = Math.min(MAX_SCALE, baseScale * 1.2);
           scale = baseScale * gridDensity;
           redraw();
       }
 
       function zoomOut() {
-          baseScale *= 0.8;
+          baseScale = Math.max(MIN_SCALE, baseScale * 0.8);
           scale = baseScale * gridDensity;
           redraw();
       }