* Used both by the persistent status notification and, during the user's quiet hours, to deliver * an alert quietly so it stays visible without disturbing the user (issue #111). + *
+ * As with the alert channels, re-calling for an existing ID updates only name/description, so + * translated names reach upgraded installs (#165) without disturbing the silent behaviour. * * @param manager The NotificationManager * @param channelId The channel ID to create * @param name The channel name * @param description The channel description */ - private static void createSilentChannelIfNotExists( + private static void createOrUpdateSilentChannel( final NotificationManager manager, final String channelId, final String name, final String description) { - if (nonNull(manager.getNotificationChannel(channelId))) { - return; - } - final NotificationChannel channel = new NotificationChannel(channelId, name, NotificationManager.IMPORTANCE_LOW); channel.setDescription(description); channel.enableLights(false); @@ -707,7 +710,13 @@ private static void createSilentChannelIfNotExists( } /** - * Create a notification channel if it doesn't already exist + * Create an alert channel, or update its name/description if it already exists. + *
+ * Re-calling {@code createNotificationChannel} with an existing ID updates only the name,
+ * description and group — Android ignores importance, vibration, lights and sound so the user's
+ * (and the versioned #153) settings are preserved. This is how translated channel names reach
+ * upgraded installs, not just fresh ones (#165): the channel already exists, so we still
+ * re-apply the current locale's name and description.
*
* @param manager The NotificationManager
* @param channelId The channel ID
@@ -716,17 +725,13 @@ private static void createSilentChannelIfNotExists(
* @param ledColor The LED color for notifications
* @param vibrate Whether the channel should vibrate (from the user's Vibrate preference)
*/
- private static void createChannelIfNotExists(
+ private static void createOrUpdateAlertChannel(
final NotificationManager manager,
final String channelId,
final String name,
final String description,
final int ledColor,
final boolean vibrate) {
- if (nonNull(manager.getNotificationChannel(channelId))) {
- return;
- }
-
final NotificationChannel channel = new NotificationChannel(channelId, name, NotificationManager.IMPORTANCE_HIGH);
channel.setDescription(description);
channel.enableLights(true);
diff --git a/app/src/main/java/com/almothafar/simplebatterynotifier/ui/BatteryInsightsActivity.java b/app/src/main/java/com/almothafar/simplebatterynotifier/ui/BatteryInsightsActivity.java
index 7d0d28e..2a3fb00 100644
--- a/app/src/main/java/com/almothafar/simplebatterynotifier/ui/BatteryInsightsActivity.java
+++ b/app/src/main/java/com/almothafar/simplebatterynotifier/ui/BatteryInsightsActivity.java
@@ -213,6 +213,8 @@ private void showDebugMenu() {
return;
}
+ // Debug-only strings: this block runs only in debuggable builds, so its literals are
+ // deliberately left untranslated (no values-ar). Skip them in i18n sweeps (#165).
final String[] options = {
"Show Debug Info",
"Add 50 Test Cycles",
@@ -388,6 +390,8 @@ private void lookUpBatteryModel() {
* Resets all health tracking data, including the first-use date and real charge cycles.
*/
private void resetHealthData() {
+ // Reached only from the debuggable-only debug menu, so these literals are deliberately
+ // left untranslated (no values-ar). Skip them in i18n sweeps (#165).
new MaterialAlertDialogBuilder(this)
.setTitle("Reset ALL health data?")
.setMessage("This deletes ALL tracked battery health data, including the first-use date "
diff --git a/app/src/main/java/com/almothafar/simplebatterynotifier/ui/preference/RingtonePreference.java b/app/src/main/java/com/almothafar/simplebatterynotifier/ui/preference/RingtonePreference.java
index 4b45e1d..47b6358 100644
--- a/app/src/main/java/com/almothafar/simplebatterynotifier/ui/preference/RingtonePreference.java
+++ b/app/src/main/java/com/almothafar/simplebatterynotifier/ui/preference/RingtonePreference.java
@@ -10,6 +10,8 @@
import android.util.Log;
import androidx.preference.Preference;
+import com.almothafar.simplebatterynotifier.R;
+
import static java.util.Objects.nonNull;
/**
@@ -203,7 +205,7 @@ private void updateSummary() {
Log.e(TAG, "Error loading ringtone for " + currentRingtoneUri, e);
}
}
- // Empty or null URI means no ringtone selected (silent/none)
- setSummary("None");
+ // Empty or null URI means no ringtone selected — matches the picker's own "Silent" option (#165)
+ setSummary(getContext().getString(R.string.pref_ringtone_silent));
}
}
diff --git a/app/src/main/res/values-ar/strings.xml b/app/src/main/res/values-ar/strings.xml
index c17ea7c..9ea78ee 100644
--- a/app/src/main/res/values-ar/strings.xml
+++ b/app/src/main/res/values-ar/strings.xml
@@ -152,6 +152,14 @@
+
+