strange behavior of default alias channel

[0ther0ne]

Example

Expected behavior
same output of alias terminal command without strange ANSI escape codes



Environment

• OS: Linux 6.17.7
• TV version: 0.13.8
• shell: bash
• terminal: Black Box
• default config.toml

What I've already tried

• edit alias.toml with:

output = "{strip_ansi|split:=:0}"
ansi = false

but same behavior :(

logo script is: https://codeberg.org/ldm/scr0ll/src/branch/main/NOscr0ll/shebangGREEN.sh

[alexpasmantier]

Does the same happen if you try using 99c7c65 ?

[0ther0ne]

Does the same happen if you try using 99c7c65 ?

yes, same as before

[mheuvel-dev]

I can confirm that I still have the same problem as reported in the closed issue, #735. It seems to be the same (or at least very similar) as reported here.

I have upgraded to the latest release 0.13.9 and I've re-generated the alias channel.

[mheuvel-dev]

I've probably found the problem. The alias channel uses an interactive shell which may first loads a message of the day (motd). This causes problems.

I've adjusted the channel by:
command = "bash -c 'shopt -s expand_aliases; source ~/.bashrc &>/dev/null; alias' 2>/dev/null"

I'm not sure how to make it generic for other shells.

[0ther0ne]

now there are no alias at all

noalias.mp4

[mheuvel-dev]

This needs some more thought.
Also note that I expect the channel to present me the aliases inside my current session instead of the ones from any new, fresh interactive session.

[alexpasmantier]

The thing here is tv needs to access an interactive shell in order to lookup aliases (which would otherwise be empty, or contain only a couple of predefined ones).
Accessing an interactive shell means we need to source the shell config file (e.g. .zshrc for zsh, bashrc for bash, etc.) which is in most cases where all your user aliases come from and we can never guarantee that it doesn't contain commands that will generate output / try to read from stdin / etc.

This leads to the two cases you guys are observing:

• some command in the background (issued by sourcing zshrc or similar) tries to access the terminal controlling tv (before it has time to spawn its UI) and that causes a SIGTTOU to be sent which suspends the application
• I'm guessing because of the timings involved the above doesn't always happen and sometimes some output is captured directly and displayed

[alexpasmantier]

Ok I'm getting consistent successful results if I wait for tv for spawn its TUI before the interactive command is issued but I'll need to put a bit of thought into it to find a satisfactory implementation.

[0ther0ne]

thanks a lot @alexpasmantier

[alexpasmantier]

Would you guys mind trying out #770 and tell me if that solves the issue for you?

[alexpasmantier]

I'm getting consistent results on two different machines.

[0ther0ne]

if I already have television installed on my system, and I compile the version with the fix in a separate directory and launch it with ./tv alias, is that correct?

nothing changes for me :( still the same output