-
Notifications
You must be signed in to change notification settings - Fork 366
panic in the promotions! #4072
Copy link
Copy link
Closed
Labels
area/controllerAffects the (main) controllerAffects the (main) controllerkind/bugSomething isn't working as intended; If unsure that something IS a bug, start a discussion insteadSomething isn't working as intended; If unsure that something IS a bug, start a discussion insteadpriority/highNeeds to be addressed sooner rather than laterNeeds to be addressed sooner rather than later
Metadata
Metadata
Labels
area/controllerAffects the (main) controllerAffects the (main) controllerkind/bugSomething isn't working as intended; If unsure that something IS a bug, start a discussion insteadSomething isn't working as intended; If unsure that something IS a bug, start a discussion insteadpriority/highNeeds to be addressed sooner rather than laterNeeds to be addressed sooner rather than later
A few times now, we've seen cases where a panic while executing some promotion step has not only caused the entire promotion to fail, but it has also prevented proper bookkeeping in terms of recording the outcome of those promotion steps that did run successfully. This creates the illusion that the panic has occurred at step 0.
I thought we'd improved this recently with modification to the step execution engine to always update promotion status between steps, but I saw this problem present itself again today and that change seems not to have paid off.
More investigation is required, but since this problem has now obstructed the troubleshooting of other problems multiple times now, we should prioritize this.