From d9ce3a20f9908e56d222d991f45ca52c647b2d7e Mon Sep 17 00:00:00 2001 From: Artem Shcherbatiuk Date: Wed, 28 Jan 2026 20:45:49 +0100 Subject: [PATCH 1/4] fix: removed unused code --- make/lint.mk | 2 +- tests/upgrade/sdktypes.go | 56 ---------------------------- x/deployment/handler/handler_test.go | 4 +- x/escrow/keeper/keeper_test.go | 4 -- x/market/handler/handler_test.go | 23 ------------ 5 files changed, 3 insertions(+), 86 deletions(-) delete mode 100644 tests/upgrade/sdktypes.go diff --git a/make/lint.mk b/make/lint.mk index f2d46c3ead..4b42045c4a 100644 --- a/make/lint.mk +++ b/make/lint.mk @@ -14,7 +14,7 @@ SUBLINTERS = unused \ .PHONY: lint-go lint-go: $(GOLANGCI_LINT) - $(GOLANGCI_LINT_RUN) ./... --issues-exit-code=0 --timeout=10m + $(GOLANGCI_LINT) run ./... --timeout=10m .PHONY: lint-go-% lint-go-%: $(GOLANGCI_LINT) diff --git a/tests/upgrade/sdktypes.go b/tests/upgrade/sdktypes.go deleted file mode 100644 index 990506122c..0000000000 --- a/tests/upgrade/sdktypes.go +++ /dev/null @@ -1,56 +0,0 @@ -package upgrade - -import ( - "encoding/json" - - upgradetypes "cosmossdk.io/x/upgrade/types" - sdk "github.com/cosmos/cosmos-sdk/types" -) - -// These files defines sdk specific types necessary to perform upgrade simulation. -// we're not using SDK generated types to prevent import of different types of cosmos sdk - -type nodeStatus struct { - SyncInfo struct { - LatestBlockHeight string `json:"latest_block_height"` - CatchingUp bool `json:"catching_up"` - } `json:"sync_info"` -} - -type votingParams struct { - VotingPeriod string `json:"voting_period"` -} - -type depositParams struct { - MinDeposit sdk.Coins `json:"min_deposit"` -} - -type govParams struct { - VotingParams votingParams `json:"voting_params"` - DepositParams depositParams `json:"deposit_params"` -} - -type proposalResp struct { - ID string `json:"id"` - Title string `json:"title"` -} - -type proposalsResp struct { - Proposals []proposalResp `json:"proposals"` -} - -type SoftwareUpgradeProposal struct { - Type string `json:"@type"` - Authority string `json:"authority"` - Plan upgradetypes.Plan `json:"plan"` -} - -type ProposalMsg struct { - // Msgs defines an array of sdk.Msgs proto-JSON-encoded as Anys. - Messages []json.RawMessage `json:"messages,omitempty"` - Metadata string `json:"metadata"` - Deposit string `json:"deposit"` - Title string `json:"title"` - Summary string `json:"summary"` - Expedited bool `json:"expedited"` -} diff --git a/x/deployment/handler/handler_test.go b/x/deployment/handler/handler_test.go index 4752b53eba..e42ee22bd1 100644 --- a/x/deployment/handler/handler_test.go +++ b/x/deployment/handler/handler_test.go @@ -19,7 +19,7 @@ import ( authzkeeper "github.com/cosmos/cosmos-sdk/x/authz/keeper" distrtypes "github.com/cosmos/cosmos-sdk/x/distribution/types" - "pkg.akt.dev/go/node/deployment/v1" + v1 "pkg.akt.dev/go/node/deployment/v1" "pkg.akt.dev/go/node/deployment/v1beta4" emodule "pkg.akt.dev/go/node/escrow/module" ev1 "pkg.akt.dev/go/node/escrow/v1" @@ -440,7 +440,7 @@ func TestFundedDeployment(t *testing.T) { msg.Groups = append(msg.Groups, group.GroupSpec) } - //owner := sdk.MustAccAddressFromBech32(deployment.ID.Owner) + // owner := sdk.MustAccAddressFromBech32(deployment.ID.Owner) suite.PrepareMocks(func(ts *state.TestSuite) { bkeeper := ts.BankKeeper() bkeeper. diff --git a/x/escrow/keeper/keeper_test.go b/x/escrow/keeper/keeper_test.go index b7c14d1d30..65acf367a5 100644 --- a/x/escrow/keeper/keeper_test.go +++ b/x/escrow/keeper/keeper_test.go @@ -17,10 +17,6 @@ import ( "pkg.akt.dev/node/testutil/state" ) -type kTestSuite struct { - *state.TestSuite -} - func Test_AccountSettlement(t *testing.T) { ssuite := state.SetupTestSuite(t) ctx := ssuite.Context() diff --git a/x/market/handler/handler_test.go b/x/market/handler/handler_test.go index cc7641ee9d..0f5181e59e 100644 --- a/x/market/handler/handler_test.go +++ b/x/market/handler/handler_test.go @@ -1427,26 +1427,3 @@ func (st *testSuite) createProvider(attr attr.Attributes) ptypes.Provider { return prov } - -func (st *testSuite) createDeployment() (dv1.Deployment, dtypes.Groups) { - st.t.Helper() - - deployment := testutil.Deployment(st.t) - group := testutil.DeploymentGroup(st.t, deployment.ID, 0) - group.GroupSpec.Resources = dtypes.ResourceUnits{ - { - Resources: testutil.ResourceUnits(st.t), - Count: 1, - Price: testutil.AkashDecCoinRandom(st.t), - }, - } - groups := dtypes.Groups{ - group, - } - - for i := range groups { - groups[i].State = dtypes.GroupOpen - } - - return deployment, groups -} From da1dd23870752942aeb1d91e363b2b781f6659ea Mon Sep 17 00:00:00 2001 From: Artem Shcherbatiuk Date: Wed, 28 Jan 2026 21:18:35 +0100 Subject: [PATCH 2/4] fix: enabled recommended linter checks --- .golangci.yaml | 58 +++++++++++++++++++---------- cmd/akash/cmd/genaccounts.go | 6 +-- make/lint.mk | 14 ------- upgrades/software/v1.1.0/upgrade.go | 3 ++ util/cli/configs.go | 2 +- util/server/server.go | 2 +- x/audit/module.go | 2 +- x/cert/module.go | 2 +- x/deployment/keeper/keeper.go | 4 +- x/deployment/module.go | 2 +- x/escrow/module.go | 2 +- x/market/hooks/hooks.go | 5 ++- x/provider/module.go | 2 +- x/take/module.go | 2 +- 14 files changed, 59 insertions(+), 47 deletions(-) diff --git a/.golangci.yaml b/.golangci.yaml index 12fe1c24c9..8179b0afab 100644 --- a/.golangci.yaml +++ b/.golangci.yaml @@ -1,40 +1,60 @@ --- version: "2" +issues: + max-issues-per-linter: 1000 + max-same-issues: 1000 linters: default: none enable: + - bodyclose - copyloopvar + - cyclop - errcheck - errchkjson + - errorlint - goconst - gocritic - gosec - govet - ineffassign - misspell + - nilerr + - nilnil + - noctx + # - nolintlint # very good linter, but there are 109 issues to solve - prealloc + - revive - staticcheck + - unconvert - unparam - unused -settings: - gocritic: - disabled-checks: - - ifElseChain - - singleCaseSwitch -exclusions: - generated: lax - presets: - - comments - - common-false-positives - - legacy - - std-error-handling - rules: - - path: (.+)\.go$ - text: comment on exported (method|function|type|const|var) - paths: - - third_party$ - - builtin$ - - examples$ + - wastedassign + exclusions: + generated: lax + presets: + - comments + - common-false-positives + - legacy + - std-error-handling + rules: + - path: (.+)\.go$ + text: comment on exported (method|function|type|const|var) + paths: + - third_party$ + - builtin$ + - examples$ + settings: + cyclop: + max-complexity: 40 + gocritic: + disabled-checks: + - ifElseChain + - singleCaseSwitch + revive: + rules: + - name: context-as-argument + - name: error-return + - name: error-naming formatters: enable: - gofmt diff --git a/cmd/akash/cmd/genaccounts.go b/cmd/akash/cmd/genaccounts.go index bbc49ae1be..d26c16be58 100644 --- a/cmd/akash/cmd/genaccounts.go +++ b/cmd/akash/cmd/genaccounts.go @@ -64,7 +64,7 @@ contain valid denominations. Accounts may optionally be supplied with vesting pa info, err := kb.Key(args[0]) if err != nil { - return fmt.Errorf("failed to get address from Keybase: %v", err) + return fmt.Errorf("failed to get address from Keybase: %w", err) } addr, err = info.GetAddress() @@ -75,7 +75,7 @@ contain valid denominations. Accounts may optionally be supplied with vesting pa coins, err := sdk.ParseCoinsNormalized(args[1]) if err != nil { - return fmt.Errorf("failed to parse coins: %v", err) + return fmt.Errorf("failed to parse coins: %w", err) } vestingStart, _ := cmd.Flags().GetInt64(flagVestingStart) @@ -84,7 +84,7 @@ contain valid denominations. Accounts may optionally be supplied with vesting pa vestingAmt, err := sdk.ParseCoinsNormalized(vestingAmtStr) if err != nil { - return fmt.Errorf("failed to parse vesting amount: %v", err) + return fmt.Errorf("failed to parse vesting amount: %w", err) } // create concrete account type based on input parameters diff --git a/make/lint.mk b/make/lint.mk index 4b42045c4a..bbd7a8003e 100644 --- a/make/lint.mk +++ b/make/lint.mk @@ -1,17 +1,3 @@ -SUBLINTERS = unused \ - misspell \ - gofmt \ - gocritic \ - goconst \ - ineffassign \ - unparam \ - staticcheck \ - revive \ - gosec \ - exportloopref \ - prealloc -# TODO: ^ gochecknoglobals - .PHONY: lint-go lint-go: $(GOLANGCI_LINT) $(GOLANGCI_LINT) run ./... --timeout=10m diff --git a/upgrades/software/v1.1.0/upgrade.go b/upgrades/software/v1.1.0/upgrade.go index 8e244037ad..922ae9c81a 100644 --- a/upgrades/software/v1.1.0/upgrade.go +++ b/upgrades/software/v1.1.0/upgrade.go @@ -360,6 +360,9 @@ func (up *upgrade) OnGroupClosed(ctx sdk.Context, id dv1.GroupID) error { func (up *upgrade) OnEscrowPaymentClosed(ctx sdk.Context, obj etypes.Payment) error { id, err := mv1.LeaseIDFromPaymentID(obj.ID) if err != nil { + // Escrow payments can belong to different scopes (e.g., bid-scoped, deployment-scoped). + // This upgrade hook only processes lease payments (deployment-scoped). + // Silently ignore non-lease payment closures. return nil } diff --git a/util/cli/configs.go b/util/cli/configs.go index 08633d8fae..5d98a156a4 100644 --- a/util/cli/configs.go +++ b/util/cli/configs.go @@ -315,7 +315,7 @@ func interceptConfigs(rootViper *viper.Viper, customAppTemplate string, customCo tmcfg.EnsureRoot(rootDir) if err = conf.ValidateBasic(); err != nil { - return nil, fmt.Errorf("error in config file: %v", err) + return nil, fmt.Errorf("error in config file: %w", err) } conf.RPC.PprofListenAddress = "localhost:6060" diff --git a/util/server/server.go b/util/server/server.go index 454f7aa09c..47e125f856 100644 --- a/util/server/server.go +++ b/util/server/server.go @@ -135,7 +135,7 @@ func ExportCmd(appExporter servertypes.AppExporter, defaultNodeHome string) *cob ) if err != nil { - return fmt.Errorf("error exporting state: %v", err) + return fmt.Errorf("error exporting state: %w", err) } doc, err := tmtypes.GenesisDocFromFile(sctx.Config.GenesisFile()) diff --git a/x/audit/module.go b/x/audit/module.go index b4d0078e2e..191de19386 100644 --- a/x/audit/module.go +++ b/x/audit/module.go @@ -73,7 +73,7 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo err := cdc.UnmarshalJSON(bz, &data) if err != nil { - return fmt.Errorf("failed to unmarshal %s genesis state: %v", types.ModuleName, err) + return fmt.Errorf("failed to unmarshal %s genesis state: %w", types.ModuleName, err) } return ValidateGenesis(&data) diff --git a/x/cert/module.go b/x/cert/module.go index 29b5e14259..ab266fbfca 100644 --- a/x/cert/module.go +++ b/x/cert/module.go @@ -77,7 +77,7 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo err := cdc.UnmarshalJSON(bz, &data) if err != nil { - return fmt.Errorf("failed to unmarshal %s genesis state: %v", types.ModuleName, err) + return fmt.Errorf("failed to unmarshal %s genesis state: %w", types.ModuleName, err) } return ValidateGenesis(&data) diff --git a/x/deployment/keeper/keeper.go b/x/deployment/keeper/keeper.go index e7ff3b835d..0362cd5edb 100644 --- a/x/deployment/keeper/keeper.go +++ b/x/deployment/keeper/keeper.go @@ -7,7 +7,7 @@ import ( "github.com/cosmos/cosmos-sdk/codec" "github.com/cosmos/cosmos-sdk/telemetry" sdk "github.com/cosmos/cosmos-sdk/types" - "pkg.akt.dev/go/node/deployment/v1" + v1 "pkg.akt.dev/go/node/deployment/v1" types "pkg.akt.dev/go/node/deployment/v1beta4" ) @@ -283,7 +283,7 @@ func (k Keeper) OnCloseGroup(ctx sdk.Context, group types.Group, state types.Gro key, err := GroupKey(GroupStateToPrefix(group.State), group.ID) if err != nil { - return fmt.Errorf("%s: failed to encode group key", err) + return fmt.Errorf("%w: failed to encode group key", err) } store.Set(key, k.cdc.MustMarshal(&group)) diff --git a/x/deployment/module.go b/x/deployment/module.go index a6a8bcc87a..54d333dab9 100644 --- a/x/deployment/module.go +++ b/x/deployment/module.go @@ -84,7 +84,7 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo var data types.GenesisState err := cdc.UnmarshalJSON(bz, &data) if err != nil { - return fmt.Errorf("failed to unmarshal %s genesis state: %v", v1.ModuleName, err) + return fmt.Errorf("failed to unmarshal %s genesis state: %w", v1.ModuleName, err) } return ValidateGenesis(&data) } diff --git a/x/escrow/module.go b/x/escrow/module.go index 92ffd660d1..8cc82e3df9 100644 --- a/x/escrow/module.go +++ b/x/escrow/module.go @@ -73,7 +73,7 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo err := cdc.UnmarshalJSON(bz, &data) if err != nil { - return fmt.Errorf("failed to unmarshal %s genesis state: %v", emodule.ModuleName, err) + return fmt.Errorf("failed to unmarshal %s genesis state: %w", emodule.ModuleName, err) } return ValidateGenesis(&data) diff --git a/x/market/hooks/hooks.go b/x/market/hooks/hooks.go index 846252e69a..cf834f2919 100644 --- a/x/market/hooks/hooks.go +++ b/x/market/hooks/hooks.go @@ -70,7 +70,10 @@ func (h *hooks) OnEscrowAccountClosed(ctx sdk.Context, obj etypes.Account) error func (h *hooks) OnEscrowPaymentClosed(ctx sdk.Context, obj etypes.Payment) error { id, err := mv1.LeaseIDFromPaymentID(obj.ID) if err != nil { - return nil + // Escrow payments can belong to different scopes (e.g., bid-scoped, deployment-scoped). + // Market module only handles lease payments (deployment-scoped). + // Silently ignore non-lease payment closures. + return nil //nolint:nilerr // non-lease payment, not an error for this hook } bid, ok := h.mkeeper.GetBid(ctx, id.BidID()) diff --git a/x/provider/module.go b/x/provider/module.go index 4123e310c1..7e7461a30c 100644 --- a/x/provider/module.go +++ b/x/provider/module.go @@ -80,7 +80,7 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo var data types.GenesisState err := cdc.UnmarshalJSON(bz, &data) if err != nil { - return fmt.Errorf("failed to unmarshal %s genesis state: %v", types.ModuleName, err) + return fmt.Errorf("failed to unmarshal %s genesis state: %w", types.ModuleName, err) } return ValidateGenesis(&data) } diff --git a/x/take/module.go b/x/take/module.go index fb16f4ea61..bd3ac71313 100644 --- a/x/take/module.go +++ b/x/take/module.go @@ -76,7 +76,7 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo err := cdc.UnmarshalJSON(bz, &data) if err != nil { - return fmt.Errorf("failed to unmarshal %s genesis state: %v", types.ModuleName, err) + return fmt.Errorf("failed to unmarshal %s genesis state: %w", types.ModuleName, err) } return ValidateGenesis(&data) From cd755e77951802fe8f10fb0935972a0770e4452a Mon Sep 17 00:00:00 2001 From: Artem Shcherbatiuk Date: Thu, 29 Jan 2026 14:43:39 +0100 Subject: [PATCH 3/4] fix: rollback error wrapping --- .golangci.yaml | 3 +++ cmd/akash/cmd/genaccounts.go | 6 +++--- util/cli/configs.go | 2 +- util/server/server.go | 2 +- x/audit/module.go | 2 +- x/cert/module.go | 2 +- x/deployment/handler/handler_test.go | 2 +- x/deployment/keeper/keeper.go | 4 ++-- x/deployment/module.go | 2 +- x/escrow/module.go | 2 +- x/provider/module.go | 2 +- x/take/module.go | 2 +- 12 files changed, 17 insertions(+), 14 deletions(-) diff --git a/.golangci.yaml b/.golangci.yaml index 8179b0afab..08b8433ac0 100644 --- a/.golangci.yaml +++ b/.golangci.yaml @@ -44,12 +44,15 @@ linters: - builtin$ - examples$ settings: + errorlint: + errorf: false cyclop: max-complexity: 40 gocritic: disabled-checks: - ifElseChain - singleCaseSwitch + - commentFormatting revive: rules: - name: context-as-argument diff --git a/cmd/akash/cmd/genaccounts.go b/cmd/akash/cmd/genaccounts.go index d26c16be58..bbc49ae1be 100644 --- a/cmd/akash/cmd/genaccounts.go +++ b/cmd/akash/cmd/genaccounts.go @@ -64,7 +64,7 @@ contain valid denominations. Accounts may optionally be supplied with vesting pa info, err := kb.Key(args[0]) if err != nil { - return fmt.Errorf("failed to get address from Keybase: %w", err) + return fmt.Errorf("failed to get address from Keybase: %v", err) } addr, err = info.GetAddress() @@ -75,7 +75,7 @@ contain valid denominations. Accounts may optionally be supplied with vesting pa coins, err := sdk.ParseCoinsNormalized(args[1]) if err != nil { - return fmt.Errorf("failed to parse coins: %w", err) + return fmt.Errorf("failed to parse coins: %v", err) } vestingStart, _ := cmd.Flags().GetInt64(flagVestingStart) @@ -84,7 +84,7 @@ contain valid denominations. Accounts may optionally be supplied with vesting pa vestingAmt, err := sdk.ParseCoinsNormalized(vestingAmtStr) if err != nil { - return fmt.Errorf("failed to parse vesting amount: %w", err) + return fmt.Errorf("failed to parse vesting amount: %v", err) } // create concrete account type based on input parameters diff --git a/util/cli/configs.go b/util/cli/configs.go index 5d98a156a4..08633d8fae 100644 --- a/util/cli/configs.go +++ b/util/cli/configs.go @@ -315,7 +315,7 @@ func interceptConfigs(rootViper *viper.Viper, customAppTemplate string, customCo tmcfg.EnsureRoot(rootDir) if err = conf.ValidateBasic(); err != nil { - return nil, fmt.Errorf("error in config file: %w", err) + return nil, fmt.Errorf("error in config file: %v", err) } conf.RPC.PprofListenAddress = "localhost:6060" diff --git a/util/server/server.go b/util/server/server.go index 47e125f856..454f7aa09c 100644 --- a/util/server/server.go +++ b/util/server/server.go @@ -135,7 +135,7 @@ func ExportCmd(appExporter servertypes.AppExporter, defaultNodeHome string) *cob ) if err != nil { - return fmt.Errorf("error exporting state: %w", err) + return fmt.Errorf("error exporting state: %v", err) } doc, err := tmtypes.GenesisDocFromFile(sctx.Config.GenesisFile()) diff --git a/x/audit/module.go b/x/audit/module.go index 191de19386..b4d0078e2e 100644 --- a/x/audit/module.go +++ b/x/audit/module.go @@ -73,7 +73,7 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo err := cdc.UnmarshalJSON(bz, &data) if err != nil { - return fmt.Errorf("failed to unmarshal %s genesis state: %w", types.ModuleName, err) + return fmt.Errorf("failed to unmarshal %s genesis state: %v", types.ModuleName, err) } return ValidateGenesis(&data) diff --git a/x/cert/module.go b/x/cert/module.go index ab266fbfca..29b5e14259 100644 --- a/x/cert/module.go +++ b/x/cert/module.go @@ -77,7 +77,7 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo err := cdc.UnmarshalJSON(bz, &data) if err != nil { - return fmt.Errorf("failed to unmarshal %s genesis state: %w", types.ModuleName, err) + return fmt.Errorf("failed to unmarshal %s genesis state: %v", types.ModuleName, err) } return ValidateGenesis(&data) diff --git a/x/deployment/handler/handler_test.go b/x/deployment/handler/handler_test.go index e42ee22bd1..8618f46798 100644 --- a/x/deployment/handler/handler_test.go +++ b/x/deployment/handler/handler_test.go @@ -440,7 +440,7 @@ func TestFundedDeployment(t *testing.T) { msg.Groups = append(msg.Groups, group.GroupSpec) } - // owner := sdk.MustAccAddressFromBech32(deployment.ID.Owner) + //owner := sdk.MustAccAddressFromBech32(deployment.ID.Owner) suite.PrepareMocks(func(ts *state.TestSuite) { bkeeper := ts.BankKeeper() bkeeper. diff --git a/x/deployment/keeper/keeper.go b/x/deployment/keeper/keeper.go index 0362cd5edb..e7ff3b835d 100644 --- a/x/deployment/keeper/keeper.go +++ b/x/deployment/keeper/keeper.go @@ -7,7 +7,7 @@ import ( "github.com/cosmos/cosmos-sdk/codec" "github.com/cosmos/cosmos-sdk/telemetry" sdk "github.com/cosmos/cosmos-sdk/types" - v1 "pkg.akt.dev/go/node/deployment/v1" + "pkg.akt.dev/go/node/deployment/v1" types "pkg.akt.dev/go/node/deployment/v1beta4" ) @@ -283,7 +283,7 @@ func (k Keeper) OnCloseGroup(ctx sdk.Context, group types.Group, state types.Gro key, err := GroupKey(GroupStateToPrefix(group.State), group.ID) if err != nil { - return fmt.Errorf("%w: failed to encode group key", err) + return fmt.Errorf("%s: failed to encode group key", err) } store.Set(key, k.cdc.MustMarshal(&group)) diff --git a/x/deployment/module.go b/x/deployment/module.go index 54d333dab9..a6a8bcc87a 100644 --- a/x/deployment/module.go +++ b/x/deployment/module.go @@ -84,7 +84,7 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo var data types.GenesisState err := cdc.UnmarshalJSON(bz, &data) if err != nil { - return fmt.Errorf("failed to unmarshal %s genesis state: %w", v1.ModuleName, err) + return fmt.Errorf("failed to unmarshal %s genesis state: %v", v1.ModuleName, err) } return ValidateGenesis(&data) } diff --git a/x/escrow/module.go b/x/escrow/module.go index 8cc82e3df9..92ffd660d1 100644 --- a/x/escrow/module.go +++ b/x/escrow/module.go @@ -73,7 +73,7 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo err := cdc.UnmarshalJSON(bz, &data) if err != nil { - return fmt.Errorf("failed to unmarshal %s genesis state: %w", emodule.ModuleName, err) + return fmt.Errorf("failed to unmarshal %s genesis state: %v", emodule.ModuleName, err) } return ValidateGenesis(&data) diff --git a/x/provider/module.go b/x/provider/module.go index 7e7461a30c..4123e310c1 100644 --- a/x/provider/module.go +++ b/x/provider/module.go @@ -80,7 +80,7 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo var data types.GenesisState err := cdc.UnmarshalJSON(bz, &data) if err != nil { - return fmt.Errorf("failed to unmarshal %s genesis state: %w", types.ModuleName, err) + return fmt.Errorf("failed to unmarshal %s genesis state: %v", types.ModuleName, err) } return ValidateGenesis(&data) } diff --git a/x/take/module.go b/x/take/module.go index bd3ac71313..fb16f4ea61 100644 --- a/x/take/module.go +++ b/x/take/module.go @@ -76,7 +76,7 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo err := cdc.UnmarshalJSON(bz, &data) if err != nil { - return fmt.Errorf("failed to unmarshal %s genesis state: %w", types.ModuleName, err) + return fmt.Errorf("failed to unmarshal %s genesis state: %v", types.ModuleName, err) } return ValidateGenesis(&data) From 8ddc5f34b7bf57ff2117acfd19e755df0dd5a6f8 Mon Sep 17 00:00:00 2001 From: Artem Shcherbatiuk Date: Thu, 29 Jan 2026 14:45:15 +0100 Subject: [PATCH 4/4] fix: cleanup --- x/deployment/handler/handler_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x/deployment/handler/handler_test.go b/x/deployment/handler/handler_test.go index 8618f46798..4752b53eba 100644 --- a/x/deployment/handler/handler_test.go +++ b/x/deployment/handler/handler_test.go @@ -19,7 +19,7 @@ import ( authzkeeper "github.com/cosmos/cosmos-sdk/x/authz/keeper" distrtypes "github.com/cosmos/cosmos-sdk/x/distribution/types" - v1 "pkg.akt.dev/go/node/deployment/v1" + "pkg.akt.dev/go/node/deployment/v1" "pkg.akt.dev/go/node/deployment/v1beta4" emodule "pkg.akt.dev/go/node/escrow/module" ev1 "pkg.akt.dev/go/node/escrow/v1"