From fdf7a58beec0339112af772dabbb844f567c2f94 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Tue, 10 Mar 2026 12:43:15 +0000 Subject: [PATCH] fix(cdk): Remove remediation language from generic 400 error message The default 400 error message contained 'Please check your request parameters' which violates the writing-good-error-messages guidelines: - Embeds remediation language ('Please check...') - Redundantly prefixes with 'HTTP Status Code: 400. Error:' - Not specific enough to be actionable Simplified to 'Bad request.' which is concise and does not embed unhelpful remediation suggestions. Connectors should use HttpResponseFilter with custom error_message templates to provide API-specific context for 400 errors. Related to https://github.com/airbytehq/airbyte-internal-issues/issues/15976 Related to https://github.com/airbytehq/oncall/issues/11577 Co-Authored-By: bot_apk --- .../streams/http/error_handlers/default_error_mapping.py | 2 +- .../requesters/error_handlers/test_default_error_handler.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/airbyte_cdk/sources/streams/http/error_handlers/default_error_mapping.py b/airbyte_cdk/sources/streams/http/error_handlers/default_error_mapping.py index 45716768f..44b20fb4e 100644 --- a/airbyte_cdk/sources/streams/http/error_handlers/default_error_mapping.py +++ b/airbyte_cdk/sources/streams/http/error_handlers/default_error_mapping.py @@ -31,7 +31,7 @@ 400: ErrorResolution( response_action=ResponseAction.FAIL, failure_type=FailureType.system_error, - error_message="HTTP Status Code: 400. Error: Bad request. Please check your request parameters.", + error_message="Bad request.", ), 401: ErrorResolution( response_action=ResponseAction.FAIL, diff --git a/unit_tests/sources/declarative/requesters/error_handlers/test_default_error_handler.py b/unit_tests/sources/declarative/requesters/error_handlers/test_default_error_handler.py index bf4e1e321..b38bce219 100644 --- a/unit_tests/sources/declarative/requesters/error_handlers/test_default_error_handler.py +++ b/unit_tests/sources/declarative/requesters/error_handlers/test_default_error_handler.py @@ -92,7 +92,7 @@ def test_default_error_handler_with_default_response_filter( ), ResponseAction.RETRY, FailureType.system_error, - "HTTP Status Code: 400. Error: Bad request. Please check your request parameters.", + "Bad request.", ), ( "_with_http_response_status_402_fail_with_default_failure_type",