- <% requests = request_items(route, plan_verbose: plan_verbose) -%>
<% unless requests.empty? -%>
<% requests.each do |request| -%>
@@ -55,7 +64,6 @@
<% end -%>
<% end -%>
- <% responses = response_items(route, plan_verbose: plan_verbose) -%>
<% unless responses.empty? -%>
<% responses.each do |response| -%>
diff --git a/lib/openapi_first/test/coverage/html_reporter.rb b/lib/openapi_first/test/coverage/html_reporter.rb
index 7f8cf65d..56134a13 100644
--- a/lib/openapi_first/test/coverage/html_reporter.rb
+++ b/lib/openapi_first/test/coverage/html_reporter.rb
@@ -18,6 +18,11 @@ def report(coverage_result)
html = TEMPLATE.result(Context.new(coverage_result, @verbose).get_binding)
FileUtils.mkdir_p(File.dirname(@output))
File.write(@output, html)
+ coverage_result.plans.each do |plan|
+ next if plan.coverage >= 100
+
+ @logger.info "API validation coverage for #{plan.api_identifier}: #{plan.coverage.round(4)}%"
+ end
@logger.info "API coverage report written to #{@output}"
end
diff --git a/lib/openapi_first/test/coverage/html_reporter/context.rb b/lib/openapi_first/test/coverage/html_reporter/context.rb
index 654f7934..d2009dab 100644
--- a/lib/openapi_first/test/coverage/html_reporter/context.rb
+++ b/lib/openapi_first/test/coverage/html_reporter/context.rb
@@ -12,12 +12,13 @@ class Context
'API Coverage did not detect any API requests for the registered ' \
'API descriptions. Make sure to observe your application using OpenapiFirst::Test.'
- attr_reader :coverage, :plans, :verbose
+ attr_reader :coverage, :plans, :verbose, :generated_at
- def initialize(coverage_result, verbose)
+ def initialize(coverage_result, verbose, generated_at: Time.now)
@coverage = coverage_result.coverage
@plans = coverage_result.plans
@verbose = verbose
+ @generated_at = generated_at.strftime('%Y-%m-%d %H:%M:%S %z')
end
# Helper for ERB rendering only — exposes this context's binding so the
@@ -26,14 +27,8 @@ def get_binding # rubocop:disable Naming/AccessorMethodName
binding
end
- def expand_plan?(plan)
- verbose || plan.done?
- end
-
def visible_routes(plan)
- return plan.routes if expand_plan?(plan)
-
- plan.routes.reject(&:finished?)
+ plan.routes
end
def any_request_made?(route)
@@ -51,17 +46,14 @@ def uncovered_responses_count(route)
route.responses.count { |r| !r.finished? }
end
- def request_items(route, plan_verbose:)
+ def request_items(route)
return [] unless any_request_made?(route) && route.requests.any?(&:content_type)
- plan_verbose ? route.requests : route.requests.reject(&:finished?)
+ route.requests
end
- def response_items(route, plan_verbose:)
- return [] unless plan_verbose || any_request_made?(route)
- return route.responses if plan_verbose || route.responses.any? { |r| !r.finished? }
-
- []
+ def response_items(route)
+ route.responses
end
def h(text)
diff --git a/spec/test_spec.rb b/spec/test_spec.rb
index 5efae466..6d5af0c1 100644
--- a/spec/test_spec.rb
+++ b/spec/test_spec.rb
@@ -224,6 +224,28 @@ def call(_env)
described_class.handle_exit
end.not_to raise_error
end
+
+ context 'when coverage exceeds minimum_coverage by at least 1%' do
+ before do
+ configuration.minimum_coverage = 99
+ end
+
+ it 'warns to increase minimum_coverage' do
+ expect(described_class.logger).to receive(:warn).with(/increase minimum_coverage to 100/)
+ described_class.handle_exit
+ end
+ end
+
+ context 'when coverage exceeds minimum_coverage by less than 1%' do
+ before do
+ configuration.minimum_coverage = 99.5
+ end
+
+ it 'does not warn' do
+ expect(described_class.logger).not_to receive(:warn)
+ described_class.handle_exit
+ end
+ end
end
context 'with report_coverage = true' do