docs: add CONTRIBUTING.md#9
Open
okwn wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
1 issue found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="05_PR_CANDIDATES.md">
<violation number="1" location="05_PR_CANDIDATES.md:60">
P2: Documentation recommends editing auto-generated files without warning about the Fern generation workflow, creating a futile-edit maintainability risk.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| | Lint | ⚠️ | 2 fixable ruff issues (import sorting) | | ||
| | License | ⚠️ | pyproject.toml says MIT but no LICENSE file found | | ||
|
|
||
| ## Ruff Issues Found |
There was a problem hiding this comment.
P2: Documentation recommends editing auto-generated files without warning about the Fern generation workflow, creating a futile-edit maintainability risk.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At 05_PR_CANDIDATES.md, line 60:
<comment>Documentation recommends editing auto-generated files without warning about the Fern generation workflow, creating a futile-edit maintainability risk.</comment>
<file context>
@@ -0,0 +1,62 @@
+| Lint | ⚠️ | 2 fixable ruff issues (import sorting) |
+| License | ⚠️ | pyproject.toml says MIT but no LICENSE file found |
+
+## Ruff Issues Found
+1. `src/agentmail/core/query_encoder.py` - unsorted imports
+2. `tests/utils/test_query_encoding.py` - unsorted imports
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CONTRIBUTING.md with development setup and process documentation.
Testing
N/A — documentation only.
Summary by cubic
Add CONTRIBUTING.md with setup, testing, linting, and PR guidelines. Also add an MIT LICENSE and fix minor
ruffimport-order issues to keep CI clean.Documentation
Poetrysetup,pytest,ruff,mypy, and PR steps.Bug Fixes
ruffI001 import order insrc/agentmail/core/query_encoder.pyandtests/utils/test_query_encoding.py.Written for commit f064ec8. Summary will update on new commits. Review in cubic