Merge pull request #4 from aditink/revert-3-wanxin-issue1817

Revert "Wanxin issue1817, fixed insert method."

Author: Wanxin-Hu

example/tools/embed

@@ -1,5 +1,4 @@
 import { BlockAPI as BlockAPIInterface, Blocks } from '../../../../types/api';
-import {InsertedBlock} from '../../../../types/api';
 import { BlockToolData, OutputData, ToolConfig } from '../../../../types';
 import * as _ from './../../utils';
 import BlockAPI from '../../block/api';
@@ -31,7 +30,7 @@ export default class BlocksAPI extends Module {
       getBlocksCount: (): number => this.getBlocksCount(),
       stretchBlock: (index: number, status = true): void => this.stretchBlock(index, status),
       insertNewBlock: (): void => this.insertNewBlock(),
-      insert:() :BlockAPIInterface => this.insert({}),
+      insert: this.insert,
       update: this.update,
       composeBlockData: this.composeBlockData,
     };
@@ -223,10 +222,30 @@ export default class BlocksAPI extends Module {
 
   /**
    * Insert new Block and returns it's API
-   * @param {InsertedBlock} block - The block being inserted
+   *
+   * @param {string} type — Tool name
+   * @param {BlockToolData} data — Tool data to insert
+   * @param {ToolConfig} config — Tool config
+   * @param {number?} index — index where to insert new Block
+   * @param {boolean?} needToFocus - flag to focus inserted Block
+   * @param replace - pass true to replace the Block existed under passed index
    */
-   public insert (block: InsertedBlock): BlockAPIInterface {
-    const insertedBlock = this.Editor.BlockManager.insert(block);
+  public insert = (
+    type: string = this.config.defaultBlock,
+    data: BlockToolData = {},
+    config: ToolConfig = {},
+    index?: number,
+    needToFocus?: boolean,
+    replace?: boolean
+  ): BlockAPIInterface => {
+    const insertedBlock = this.Editor.BlockManager.insert({
+      tool: type,
+      data,
+      index,
+      needToFocus,
+      replace,
+    });
+
     return new BlockAPI(insertedBlock);
   }
 
@@ -244,6 +263,7 @@ export default class BlocksAPI extends Module {
       data: {},
       tunesData: {},
     });
+
     return block.data;
   }
 
@@ -258,7 +278,7 @@ export default class BlocksAPI extends Module {
   public insertNewBlock(): void {
     _.log('Method blocks.insertNewBlock() is deprecated and it will be removed in the next major release. ' +
       'Use blocks.insert() instead.', 'warn');
-    this.insert({});
+    this.insert();
   }
 
   /**

src/components/modules/api/blocks.ts

@@ -74,39 +74,3 @@ export interface BlockAPI {
    */
   dispatchChange(): void;
 }
-
-/**
- * @interface InsertedBLock Describes methods and properties of inserted blocks
- */
-
-export interface InsertedBlock{
-  /**
-   * Tool name
-   */
-  type?: string,
-
-  /**
-   * Tool data to insert
-   */
-  data?: BlockToolData,
-
-  /**
-   * Tool config
-   */
-  config?: ToolConfig,
-
-  /**
-   * index where to insert new block
-   */
-  index?: number,
-
-  /**
-   * falg to focus inserted block
-   */
-  needToFocus?: boolean,
-
-  /**
-   * pass true to replace the Block existed under passed index
-   */
-  replace?: boolean
-}