Skip to content

Commit f7cbe14

Browse files
committed
Simplify see also styling
1 parent 135345e commit f7cbe14

5 files changed

Lines changed: 6 additions & 13 deletions

File tree

Lines changed: 0 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/site.css

Lines changed: 0 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/app.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -351,11 +351,11 @@ def render_example_page(example, output=None, code=None, execution_time_ms=None)
351351
notes_html = "".join(f"<li>{note}</li>" for note in notes)
352352
see_also_examples = [get_example(slug) for slug in example.get("see_also", [])]
353353
see_also_links = "".join(
354-
f'<li><span class="see-also-label">{html.escape(_see_also_label(example["slug"], item["slug"]))}</span> <a class="text-link" href="/examples/{html.escape(item["slug"])}">{html.escape(item["title"])}</a></li>'
354+
f'<li>{html.escape(_see_also_label(example["slug"], item["slug"]))}: <a class="text-link" href="/examples/{html.escape(item["slug"])}">{html.escape(item["title"])}</a></li>'
355355
for item in see_also_examples
356356
if item is not None
357357
)
358-
see_also_html = f'<section class="see-also"><h2>See also</h2><ul>{see_also_links}</ul></section>' if see_also_links else ""
358+
see_also_html = f'<h2>See also</h2><ul>{see_also_links}</ul>' if see_also_links else ""
359359
content = _replace(
360360
_template("example.html"),
361361
{
@@ -414,7 +414,7 @@ def route(url: str, method: str = "GET") -> AppResponse:
414414
f'<li><a class="text-link" href="/examples/{html.escape(item["slug"])}">{html.escape(item["title"])}</a></li>'
415415
for item in _recommended_examples(slug)
416416
)
417-
body = f'<h1>Example not found</h1><p class="meta">Try one of these nearby examples.</p><section class="see-also"><h2>Recommended examples</h2><ul>{recommendations}</ul></section>'
417+
body = f'<h1>Example not found</h1><p class="meta">Try one of these nearby examples.</p><h2>Recommended examples</h2><ul>{recommendations}</ul>'
418418
return AppResponse(_layout("Not Found", body), status=404)
419419
return AppResponse(
420420
render_example_page(example), headers={"Content-Type": "text/html; charset=utf-8"}

src/asset_manifest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# Generated by scripts/fingerprint_assets.py. Do not edit by hand.
2-
ASSET_PATHS = {'SITE_CSS': '/site.dfa9bd8042a1.css', 'SYNTAX_JS': '/syntax-highlight.3b6c7f730d46.js', 'EDITOR_JS': '/editor.dd81f5171b14.js'}
3-
HTML_CACHE_VERSION = '37b3e0c8e92b'
2+
ASSET_PATHS = {'SITE_CSS': '/site.06e133dcde6a.css', 'SYNTAX_JS': '/syntax-highlight.3b6c7f730d46.js', 'EDITOR_JS': '/editor.dd81f5171b14.js'}
3+
HTML_CACHE_VERSION = '6dd0b780fadd'

tests/test_app.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ def test_see_also_links_form_valid_example_graph(self):
197197
self.assertIn("See also", html)
198198
self.assertIn("contrast", html)
199199
self.assertIn('/examples/loop-else', html)
200+
self.assertNotIn('class="see-also"', html)
200201
missing = route("https://example.com/examples/break-continue")
201202
self.assertEqual(missing.status, 404)
202203
self.assertIn("Recommended examples", missing.body)

0 commit comments

Comments
 (0)