chore: bump @adcp/client to 4.23.0 (#2006)

bokelley · claude · web-flow · commit d6ceca35b201 · 2026-04-08T16:07:41.000-04:00
* chore: bump @adcp/client to 4.23.0

Picks up storyboard-driven comply() routing from adcp-client#445.
25/25 testable storyboards pass locally against training agent.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;

* refactor: remove deprecated PLATFORM_STORYBOARDS and storyboard routing from addie

@adcp/client 4.23.0 now handles storyboard-driven comply() routing.
Addie no longer needs its own PLATFORM_STORYBOARDS mapping or
storyboard-to-scenario resolution.

Removed:
- PLATFORM_STORYBOARDS constant and getPlatformStoryboards()
- resolveStoryboardScenarios() — client handles this internally
- storyboards option from ComplyOptions — callers pass platform_type
- Storyboard routing block in evaluate_agent_quality
- Storyboard routing block in compliance heartbeat
- PLATFORM_STORYBOARDS tests

Kept:
- filterToKnownScenarios() — still used by storyboard run/compare endpoints
- comply() wrapper — still needed for track-based reporting and observations
- All types, TRACK_SCENARIOS, PLATFORM_PROFILES — backward compat

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;

* fix: restore platform_type in heartbeat for coherence reporting

The heartbeat still needs to look up platform_type from registry metadata
and pass it to comply() so platform coherence analysis is included in
heartbeat results.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;

---------

Co-authored-by: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/.changeset/violet-signs-repair.md b/.changeset/violet-signs-repair.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -48,7 +48,7 @@
     "check:images": "bash scripts/check-image-quality.sh"
   },
   "dependencies": {
-    "@adcp/client": "^4.22.1",
+    "@adcp/client": "^4.23.0",
     "@anthropic-ai/sdk": "^0.82.0",
     "@asteasolutions/zod-to-openapi": "^8.5.0",
     "@google/generative-ai": "^0.24.1",
diff --git a/server/src/addie/jobs/compliance-heartbeat.ts b/server/src/addie/jobs/compliance-heartbeat.ts
@@ -5,7 +5,7 @@
  * Updates compliance status and triggers notifications on status transitions.
  */
 
-import { comply, getPlatformStoryboards, type ComplyOptions, type PlatformType } from '../services/compliance-testing.js';
+import { comply, type ComplyOptions, type PlatformType } from '../services/compliance-testing.js';
 import { ComplianceDatabase, type TrackSummaryEntry, type OverallRunStatus, type LifecycleStage } from '../../db/compliance-db.js';
 import { query } from '../../db/client.js';
 import { notifyComplianceChange } from '../../notifications/compliance.js';
@@ -56,19 +56,17 @@ export async function runComplianceHeartbeatJob(options: HeartbeatOptions = {}):
       // These are credentials the owner saved when connecting through Addie.
       const auth = await complianceDb.resolveOwnerAuth(agent.agent_url);
 
-      // Use storyboard-based routing when the agent has a registered platform type
+      // Pass platform_type for coherence reporting
       const metadata = await complianceDb.getRegistryMetadata(agent.agent_url);
-      const storyboards = metadata?.platform_type
-        ? getPlatformStoryboards(metadata.platform_type as PlatformType)
-        : undefined;
+      const platformType = metadata?.platform_type as PlatformType | undefined;
 
       const complyOptions: ComplyOptions = {
         test_session_id: `heartbeat-${Date.now()}`,
         dry_run: true,
         timeout_ms: 60_000,
         auth,
-        ...(storyboards && { storyboards }),
         userAgent: AAO_UA_COMPLIANCE,
+        ...(platformType && { platform_type: platformType }),
       };
 
       const complianceResult = await comply(agent.agent_url, complyOptions);
diff --git a/server/src/addie/mcp/member-tools.ts b/server/src/addie/mcp/member-tools.ts
@@ -25,7 +25,6 @@ import {
   SAMPLE_BRIEFS,
   getAllPlatformTypes,
   getPlatformProfile,
-  getPlatformStoryboards,
   type ComplyOptions,
   type ComplianceTrack,
   type PlatformType,
@@ -2991,14 +2990,6 @@ export function createMemberToolHandlers(
     }
     complyOptions.platform_type = effectivePlatformType;
 
-    // When no explicit tracks are provided, use storyboard-based routing
-    if (!tracks) {
-      const recommendedStoryboards = getPlatformStoryboards(effectivePlatformType);
-      if (recommendedStoryboards) {
-        complyOptions.storyboards = recommendedStoryboards;
-      }
-    }
-
     try {
       const result = await comply(resolved.resolvedUrl, complyOptions);
 
diff --git a/server/src/addie/services/compliance-testing.ts b/server/src/addie/services/compliance-testing.ts
@@ -41,11 +41,9 @@ export type PlatformType =
 
 export interface ComplyOptions extends TestOptions {
   tracks?: ComplianceTrack[];
-  /** Run the scenarios defined by these storyboard IDs. Takes priority over tracks. */
-  storyboards?: string[];
   platform_type?: PlatformType;
   timeout_ms?: number;
-  /** Limit to specific scenarios directly. Bypasses both storyboard and track selection. */
+  /** Limit to specific scenarios (e.g. from a storyboard). Bypasses track-based selection. */
   scenarios?: TestScenario[];
 }
 
@@ -269,36 +267,6 @@ const PLATFORM_PROFILES: Record<PlatformType, PlatformProfile> = {
   },
 };
 
-/**
- * Maps each platform type to the storyboards that define its expected behavior.
- *
- * @deprecated This mapping will move to @adcp/client once adcp-client#445
- * ships storyboard-based comply(). At that point, callers should pass
- * platform_type to comply() and let the client resolve storyboards internally.
- * The canonical mapping will live next to comply() in the client package.
- */
-export const PLATFORM_STORYBOARDS: Record<PlatformType, string[]> = {
-  display_ad_server: ['capability_discovery', 'schema_validation', 'behavioral_analysis', 'media_buy_seller', 'media_buy_state_machine', 'error_compliance'],
-  video_ad_server: ['capability_discovery', 'schema_validation', 'behavioral_analysis', 'media_buy_seller', 'media_buy_state_machine', 'error_compliance'],
-  social_platform: ['capability_discovery', 'schema_validation', 'behavioral_analysis', 'social_platform', 'media_buy_state_machine', 'error_compliance'],
-  pmax_platform: ['capability_discovery', 'schema_validation', 'behavioral_analysis', 'media_buy_seller', 'media_buy_state_machine', 'creative_lifecycle', 'error_compliance'],
-  dsp: ['capability_discovery', 'schema_validation', 'behavioral_analysis', 'media_buy_seller', 'media_buy_state_machine', 'error_compliance'],
-  retail_media: ['capability_discovery', 'schema_validation', 'behavioral_analysis', 'media_buy_seller', 'media_buy_catalog_creative', 'media_buy_state_machine', 'error_compliance'],
-  search_platform: ['capability_discovery', 'schema_validation', 'behavioral_analysis', 'media_buy_seller', 'media_buy_state_machine', 'error_compliance'],
-  audio_platform: ['capability_discovery', 'schema_validation', 'behavioral_analysis', 'media_buy_seller', 'media_buy_state_machine', 'error_compliance'],
-  creative_transformer: ['capability_discovery', 'creative_template'],
-  creative_library: ['capability_discovery', 'creative_lifecycle'],
-  creative_ad_server: ['capability_discovery', 'creative_ad_server'],
-  si_platform: ['capability_discovery', 'si_session'],
-  ai_ad_network: ['capability_discovery', 'schema_validation', 'behavioral_analysis', 'media_buy_seller', 'media_buy_state_machine', 'creative_lifecycle', 'error_compliance'],
-  ai_platform: ['capability_discovery', 'schema_validation', 'behavioral_analysis', 'creative_template', 'error_compliance'],
-  generative_dsp: ['capability_discovery', 'schema_validation', 'behavioral_analysis', 'media_buy_seller', 'media_buy_state_machine', 'creative_lifecycle', 'error_compliance'],
-};
-
-export function getPlatformStoryboards(platformType: PlatformType): string[] | undefined {
-  return PLATFORM_STORYBOARDS[platformType];
-}
-
 export function getBriefsByVertical(vertical: string): SampleBrief[] {
   const normalized = vertical.trim().toLowerCase();
   return SAMPLE_BRIEFS.filter((brief) => brief.vertical === normalized);
@@ -478,36 +446,9 @@ function tracksForScenarios(scenarios: TestScenario[]): ComplianceTrack[] {
   return tracks;
 }
 
-/**
- * Resolve storyboard IDs to a merged, deduped list of known scenarios.
- * Uses dynamic import to avoid circular dependency with storyboards.ts.
- */
-async function resolveStoryboardScenarios(storyboardIds: string[]): Promise<TestScenario[]> {
-  const { getStoryboard, extractScenariosFromStoryboard } = await import('../../services/storyboards.js');
-  const allScenarios = new Set<string>();
-  for (const id of storyboardIds) {
-    const sb = getStoryboard(id);
-    if (sb) {
-      for (const s of extractScenariosFromStoryboard(sb)) {
-        allScenarios.add(s);
-      }
-    }
-  }
-  return filterToKnownScenarios([...allScenarios]);
-}
-
 export async function comply(agentUrl: string, options: ComplyOptions = {}): Promise<ComplyResult> {
-  // Priority: scenarios > storyboards > tracks > default (all tracks)
-  let scenarioList: TestScenario[];
-  if (options.scenarios?.length) {
-    scenarioList = options.scenarios;
-  } else if (options.storyboards?.length) {
-    scenarioList = await resolveStoryboardScenarios(options.storyboards);
-  } else {
-    scenarioList = buildScenarioList(options.tracks);
-  }
-
-  const requestedTracks = (options.scenarios?.length || options.storyboards?.length)
+  const scenarioList = options.scenarios ?? buildScenarioList(options.tracks);
+  const requestedTracks = options.scenarios?.length
     ? tracksForScenarios(scenarioList)
     : options.tracks?.length
       ? options.tracks
diff --git a/server/tests/unit/compliance-track-scenarios.test.ts b/server/tests/unit/compliance-track-scenarios.test.ts
@@ -1,6 +1,5 @@
 import { describe, it, expect } from 'vitest';
-import { TRACK_SCENARIOS, buildScenarioList, PLATFORM_STORYBOARDS } from '../../src/addie/services/compliance-testing.js';
-import { getStoryboard } from '../../src/services/storyboards.js';
+import { TRACK_SCENARIOS, buildScenarioList } from '../../src/addie/services/compliance-testing.js';
 
 describe('TRACK_SCENARIOS', () => {
   it('maps reporting track to deterministic_delivery', () => {
@@ -32,37 +31,3 @@ describe('buildScenarioList', () => {
     }
   });
 });
-
-describe('PLATFORM_STORYBOARDS', () => {
-  it('every platform type maps to at least one storyboard', () => {
-    for (const [, storyboards] of Object.entries(PLATFORM_STORYBOARDS)) {
-      expect(storyboards.length).toBeGreaterThan(0);
-    }
-  });
-
-  it('every mapped storyboard ID is a valid storyboard', () => {
-    const allIds = new Set<string>();
-    for (const storyboards of Object.values(PLATFORM_STORYBOARDS)) {
-      for (const id of storyboards) {
-        allIds.add(id);
-      }
-    }
-    for (const id of allIds) {
-      expect(getStoryboard(id)).toBeDefined();
-    }
-  });
-
-  it('si_platform maps to si_session', () => {
-    expect(PLATFORM_STORYBOARDS.si_platform).toContain('si_session');
-  });
-
-  it('social_platform maps to social_platform storyboard', () => {
-    expect(PLATFORM_STORYBOARDS.social_platform).toContain('social_platform');
-  });
-
-  it('every platform type includes capability_discovery', () => {
-    for (const [, storyboards] of Object.entries(PLATFORM_STORYBOARDS)) {
-      expect(storyboards).toContain('capability_discovery');
-    }
-  });
-});
