fix(ci): restore storyboard fixture coverage

Author: bokelley

.github/workflows/ci.yml

@@ -658,6 +658,7 @@ jobs:
           adcp storyboard run \
             http://acme.localhost:3001/mcp media_buy_seller \
             --auth dev-bearer-token-acme-1 \
+            --test-kit ../../tests/fixtures/storyboard-test-kit.yaml \
             --json --allow-http \
             > v3-storyboard-result.json
 

examples/v3_reference_seller/src/platform.py

@@ -2019,7 +2019,7 @@ async def list_creative_formats_legacy(
         format-list endpoint (formats are publisher-defined, baked
         into the upstream's product catalog). Real adopters drive this
         from a creative-format registry."""
-        del req, ctx
+        del ctx
         agent_url = "https://reference.adcp.org"
         formats = [
             LegacyFormat.model_validate(
@@ -2036,6 +2036,13 @@ async def list_creative_formats_legacy(
                     "description": "IAB standard 728x90 display banner.",
                 }
             ),
+            LegacyFormat.model_validate(
+                {
+                    "format_id": {"agent_url": agent_url, "id": "video_30s"},
+                    "name": "Video 30s",
+                    "description": "Standard 30-second video creative.",
+                }
+            ),
             LegacyFormat.model_validate(
                 {
                     "format_id": {"agent_url": agent_url, "id": "video_16x9_30s"},
@@ -2044,7 +2051,20 @@ async def list_creative_formats_legacy(
                 }
             ),
         ]
-        self._record("creatives.formats", {})
+        if req.format_ids:
+            requested = {
+                (str(format_id.agent_url).rstrip("/"), format_id.id) for format_id in req.format_ids
+            }
+            formats = [
+                format_
+                for format_ in formats
+                if (
+                    str(format_.format_id.agent_url).rstrip("/"),
+                    format_.format_id.id,
+                )
+                in requested
+            ]
+        self._record("creatives.formats", {"format_ids": len(req.format_ids or [])})
         return ListCreativeFormatsResponse(formats=formats)
 
     # ----- list_creatives --------------------------------------------------

examples/v3_reference_seller/tests/test_smoke_broadening.py

@@ -1719,6 +1719,30 @@ async def test_list_creative_formats_is_static_no_upstream_call() -> None:
         assert respx_mock.calls.call_count == 0
 
 
+@pytest.mark.asyncio
+async def test_list_creative_formats_filters_requested_ids() -> None:
+    """The static catalog honors the exact IDs returned by get_products."""
+    from adcp.types import LegacyListCreativeFormatsRequest
+
+    platform = _platform_with_upstream()
+    ctx = _build_ctx()
+    resp = await platform.list_creative_formats_legacy(
+        LegacyListCreativeFormatsRequest.model_validate(
+            {
+                "format_ids": [
+                    {
+                        "agent_url": "https://reference.adcp.org/",
+                        "id": "video_30s",
+                    }
+                ]
+            }
+        ),
+        ctx,
+    )
+
+    assert [format_.format_id.id for format_ in resp.formats] == ["video_30s"]
+
+
 @pytest.mark.asyncio
 @respx.mock(base_url=_RESPX_BASE_URL)
 async def test_update_media_buy_rejects_foreign_advertiser_order(respx_mock: Any) -> None:

scripts/ci/run_storyboard_reference_seller.sh

@@ -12,6 +12,7 @@
 #   PYTHON=python3
 #   ADCP_PYTHON_VENV=.context/storyboard-reference-seller-venv
 #   ADCP_SDK_ROOT=/path/to/@adcp/sdk
+#   ADCP_TEST_KIT=tests/fixtures/storyboard-test-kit.yaml
 #
 # The script assumes it is running from an adcp-client-python checkout,
 # installs the Python dependencies needed by examples/seller_agent.py,
@@ -32,6 +33,7 @@ ADCP_RUNNER_BIN="${ADCP_RUNNER_BIN:-}"
 ADCP_SDK_VERSION="${ADCP_SDK_VERSION:-}"
 ADCP_SDK_TARBALL="${ADCP_SDK_TARBALL:-}"
 ADCP_SDK_ROOT="${ADCP_SDK_ROOT:-}"
+ADCP_TEST_KIT="${ADCP_TEST_KIT:-$ROOT/tests/fixtures/storyboard-test-kit.yaml}"
 
 fail() {
   echo "ERROR: $*" >&2
@@ -194,6 +196,16 @@ trap cleanup EXIT
 install_or_select_runner
 install_python_dependencies
 
+STORYBOARD_ARGS=(
+  storyboard run
+  "http://127.0.0.1:${ADCP_PORT}/mcp" media_buy_seller
+  --json --allow-http
+)
+if "$ADCP_RUNNER_BIN" storyboard run --help | grep -q -- '--test-kit'; then
+  [[ -f "$ADCP_TEST_KIT" ]] || fail "ADCP_TEST_KIT not found: $ADCP_TEST_KIT"
+  STORYBOARD_ARGS+=(--test-kit "$ADCP_TEST_KIT")
+fi
+
 mkdir -p "$(dirname "$STORYBOARD_RESULT_PATH")"
 echo "Starting examples/seller_agent.py on port $ADCP_PORT"
 ADCP_PORT="$ADCP_PORT" "$PYTHON" examples/seller_agent.py >"$SELLER_LOG_PATH" 2>&1 &
@@ -202,10 +214,7 @@ wait_for_seller "$SELLER_PID"
 
 echo "Running media_buy_seller storyboard"
 set +e
-"$ADCP_RUNNER_BIN" storyboard run \
-  "http://127.0.0.1:${ADCP_PORT}/mcp" media_buy_seller \
-  --json --allow-http \
-  >"$STORYBOARD_RESULT_PATH"
+"$ADCP_RUNNER_BIN" "${STORYBOARD_ARGS[@]}" >"$STORYBOARD_RESULT_PATH"
 RUNNER_STATUS=$?
 set -e
 

tests/fixtures/storyboard-test-kit.yaml

@@ -0,0 +1,21 @@
+# Deterministic creative inputs for @adcp/sdk storyboard runs. The runner
+# selects the first fixture satisfying the seller-declared slot constraints;
+# these URLs are opaque test values and are never fetched by the examples.
+assets:
+  images:
+    - url: https://fixtures.example.com/display-300x250.png
+      width: 300
+      height: 250
+      mime_type: image/png
+    - url: https://fixtures.example.com/display-970x250.png
+      width: 970
+      height: 250
+      mime_type: image/png
+  text:
+    headlines:
+      - Test campaign headline
+    descriptions:
+      - Deterministic storyboard creative description.
+    cta:
+      - Learn more
+  click_url: https://fixtures.example.com/landing-page