Skip to content

Commit a7b19be

Browse files
committed
Fix CI test failures
- Use absolute path for BUNDLE_GEMFILE to prevent path resolution issues when working directory changes to test/dummy - Pin minitest to ~> 5.0 (v6 moved Mock to separate gem) - Add Rails and sqlite3 to API gemfiles for test compatibility - Remove conflicting rails version from gemspec (gemfiles handle it)
1 parent b641710 commit a7b19be

9 files changed

Lines changed: 20 additions & 9 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
env:
2727
BUNDLE_JOBS: 4
2828
BUNDLE_RETRY: 3
29-
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
29+
BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.gemfile }}
3030
CI: true
3131
ANTHROPIC_API_KEY: ANTHROPIC_API_KEY
3232
OPEN_AI_API_KEY: OPEN_AI_API_KEY
@@ -59,12 +59,10 @@ jobs:
5959
env:
6060
RAILS_ENV: test
6161
RAILS_MASTER_KEY: ${{ secrets.RAILS_MASTER_KEY }}
62-
BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.gemfile }}
62+
working-directory: test/dummy
6363
run: |
64-
cd test/dummy
6564
bundle exec rails db:create
6665
bundle exec rails db:migrate
67-
cd ../..
6866
- name: Run tests
6967
env:
7068
RAILS_ENV: test
@@ -77,7 +75,7 @@ jobs:
7775
env:
7876
BUNDLE_JOBS: 4
7977
BUNDLE_RETRY: 3
80-
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
78+
BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.gemfile }}
8179
CI: true
8280
ANTHROPIC_API_KEY: ANTHROPIC_API_KEY
8381
OPEN_AI_API_KEY: OPEN_AI_API_KEY
@@ -105,12 +103,10 @@ jobs:
105103
env:
106104
RAILS_ENV: test
107105
RAILS_MASTER_KEY: ${{ secrets.RAILS_MASTER_KEY }}
108-
BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.gemfile }}
106+
working-directory: test/dummy
109107
run: |
110-
cd test/dummy
111108
bundle exec rails db:create
112109
bundle exec rails db:migrate
113-
cd ../..
114110
- name: Run tests
115111
env:
116112
RAILS_ENV: test

activeagent.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ Gem::Specification.new do |spec|
2626
spec.add_dependency "activejob", ">= 7.2", "<= 9.0"
2727

2828
spec.add_development_dependency "jbuilder", "~> 2.14"
29-
spec.add_development_dependency "rails", "~> 8.1.1"
3029

3130
spec.add_development_dependency "anthropic", "~> 1.12"
3231
spec.add_development_dependency "openai", "~> 0.34"
@@ -38,6 +37,7 @@ Gem::Specification.new do |spec|
3837
spec.add_development_dependency "ostruct"
3938
spec.add_development_dependency "puma"
4039
spec.add_development_dependency "sqlite3"
40+
spec.add_development_dependency "minitest", "~> 5.0"
4141
spec.add_development_dependency "vcr"
4242
spec.add_development_dependency "webmock"
4343

gemfiles/anthropic_1.12.gemfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
source "https://rubygems.org"
22

33
gem "anthropic", "~> 1.12.0"
4+
gem "minitest", "~> 5.0"
5+
gem "rails", "~> 8.0.0"
6+
gem "sqlite3", "~> 2.0"
47

58
gemspec path: ".."

gemfiles/anthropic_1.14.gemfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
source "https://rubygems.org"
22

33
gem "anthropic", "~> 1.14.0"
4+
gem "minitest", "~> 5.0"
5+
gem "rails", "~> 8.0.0"
6+
gem "sqlite3", "~> 2.0"
47

58
gemspec path: ".."

gemfiles/openai_0.34.gemfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
source "https://rubygems.org"
44

5+
gem "minitest", "~> 5.0"
56
gem "openai", "~> 0.34.0"
7+
gem "rails", "~> 8.0.0"
8+
gem "sqlite3", "~> 2.0"
69

710
gemspec path: ".."

gemfiles/openai_0.35.gemfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
source "https://rubygems.org"
44

5+
gem "minitest", "~> 5.0"
56
gem "openai", "~> 0.35.0"
7+
gem "rails", "~> 8.0.0"
8+
gem "sqlite3", "~> 2.0"
69

710
gemspec path: ".."

gemfiles/rails7.gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
source "https://rubygems.org"
22

3+
gem "minitest", "~> 5.0"
34
gem "sqlite3", "~> 1.4"
45
gem "rails", "~> 7.0"
56

gemfiles/rails8.gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
source "https://rubygems.org"
22

3+
gem "minitest", "~> 5.0"
34
gem "sqlite3", "~> 2.0"
45
gem "rails", "~> 8.0.0"
56

gemfiles/railsmain.gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
source "https://rubygems.org"
22

3+
gem "minitest", "~> 5.0"
34
gem "sqlite3", "~> 2.0"
45
gem "rails", github: "rails/rails"
56

0 commit comments

Comments
 (0)