wip handling binary data

might be best to try DRYing up these primitiveBlah arrays

Author: lawrence-forooghian

TODO.md

@@ -2,3 +2,4 @@
 - [ ] the primitiveKeyData need DRYing up — and I need to understand what types they should be
 - [ ] some of the code that checks unsubscribe might be a bit racy — e.g. it might just be that you didn't see an update yet because you dispatched its handling into a `Task`
 - [ ] there are a bunch of `if case` statements in the tests which make me worry that some tests might end up being no-ops
+- [ ] processDeserializedProtocolMessage should really be using the internal queue

Tests/AblyLiveObjectsTests/JS Integration Tests/ObjectsIntegrationTests.swift

@@ -239,6 +239,12 @@ private struct ObjectsIntegrationTests {
             var channel: ARTRealtimeChannel
             var client: ARTRealtime
             var clientOptions: ClientHelper.PartialClientOptions
+
+            /// Whether the client in this test is using the binary protocol.
+            var useBinaryProtocol: Bool {
+                // This saves us from having to use private API to interrogate whether the binary protocol is being used (which is what the JS tests do), at the cost of having to duplicate the fact that binary is the default.
+                clientOptions.useBinaryProtocol ?? true
+            }
         }
 
         static let scenarios: [TestScenario<Context>] = {

testing-plan-annotated.md

@@ -146,7 +146,7 @@ func base64Decode(_ string: String) -> Data
 - Requires precise timing and state management
 - Tests complex interaction between sync and operations
 
-#### Step 3f: Error Handling Scenarios (Medium Risk)
+#### Step 3f: Error Handling Scenarios (Medium Risk) — In progress. Has test failures and am currently trying to work out how to handle binary data; might require us to switch to using WireValue in the tests
 **clientConfigurationScenarios** - Test various error conditions
 - 6 scenarios testing channel state and mode validation
 - Requires channel state manipulation