From ea00d16d6b2e7e47db0565606eb6563df0ae21fe Mon Sep 17 00:00:00 2001 From: Kabir Khan Date: Wed, 20 May 2026 20:07:06 +0100 Subject: [PATCH 1/2] refactor: extract AgentExecutorProducer_v0_3 into separate test module Move AgentExecutorProducer_v0_3 from compat-0.3/server-conversion test-jar into a new compat-0.3/tests/server-common module to fix CDI ambiguous dependency errors in downstream consumers that depend on both the v0.3 and v1.0 test-jars. Co-Authored-By: Claude Opus 4.6 --- compat-0.3/pom.xml | 9 +++ compat-0.3/reference/grpc/pom.xml | 6 ++ compat-0.3/reference/jsonrpc/pom.xml | 6 ++ compat-0.3/reference/rest/pom.xml | 6 ++ compat-0.3/tests/server-common/pom.xml | 63 +++++++++++++++++++ .../AgentExecutorProducer_v0_3.java | 0 .../conversion/RequestScopedBean_v0_3.java | 0 .../src/test/resources/META-INF/beans.xml | 7 +++ 8 files changed, 97 insertions(+) create mode 100644 compat-0.3/tests/server-common/pom.xml rename compat-0.3/{server-conversion => tests/server-common}/src/test/java/org/a2aproject/sdk/compat03/conversion/AgentExecutorProducer_v0_3.java (100%) rename compat-0.3/{server-conversion => tests/server-common}/src/test/java/org/a2aproject/sdk/compat03/conversion/RequestScopedBean_v0_3.java (100%) create mode 100644 compat-0.3/tests/server-common/src/test/resources/META-INF/beans.xml diff --git a/compat-0.3/pom.xml b/compat-0.3/pom.xml index a8d75df65..3af9938a0 100644 --- a/compat-0.3/pom.xml +++ b/compat-0.3/pom.xml @@ -105,6 +105,12 @@ test-jar ${project.version} + + ${project.groupId} + a2a-java-sdk-compat-0.3-tests-server-common + test-jar + ${project.version} + @@ -116,6 +122,9 @@ server-conversion + + tests/server-common + client/base client/transport/spi diff --git a/compat-0.3/reference/grpc/pom.xml b/compat-0.3/reference/grpc/pom.xml index ad834439e..57ff76c08 100644 --- a/compat-0.3/reference/grpc/pom.xml +++ b/compat-0.3/reference/grpc/pom.xml @@ -52,6 +52,12 @@ test-jar test + + ${project.groupId} + a2a-java-sdk-compat-0.3-tests-server-common + test-jar + test + ${project.groupId} diff --git a/compat-0.3/reference/jsonrpc/pom.xml b/compat-0.3/reference/jsonrpc/pom.xml index 2a3bd7f6a..f26228486 100644 --- a/compat-0.3/reference/jsonrpc/pom.xml +++ b/compat-0.3/reference/jsonrpc/pom.xml @@ -37,6 +37,12 @@ test-jar test + + ${project.groupId} + a2a-java-sdk-compat-0.3-tests-server-common + test-jar + test + ${project.groupId} diff --git a/compat-0.3/reference/rest/pom.xml b/compat-0.3/reference/rest/pom.xml index bcc9e882d..b1615b378 100644 --- a/compat-0.3/reference/rest/pom.xml +++ b/compat-0.3/reference/rest/pom.xml @@ -33,6 +33,12 @@ test-jar test + + ${project.groupId} + a2a-java-sdk-compat-0.3-tests-server-common + test-jar + test + ${project.groupId} diff --git a/compat-0.3/tests/server-common/pom.xml b/compat-0.3/tests/server-common/pom.xml new file mode 100644 index 000000000..d5e8633f7 --- /dev/null +++ b/compat-0.3/tests/server-common/pom.xml @@ -0,0 +1,63 @@ + + + 4.0.0 + + + org.a2aproject.sdk + a2a-java-sdk-compat-0.3-parent + 1.0.0.CR2-SNAPSHOT + ../../pom.xml + + a2a-java-sdk-compat-0.3-tests-server-common + + jar + + Java A2A Compat 0.3 Server Tests Common + Java SDK for the Agent2Agent Protocol (A2A) - Compat 0.3 Server Tests Common + + + + ${project.groupId} + a2a-java-sdk-spec + + + ${project.groupId} + a2a-java-sdk-server-common + + + jakarta.enterprise + jakarta.enterprise.cdi-api + test + + + io.quarkus + quarkus-arc + test + + + + + + + org.apache.maven.plugins + maven-surefire-plugin + + true + + + + org.apache.maven.plugins + maven-jar-plugin + + + + test-jar + + + + + + + diff --git a/compat-0.3/server-conversion/src/test/java/org/a2aproject/sdk/compat03/conversion/AgentExecutorProducer_v0_3.java b/compat-0.3/tests/server-common/src/test/java/org/a2aproject/sdk/compat03/conversion/AgentExecutorProducer_v0_3.java similarity index 100% rename from compat-0.3/server-conversion/src/test/java/org/a2aproject/sdk/compat03/conversion/AgentExecutorProducer_v0_3.java rename to compat-0.3/tests/server-common/src/test/java/org/a2aproject/sdk/compat03/conversion/AgentExecutorProducer_v0_3.java diff --git a/compat-0.3/server-conversion/src/test/java/org/a2aproject/sdk/compat03/conversion/RequestScopedBean_v0_3.java b/compat-0.3/tests/server-common/src/test/java/org/a2aproject/sdk/compat03/conversion/RequestScopedBean_v0_3.java similarity index 100% rename from compat-0.3/server-conversion/src/test/java/org/a2aproject/sdk/compat03/conversion/RequestScopedBean_v0_3.java rename to compat-0.3/tests/server-common/src/test/java/org/a2aproject/sdk/compat03/conversion/RequestScopedBean_v0_3.java diff --git a/compat-0.3/tests/server-common/src/test/resources/META-INF/beans.xml b/compat-0.3/tests/server-common/src/test/resources/META-INF/beans.xml new file mode 100644 index 000000000..b708636eb --- /dev/null +++ b/compat-0.3/tests/server-common/src/test/resources/META-INF/beans.xml @@ -0,0 +1,7 @@ + + + From f41942504faf1d940b464d2f70f6f0566c9d08c1 Mon Sep 17 00:00:00 2001 From: Emmanuel Hugonnet Date: Wed, 27 May 2026 19:57:44 +0200 Subject: [PATCH 2/2] Avoiding creating an empty jar file Signed-off-by: Emmanuel Hugonnet --- .../sdk/test/ReferenceBomVerifier.java | 3 ++- .../a2aproject/sdk/test/SdkBomVerifier.java | 13 ++++++----- compat-0.3/pom.xml | 1 - compat-0.3/reference/grpc/pom.xml | 3 +-- compat-0.3/reference/jsonrpc/pom.xml | 1 - compat-0.3/reference/rest/pom.xml | 1 - compat-0.3/tests/server-common/pom.xml | 22 +++++-------------- .../AgentExecutorProducer_v0_3.java | 0 .../conversion/RequestScopedBean_v0_3.java | 0 .../resources/META-INF/beans.xml | 0 10 files changed, 16 insertions(+), 28 deletions(-) rename compat-0.3/tests/server-common/src/{test => main}/java/org/a2aproject/sdk/compat03/conversion/AgentExecutorProducer_v0_3.java (100%) rename compat-0.3/tests/server-common/src/{test => main}/java/org/a2aproject/sdk/compat03/conversion/RequestScopedBean_v0_3.java (100%) rename compat-0.3/tests/server-common/src/{test => main}/resources/META-INF/beans.xml (100%) diff --git a/boms/reference/src/it/reference-usage-test/src/main/java/org/a2aproject/sdk/test/ReferenceBomVerifier.java b/boms/reference/src/it/reference-usage-test/src/main/java/org/a2aproject/sdk/test/ReferenceBomVerifier.java index 316cee850..acf1143a4 100644 --- a/boms/reference/src/it/reference-usage-test/src/main/java/org/a2aproject/sdk/test/ReferenceBomVerifier.java +++ b/boms/reference/src/it/reference-usage-test/src/main/java/org/a2aproject/sdk/test/ReferenceBomVerifier.java @@ -19,7 +19,8 @@ public class ReferenceBomVerifier extends DynamicBomVerifier { "test-utils-docker/", // Test utilities for Docker-based tests "compat-0.3/client/", // Compat 0.3 client modules (part of SDK BOM) "compat-0.3/http-client/", // Compat 0.3 HTTP client (part of SDK BOM) - "compat-0.3/tck/" // Compat 0.3 TCK (not yet enabled) + "compat-0.3/tck/", // Compat 0.3 TCK (not yet enabled) + "compat-0.3/tests/" // Compat 0.3 test utilities // Note: reference/ and compat-0.3/reference/ are NOT excluded - we verify those classes load ); diff --git a/boms/sdk/src/it/sdk-usage-test/src/main/java/org/a2aproject/sdk/test/SdkBomVerifier.java b/boms/sdk/src/it/sdk-usage-test/src/main/java/org/a2aproject/sdk/test/SdkBomVerifier.java index 6fb7aefca..0d5631c7d 100644 --- a/boms/sdk/src/it/sdk-usage-test/src/main/java/org/a2aproject/sdk/test/SdkBomVerifier.java +++ b/boms/sdk/src/it/sdk-usage-test/src/main/java/org/a2aproject/sdk/test/SdkBomVerifier.java @@ -12,13 +12,14 @@ public class SdkBomVerifier extends DynamicBomVerifier { private static final Set SDK_EXCLUSIONS = Set.of( - "boms/", // BOM test modules themselves - "examples/", // Example applications - "tck/", // TCK test suite - "compat-0.3/tck/", // Compat 0.3 TCK (not yet enabled) + "boms/", // BOM test modules themselves + "examples/", // Example applications + "tck/", // TCK test suite + "compat-0.3/tck/", // Compat 0.3 TCK (not yet enabled) "compat-0.3/reference/", // Compat 0.3 reference implementations (in reference BOM) - "tests/", // Integration tests - "test-utils-docker/" // Test utilities for Docker-based tests + "compat-0.3/tests/", // Compat 0.3 test utilities) + "tests/", // Integration tests + "test-utils-docker/" // Test utilities for Docker-based tests ); private static final Set SDK_FORBIDDEN = Set.of( diff --git a/compat-0.3/pom.xml b/compat-0.3/pom.xml index 3af9938a0..0c1a7a852 100644 --- a/compat-0.3/pom.xml +++ b/compat-0.3/pom.xml @@ -108,7 +108,6 @@ ${project.groupId} a2a-java-sdk-compat-0.3-tests-server-common - test-jar ${project.version} diff --git a/compat-0.3/reference/grpc/pom.xml b/compat-0.3/reference/grpc/pom.xml index 57ff76c08..3652107dd 100644 --- a/compat-0.3/reference/grpc/pom.xml +++ b/compat-0.3/reference/grpc/pom.xml @@ -55,7 +55,6 @@ ${project.groupId} a2a-java-sdk-compat-0.3-tests-server-common - test-jar test @@ -137,4 +136,4 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/compat-0.3/reference/jsonrpc/pom.xml b/compat-0.3/reference/jsonrpc/pom.xml index f26228486..0f1925aec 100644 --- a/compat-0.3/reference/jsonrpc/pom.xml +++ b/compat-0.3/reference/jsonrpc/pom.xml @@ -40,7 +40,6 @@ ${project.groupId} a2a-java-sdk-compat-0.3-tests-server-common - test-jar test diff --git a/compat-0.3/reference/rest/pom.xml b/compat-0.3/reference/rest/pom.xml index b1615b378..d5857ddf5 100644 --- a/compat-0.3/reference/rest/pom.xml +++ b/compat-0.3/reference/rest/pom.xml @@ -36,7 +36,6 @@ ${project.groupId} a2a-java-sdk-compat-0.3-tests-server-common - test-jar test diff --git a/compat-0.3/tests/server-common/pom.xml b/compat-0.3/tests/server-common/pom.xml index d5e8633f7..70a85bd5a 100644 --- a/compat-0.3/tests/server-common/pom.xml +++ b/compat-0.3/tests/server-common/pom.xml @@ -29,35 +29,25 @@ jakarta.enterprise jakarta.enterprise.cdi-api - test + provided io.quarkus quarkus-arc - test + provided - org.apache.maven.plugins - maven-surefire-plugin + org.sonatype.central + central-publishing-maven-plugin + true - true + true - - org.apache.maven.plugins - maven-jar-plugin - - - - test-jar - - - - diff --git a/compat-0.3/tests/server-common/src/test/java/org/a2aproject/sdk/compat03/conversion/AgentExecutorProducer_v0_3.java b/compat-0.3/tests/server-common/src/main/java/org/a2aproject/sdk/compat03/conversion/AgentExecutorProducer_v0_3.java similarity index 100% rename from compat-0.3/tests/server-common/src/test/java/org/a2aproject/sdk/compat03/conversion/AgentExecutorProducer_v0_3.java rename to compat-0.3/tests/server-common/src/main/java/org/a2aproject/sdk/compat03/conversion/AgentExecutorProducer_v0_3.java diff --git a/compat-0.3/tests/server-common/src/test/java/org/a2aproject/sdk/compat03/conversion/RequestScopedBean_v0_3.java b/compat-0.3/tests/server-common/src/main/java/org/a2aproject/sdk/compat03/conversion/RequestScopedBean_v0_3.java similarity index 100% rename from compat-0.3/tests/server-common/src/test/java/org/a2aproject/sdk/compat03/conversion/RequestScopedBean_v0_3.java rename to compat-0.3/tests/server-common/src/main/java/org/a2aproject/sdk/compat03/conversion/RequestScopedBean_v0_3.java diff --git a/compat-0.3/tests/server-common/src/test/resources/META-INF/beans.xml b/compat-0.3/tests/server-common/src/main/resources/META-INF/beans.xml similarity index 100% rename from compat-0.3/tests/server-common/src/test/resources/META-INF/beans.xml rename to compat-0.3/tests/server-common/src/main/resources/META-INF/beans.xml