Crafting not being caught

[elementalistic]

I'm using:
FTB Revelations 1.3.0
spongeforge-1.12.2-2555-7.1.0-BETA-2833.jar
LuckPerms-Sponge-4.0.90.jar
ProtectionPerms-1.4.0.jar

If I craft an item with Applied Energistics or with Tinkers' Construct crafting table, neither event triggers the protectionperms.item.craft check. At least when using /lp verbose true.

I'm also using a few other plugins like nucleus, fawe, griefprevention, but don't see them messing with it as the vanilla crafting table gets blocked properly.

I am a bit behind in versions for sponge and luckperms, so I'll try updating them tomorrow.

[williamhatcher]

Please let us know the results after you update Sponge and LuckPerms.

@Zerthick is working on a few other plugins, but I'll give this a shot. I imagine ProtectionPerms isn't hooking into Tinker's crafting event, or Tinker doesn't send a crafting event.

[Zerthick]

There is no crafting event in sponge currently, so I have to do some hacky stuff listening to click inventory events. That being said, I only accounted for player and workbench inventories in my code. I'll release a quick dev build to see if that resolves the issue.

[Zerthick]

If you wouldn't mind, could you test to see if this dev build resolves the issue? Extract the zip to get the jar.

Thanks!

ProtecitonPermsDevBuild.zip

[elementalistic]

Ok updated mods/plugins:
forge-1.12.2-14.23.1.2586-universal.jar
spongeforge-1.12.2-2586-7.1.0-BETA-2865.jar
LuckPerms-Sponge-4.0.121.jar
griefprevention-1.12.2-4.3.0.529.jar
ProtectionPerms-0.9.0.jar (dev build)

Updating everything without the Dev Build of protection perms didn't fix it. So I've now put the Dev Build on the server.

It's now catching the tinkers construct crafting station. Exhibiting the same behaviour as the vanilla crafting grid. On trying to place the last item for the crafted item, it stops you from placing it into the crafting grid and displays the red error message, albeit behind the crafting GUI, so you can't see it (think it's always been like that).

To note, the tinkers crafting station can keep items in it's crafting grid when you close it. If someone else has placed the recipe you are not allowed to craft into the grid. You can then open the crafting table and pull out the crafted item.

Working as in checks protectionperms.item.craft.blah and stops item from crafting

• Vanilla "Crafting Table"
• Tinkers' Construct "Crafting Station"
• Actually Additions "Crafting Table On A Stick"

Doesn't check protectionperms.item.craft.blah

• Applied Energistics "ME Crafting Terminal"
• Engineer's Workshop Reborn "Workshop Table"
• Forestry "Worktable"

I've not looked at any of the auto crafters either. I'm also only using "/lp verbose true " for myself, to see if it's using it. So if those crafters are using other players/fakes I won't be seeing it. I'll have to wait till the server is empty of players to see if they are using fake players for the crafting.

[Zerthick]

Hmmm, that's interesting. I didn't account for the possibility that the crafting inventory may remain open. As for the other mods not working, they aren't reporting the output slot as a crafting output, so my plugin can't pick up on it. That's really more an issue with the mod than the functionality of this plugin. Hopefully a true crafting event will be added to sponge so I don't have to rely on listening to inventory clicks.

[Zerthick]

Looks like it's in the works: SpongePowered/SpongeAPI#1730

[Zerthick]

@elementalistic Should be fixed in v1.4.3!