From e68544269ad400df05999d8ad9b39bef16fb23c1 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 22 May 2026 20:49:37 +0000 Subject: [PATCH 1/2] Refine foreground service notification copy - Replaced aggressive 'Kill' action text with standard 'Stop' terminology. - Updated desktop-centric 'Click to open' description to mobile-friendly 'Tap to open app'. - Extracted all hardcoded notification texts and channel names to `strings.xml` for localization. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com> --- .Jules/palette.md | 3 +++ .../main/java/com/samsung/android/scan3d/serv/Cam.kt | 10 +++++----- app/src/main/res/values/strings.xml | 7 +++++++ 3 files changed, 15 insertions(+), 5 deletions(-) diff --git a/.Jules/palette.md b/.Jules/palette.md index 8e61b09..7a65dab 100644 --- a/.Jules/palette.md +++ b/.Jules/palette.md @@ -146,3 +146,6 @@ ## 2026-05-20 - Mouse Hover States for Custom Selectors **Learning:** Custom drawable selectors (like `ic_shutter.xml`) on Android often define `state_pressed` and `state_focused` but omit `state_hovered`. This strips visual feedback for users navigating with pointer devices (mice, trackpads) on environments like Chromebooks or Samsung DeX, degrading the user experience compared to native components. **Action:** Always include `android:state_hovered="true"` alongside focus and pressed states in custom interactive background selectors to ensure universal visual feedback across all input methods. +## 2024-05-22 - Tone and Voice in System Notifications +**Learning:** Hardcoding technical or aggressive terminology like "Kill" for destructive actions in user-facing system notifications (like foreground service controls) degrades the user experience by using unnecessarily alarming language instead of standard, culturally understood UX terms. +**Action:** Always avoid aggressive technical jargon in UI copy. Opt for standard UX phrasing like "Stop" instead of "Kill", and "Tap" instead of "Click" for mobile contexts, and ensure all notification text is extracted to localized string resources. diff --git a/app/src/main/java/com/samsung/android/scan3d/serv/Cam.kt b/app/src/main/java/com/samsung/android/scan3d/serv/Cam.kt index 902764a..ed9e98e 100644 --- a/app/src/main/java/com/samsung/android/scan3d/serv/Cam.kt +++ b/app/src/main/java/com/samsung/android/scan3d/serv/Cam.kt @@ -45,10 +45,10 @@ class Cam : Service() { "start" -> { val channel = NotificationChannel( CHANNEL_ID, - CHANNEL_ID, + getString(R.string.notification_channel_name), NotificationManager.IMPORTANCE_DEFAULT ) - channel.description = "RemoteCam run" + channel.description = getString(R.string.notification_channel_desc) val notificationManager = getSystemService(NotificationManager::class.java) notificationManager.createNotificationChannel(channel) @@ -72,9 +72,9 @@ class Cam : Service() { val builder = NotificationCompat.Builder(this, CHANNEL_ID) - .setContentTitle("RemoteCam (active)") - .setContentText("Click to open").setOngoing(true) - .setSmallIcon(R.drawable.ic_linked_camera).addAction(R.drawable.ic_close, "Kill",pendingIntentKill) + .setContentTitle(getString(R.string.notification_title)) + .setContentText(getString(R.string.notification_text)).setOngoing(true) + .setSmallIcon(R.drawable.ic_linked_camera).addAction(R.drawable.ic_close, getString(R.string.notification_action_stop), pendingIntentKill) .setContentIntent(pendingIntent) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index b34ffb5..8d3fd8b 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -47,6 +47,13 @@ Copied to clipboard No web browser found. Please install a browser to view the repository. + + RemoteCam Service + Shows active status of the remote camera server + RemoteCam (active) + Tap to open app + Stop + Stop Server? This will stop the camera stream and close the application. From aefbd56624abf03850e9d17ddac41f8e175bd87a Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sat, 23 May 2026 02:28:06 +0000 Subject: [PATCH 2/2] Refine foreground service notification copy - Replaced aggressive 'Kill' action text with standard 'Stop' terminology. - Updated desktop-centric 'Click to open' description to mobile-friendly 'Tap to open app'. - Extracted all hardcoded notification texts and channel names to `strings.xml` for localization. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>