Skip to content

Commit b3ee8a0

Browse files
authored
Rollup merge of rust-lang#152145 - Zalathar:recv-timeout-before-send, r=workingjubilee
Disable flaky test `oneshot::recv_timeout_before_send` This test is inherently flaky due to a thread-scheduling race condition, and has failed several times in CI, e.g.: - rust-lang#151739 (comment) - rust-lang#151971 (comment) - rust-lang#151376 (comment) --- - cc @connortsui20, author of rust-lang#143741
2 parents 0e525c5 + 6970849 commit b3ee8a0

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

library/std/tests/sync/oneshot.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ fn recv_before_send() {
127127
}
128128

129129
#[test]
130+
#[ignore = "Inherently flaky and has caused several CI failures"]
130131
fn recv_timeout_before_send() {
131132
let (sender, receiver) = oneshot::channel();
132133

@@ -135,6 +136,8 @@ fn recv_timeout_before_send() {
135136
sender.send(99u128).unwrap();
136137
});
137138

139+
// FIXME(#152145): Under load, there's no guarantee that thread `t` has
140+
// ever been scheduled and run before this timeout expires.
138141
match receiver.recv_timeout(Duration::from_secs(1)) {
139142
Ok(99) => {}
140143
_ => panic!("expected Ok(99)"),

0 commit comments

Comments
 (0)