Skip to content

Commit cf8f55a

Browse files
committed
fix(anglicise): unify drifted is_excluded_text_line functions
The check and fix steps had diverged; each had exclusion patterns the other was missing (file://, Authorization header, standalone --color/--center flags, case-insensitive assignment matching, broader ${} variable detection). Unified to a single superset pattern in all 4 copies (live + template × check + fix).
1 parent 5f4705a commit cf8f55a

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/anglicise.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ jobs:
318318
319319
is_excluded_text_line() {
320320
local line="$1"
321-
echo "$line" | grep -qE '(https?://|file://|github/|[?&](color|center|gray|licence)=[a-zA-Z0-9]+|"Authorization": "Bearer|types:[[:space:]]*\[[^]]+\]|--[a-z-]+ (center|color|gray)|\$\{?(color|center|gray);\}|\b(color|center|gray|licence)[_A-Z]*=|license/licence|licence/license|license_file|licence_file|LICENSE(_FILES?)?|LICENSE.*LICENCE|LICENCE.*LICENSE|gum |\\$|shields\.io|stop-color|[a-z-]color[a-z-]*:|color[a-z-]*:[[:space:]]*#|align-items:)'
321+
echo "$line" | grep -qE "(https?://|file://|github/|[?&](color|center|gray|licence)=|=[\"'](center|color|licence)|\"Authorization\": \"Bearer|types:[[:space:]]*\[[^]]+\]|--[a-z-]+ (center|color|gray)|--color|--center|\$\{?(color|center|gray|licence)|\b(color|center|gray|licence|COLOR|CENTER|GRAY|LICENCE)[_A-Z]*=|license/licence|licence/license|license_file|licence_file|LICENSE(_FILES?)?|LICENSE.*LICENCE|LICENCE.*LICENSE|gum |\\$|shields\.io|stop-color|[a-z-]color[a-z-]*:|color[a-z-]*:[[:space:]]*#|align-items:)"
322322
}
323323
324324
echo "## British English Spelling Check" >> $GITHUB_STEP_SUMMARY
@@ -427,7 +427,7 @@ jobs:
427427
428428
is_excluded_text_line() {
429429
local line="$1"
430-
echo "$line" | grep -qE "(https?://|github/|[?&](color|center|gray|licence)=|=[\"'](center|color|licence)|types:[[:space:]]*\[[^]]+\]|--[a-z-]+ (center|color|gray)|--color|--center|\$\{?(color|center|gray|licence)|\b(COLOR|CENTER|GRAY|LICENCE)[_A-Z]*=|license/licence|licence/license|license_file|licence_file|LICENSE(_FILES?)?|LICENSE.*LICENCE|LICENCE.*LICENSE|gum |\\$|shields\.io|stop-color|[a-z-]color[a-z-]*:|color[a-z-]*:[[:space:]]*#|align-items:)"
430+
echo "$line" | grep -qE "(https?://|file://|github/|[?&](color|center|gray|licence)=|=[\"'](center|color|licence)|\"Authorization\": \"Bearer|types:[[:space:]]*\[[^]]+\]|--[a-z-]+ (center|color|gray)|--color|--center|\$\{?(color|center|gray|licence)|\b(color|center|gray|licence|COLOR|CENTER|GRAY|LICENCE)[_A-Z]*=|license/licence|licence/license|license_file|licence_file|LICENSE(_FILES?)?|LICENSE.*LICENCE|LICENCE.*LICENSE|gum |\\$|shields\.io|stop-color|[a-z-]color[a-z-]*:|color[a-z-]*:[[:space:]]*#|align-items:)"
431431
}
432432
433433
FIXED_COUNT=0

workflows-templates/anglicise.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ jobs:
321321
322322
is_excluded_text_line() {
323323
local line="$1"
324-
echo "$line" | grep -qE '(https?://|file://|github/|[?&](color|center|gray|licence)=[a-zA-Z0-9]+|"Authorization": "Bearer|types:[[:space:]]*\[[^]]+\]|--[a-z-]+ (center|color|gray)|\$\{?(color|center|gray);\}|\b(color|center|gray|licence)[_A-Z]*=|license/licence|licence/license|license_file|licence_file|LICENSE(_FILES?)?|LICENSE.*LICENCE|LICENCE.*LICENSE|gum |\\$|shields\.io|stop-color|[a-z-]color[a-z-]*:|color[a-z-]*:[[:space:]]*#|align-items:)'
324+
echo "$line" | grep -qE "(https?://|file://|github/|[?&](color|center|gray|licence)=|=[\"'](center|color|licence)|\"Authorization\": \"Bearer|types:[[:space:]]*\[[^]]+\]|--[a-z-]+ (center|color|gray)|--color|--center|\$\{?(color|center|gray|licence)|\b(color|center|gray|licence|COLOR|CENTER|GRAY|LICENCE)[_A-Z]*=|license/licence|licence/license|license_file|licence_file|LICENSE(_FILES?)?|LICENSE.*LICENCE|LICENCE.*LICENSE|gum |\\$|shields\.io|stop-color|[a-z-]color[a-z-]*:|color[a-z-]*:[[:space:]]*#|align-items:)"
325325
}
326326
327327
echo "## British English Spelling Check" >> $GITHUB_STEP_SUMMARY
@@ -430,7 +430,7 @@ jobs:
430430
431431
is_excluded_text_line() {
432432
local line="$1"
433-
echo "$line" | grep -qE "(https?://|github/|[?&](color|center|gray|licence)=|=[\"'](center|color|licence)|types:[[:space:]]*\[[^]]+\]|--[a-z-]+ (center|color|gray)|--color|--center|\$\{?(color|center|gray|licence)|\b(COLOR|CENTER|GRAY|LICENCE)[_A-Z]*=|license/licence|licence/license|license_file|licence_file|LICENSE(_FILES?)?|LICENSE.*LICENCE|LICENCE.*LICENSE|gum |\\$|shields\.io|stop-color|[a-z-]color[a-z-]*:|color[a-z-]*:[[:space:]]*#|align-items:)"
433+
echo "$line" | grep -qE "(https?://|file://|github/|[?&](color|center|gray|licence)=|=[\"'](center|color|licence)|\"Authorization\": \"Bearer|types:[[:space:]]*\[[^]]+\]|--[a-z-]+ (center|color|gray)|--color|--center|\$\{?(color|center|gray|licence)|\b(color|center|gray|licence|COLOR|CENTER|GRAY|LICENCE)[_A-Z]*=|license/licence|licence/license|license_file|licence_file|LICENSE(_FILES?)?|LICENSE.*LICENCE|LICENCE.*LICENSE|gum |\\$|shields\.io|stop-color|[a-z-]color[a-z-]*:|color[a-z-]*:[[:space:]]*#|align-items:)"
434434
}
435435
436436
FIXED_COUNT=0

0 commit comments

Comments
 (0)