From e80e47285704436cdda79c39e2f5323287bf6102 Mon Sep 17 00:00:00 2001 From: Aki Hamano Date: Wed, 18 Mar 2026 15:10:38 +0900 Subject: [PATCH 1/3] Admin reskin: fix pressed state button style --- src/wp-admin/css/colors/_admin.scss | 4 +- src/wp-content/plugins/hello.php | 106 ---------------------------- src/wp-includes/css/buttons.css | 19 +++-- 3 files changed, 11 insertions(+), 118 deletions(-) delete mode 100644 src/wp-content/plugins/hello.php diff --git a/src/wp-admin/css/colors/_admin.scss b/src/wp-admin/css/colors/_admin.scss index 011912fa7efeb..29741583642e4 100644 --- a/src/wp-admin/css/colors/_admin.scss +++ b/src/wp-admin/css/colors/_admin.scss @@ -174,7 +174,7 @@ input[type="radio"]:focus { .button-group > .button.active { border-color: var(--wp-admin-theme-color); - background: rgba(var(--wp-admin-theme-color--rgb), 0.04); + background: rgba(var(--wp-admin-theme-color--rgb), 0.15); } .wp-ui-primary { @@ -646,7 +646,7 @@ div#wp-responsive-toggle a:before { } .wp-responsive-open div#wp-responsive-toggle a { - // ToDo: make inset border + // ToDo: make inset border;ToDo border-color: transparent; background: variables.$menu-highlight-background; } diff --git a/src/wp-content/plugins/hello.php b/src/wp-content/plugins/hello.php deleted file mode 100644 index f820405da93e4..0000000000000 --- a/src/wp-content/plugins/hello.php +++ /dev/null @@ -1,106 +0,0 @@ -Hello, Dolly in the upper right of your admin screen on every page. -Author: Matt Mullenweg -Version: 1.7.2 -Author URI: http://ma.tt/ -Text Domain: hello-dolly -*/ - -// Do not load directly. -if ( ! defined( 'ABSPATH' ) ) { - die(); -} - -function hello_dolly_get_lyric() { - /** These are the lyrics to Hello Dolly */ - $lyrics = "Hello, Dolly -Well, hello, Dolly -It's so nice to have you back where you belong -You're lookin' swell, Dolly -I can tell, Dolly -You're still glowin', you're still crowin' -You're still goin' strong -I feel the room swayin' -While the band's playin' -One of our old favorite songs from way back when -So, take her wrap, fellas -Dolly, never go away again -Hello, Dolly -Well, hello, Dolly -It's so nice to have you back where you belong -You're lookin' swell, Dolly -I can tell, Dolly -You're still glowin', you're still crowin' -You're still goin' strong -I feel the room swayin' -While the band's playin' -One of our old favorite songs from way back when -So, golly, gee, fellas -Have a little faith in me, fellas -Dolly, never go away -Promise, you'll never go away -Dolly'll never go away again"; - - // Here we split it into lines. - $lyrics = explode( "\n", $lyrics ); - - // And then randomly choose a line. - return wptexturize( $lyrics[ mt_rand( 0, count( $lyrics ) - 1 ) ] ); -} - -// This just echoes the chosen line, we'll position it later. -function hello_dolly() { - $chosen = hello_dolly_get_lyric(); - $lang = ''; - if ( 'en_' !== substr( get_user_locale(), 0, 3 ) ) { - $lang = ' lang="en"'; - } - - printf( - '

%s %s

', - __( 'Quote from Hello Dolly song, by Jerry Herman:' ), - $lang, - $chosen - ); -} - -// Now we set that function up to execute when the admin_notices action is called. -add_action( 'admin_notices', 'hello_dolly' ); - -// We need some CSS to position the paragraph. -function dolly_css() { - echo " - - "; -} - -add_action( 'admin_head', 'dolly_css' ); diff --git a/src/wp-includes/css/buttons.css b/src/wp-includes/css/buttons.css index 87185d3686455..8e9259931cbe7 100644 --- a/src/wp-includes/css/buttons.css +++ b/src/wp-includes/css/buttons.css @@ -190,15 +190,16 @@ TABLE OF CONTENTS: /* pressed state e.g. a selected setting */ .wp-core-ui .button.active, .wp-core-ui .button.active:hover { - background-color: rgba(var(--wp-admin-theme-color--rgb), 0.04); + background-color: rgba(var(--wp-admin-theme-color--rgb), 0.15); color: var(--wp-admin-theme-color); border-color: var(--wp-admin-theme-color); - box-shadow: none; + box-shadow: inset 0 2px 5px -3px var(--wp-admin-theme-color-darker-20); } .wp-core-ui .button.active:focus { - border-color: var(--wp-admin-theme-color); - box-shadow: 0 0 0 var(--wp-admin-border-width-focus, 1.5px) var(--wp-admin-theme-color); + background-color: rgba(var(--wp-admin-theme-color--rgb), 0.15); + border-color: var(--wp-admin-theme-color-darker-20); + box-shadow: inset 0 2px 5px -3px var(--wp-admin-theme-color-darker-20), 0 0 0 var(--wp-admin-border-width-focus, 1.5px) var(--wp-admin-theme-color); } .wp-core-ui .button[disabled], @@ -363,15 +364,13 @@ TABLE OF CONTENTS: .wp-core-ui .button-group > .button.active { background-color: #dcdcde; color: #135e96; - border-color: #0a4b78; - box-shadow: inset 0 2px 5px -3px #0a4b78; + border-color: var(--wp-admin-theme-color); + box-shadow: inset 0 2px 5px -3px var(--wp-admin-theme-color-darker-20); } .wp-core-ui .button-group > .button.active:focus { - border-color: #3582c4; - box-shadow: - inset 0 2px 5px -3px #0a4b78, - 0 0 0 1px #3582c4; + border-color: var(--wp-admin-theme-color); + box-shadow: inset 0 2px 5px -3px var(--wp-admin-theme-color-darker-20), 0 0 0 var(--wp-admin-border-width-focus, 1.5px) var(--wp-admin-theme-color); } /* ---------------------------------------------------------------------------- From 01355565fd30b5c66e2f160f7c2767dd6c467775 Mon Sep 17 00:00:00 2001 From: Aki Hamano Date: Wed, 18 Mar 2026 15:23:00 +0900 Subject: [PATCH 2/3] WIP --- src/wp-includes/css/buttons.css | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/wp-includes/css/buttons.css b/src/wp-includes/css/buttons.css index 8e9259931cbe7..b5e81179c62f1 100644 --- a/src/wp-includes/css/buttons.css +++ b/src/wp-includes/css/buttons.css @@ -362,8 +362,6 @@ TABLE OF CONTENTS: /* pressed state e.g. a selected setting */ .wp-core-ui .button-group > .button.active { - background-color: #dcdcde; - color: #135e96; border-color: var(--wp-admin-theme-color); box-shadow: inset 0 2px 5px -3px var(--wp-admin-theme-color-darker-20); } From d91abc4dfb972200df342424d045c088b3a688e8 Mon Sep 17 00:00:00 2001 From: Aki Hamano Date: Wed, 18 Mar 2026 18:24:19 +0900 Subject: [PATCH 3/3] Revert unnecessary change --- src/wp-admin/css/colors/_admin.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-admin/css/colors/_admin.scss b/src/wp-admin/css/colors/_admin.scss index 29741583642e4..1bc4162479353 100644 --- a/src/wp-admin/css/colors/_admin.scss +++ b/src/wp-admin/css/colors/_admin.scss @@ -646,7 +646,7 @@ div#wp-responsive-toggle a:before { } .wp-responsive-open div#wp-responsive-toggle a { - // ToDo: make inset border;ToDo + // ToDo: make inset border border-color: transparent; background: variables.$menu-highlight-background; }