Summary
When index --watch --follow-symlinks internal|all uses the polling backend, changes beneath an allowed directory symlink can be missed indefinitely.
The polling snapshot prunes every child directory with FileAttributes.ReparsePoint before consulting the configured symlink policy. As a result, an internal directory symlink is not traversed under internal, and an external directory symlink is not traversed under all. This is especially visible when the target is otherwise excluded from the normal lexical traversal, such as an allowed link into a dependency directory.
The baseline/full scan can index these paths, so later polling can leave their indexed rows and symbols stale without emitting an update event.
Expected behavior
The polling backend should apply the same --follow-symlinks none|internal|all contract as the baseline scan and filesystem-event backend. Allowed directory links should be observed, while disallowed targets, cycles, and duplicate traversal remain bounded and safe.
Suggested regression coverage
- Under
internal, index an in-workspace directory symlink and modify a source file through its target.
- Under
all, repeat with an allowed external directory target.
- Verify polling enqueues the indexed symlink-relative path and refreshes the database.
- Preserve
none rejection, outside-target rejection under internal, cycle handling, and duplicate-path bounds.
Scope note
This pre-existing polling gap was identified while auditing #5091. That issue's watch changes preserve valid file-symlink events and recover strict partial-update usage errors, but do not change directory-link traversal semantics.
Summary
When
index --watch --follow-symlinks internal|alluses the polling backend, changes beneath an allowed directory symlink can be missed indefinitely.The polling snapshot prunes every child directory with
FileAttributes.ReparsePointbefore consulting the configured symlink policy. As a result, an internal directory symlink is not traversed underinternal, and an external directory symlink is not traversed underall. This is especially visible when the target is otherwise excluded from the normal lexical traversal, such as an allowed link into a dependency directory.The baseline/full scan can index these paths, so later polling can leave their indexed rows and symbols stale without emitting an update event.
Expected behavior
The polling backend should apply the same
--follow-symlinks none|internal|allcontract as the baseline scan and filesystem-event backend. Allowed directory links should be observed, while disallowed targets, cycles, and duplicate traversal remain bounded and safe.Suggested regression coverage
internal, index an in-workspace directory symlink and modify a source file through its target.all, repeat with an allowed external directory target.nonerejection, outside-target rejection underinternal, cycle handling, and duplicate-path bounds.Scope note
This pre-existing polling gap was identified while auditing #5091. That issue's watch changes preserve valid file-symlink events and recover strict partial-update usage errors, but do not change directory-link traversal semantics.