Refine class hook diagnostics and super coding advisory

Author: WendellXY

Sources/CodableKitMacros/CodeGenCore.swift

@@ -263,6 +263,11 @@ extension CodeGenCore {
 
 // MARK: - Code Generation Preparation
 extension CodeGenCore {
+  fileprivate static func shouldWarnAboutSuperCoding(for declaration: some DeclGroupSyntax) -> Bool {
+    let inherited = directInheritedTypeNames(in: declaration)
+    return inherited.contains("NSObject")
+  }
+
   /// Validate that the macro is being applied to a struct declaration
   fileprivate func validateDeclaration(
     for declaration: some DeclGroupSyntax,
@@ -335,6 +340,7 @@ extension CodeGenCore {
     if emitAdvisories,
       case .classType(let hasSuperclass) = structureTypes[id],
       hasSuperclass,
+      Self.shouldWarnAboutSuperCoding(for: declaration),
       !options.contains(.skipSuperCoding)
     {
       let message = "If the inherited type is not Codable, add '.skipSuperCoding' to avoid generating super encode/decode calls"

Tests/CodableKitTests/CodableMacroTests+class_hooks.swift

@@ -160,21 +160,24 @@ import Testing
       diagnostics: [
         .init(
           message: "Hook method 'willEncode' will not be invoked unless annotated with @CodableHook(.willEncode)",
-          line: 1,
-          column: 1,
-          severity: .error
+          line: 6,
+          column: 3,
+          severity: .error,
+          fixIts: [.init(message: "Insert @CodableHook(.willEncode)")]
         ),
         .init(
           message: "Hook method 'didEncode' will not be invoked unless annotated with @CodableHook(.didEncode)",
-          line: 1,
-          column: 1,
-          severity: .error
+          line: 7,
+          column: 3,
+          severity: .error,
+          fixIts: [.init(message: "Insert @CodableHook(.didEncode)")]
         ),
         .init(
           message: "Hook method 'didDecode' will not be invoked unless annotated with @CodableHook(.didDecode)",
-          line: 1,
-          column: 1,
-          severity: .error
+          line: 8,
+          column: 3,
+          severity: .error,
+          fixIts: [.init(message: "Insert @CodableHook(.didDecode)")]
         ),
       ]
     )