Possible leak of ArrayBuffers in babylonjs-scene-es6

[dinfuehr]

Hi everyone,

it seems babylonjs-scene-es6 is leaking ArrayBuffer objects. This screenshots are from a heap snapshot after that benchmark ran (e.g. http://localhost:8010/?test=babylonjs-scene-es6 is enough for this). I would expect that the ArrayBuffers get collected by the GC but they stay around in Chrome/Safari/Firefox.

Chrome:

Safari:

Firefox:

Hope this helps!

[camillobruni]

Both bablyonjs and the physics engine keep global state cached, we need to properly dispose it to not leak any data.

[kmiller68]

I would expect that to go away when the contents of the "magic" iframe are changed? Is that not the case?

[camillobruni]

ah yes, you're right. Once we navigate away we're definitely good.
Probably adding something like

function stopScene(scene, engine) {
  scene.disablePhysicsEngine();
  engine.stopRenderLoop();
  scene.dispose();
  engine.dispose();
}

For the next release would not be the worst.

[camillobruni]

Looks like this is still a bit problematic since we leak quite some data per iteration within the workload – my current estimate is around 180MB / iteration on chrome.