Tried DataRenderer to Format MULTI_SZ and Failed

[utkonos]

Here is the HLIL:

This is the source code:

Here is the preload data location

I was able to get the datarenderer to make it look nicer (still some polish needed with regards to indentation and not having it swallow the padding at the end. to get this to work, i needed to make a struct like this:

struct preload_t {
    char data[0x54];
};

But then the IL changes to show &preload which is not ideal:

So then I tried a typedef, thinking that it would be treated the same as the type, but that works out the same as the struct above with the change in the IL:

typedef char preload_t[0x54];

And finally I tried to scope the datarenderer to just that symbol, but that doesn't work either.

Here is the one that worked mostly except that it requires a struct that causes IL problems separately from the datarenderer.

from binaryninja import (
    DataRenderer, DisassemblyTextLine,
    InstructionTextToken as Tok,
    InstructionTextTokenType as T,
    TypeClass,
)

class MultiSzRenderer(DataRenderer):
    def perform_is_valid_for_data(self, ctxt, view, addr, type, context):
        if type.type_class == TypeClass.NamedTypeReferenceClass:
            return type.name == "preload_t"
        return DataRenderer.is_type_of_struct_name(type, "preload_t", context)

    def perform_get_lines_for_data(self, ctxt, view, addr, type, prefix, width, context):
        n = type.width
        if n == 0:
            tgt = type.target(view)
            if tgt is not None:
                n = tgt.width
        raw = view.read(addr, n)
        lines, cur, i = [], addr, 0
        while i < len(raw):
            if raw[i] == 0:
                while i < len(raw) and raw[i] == 0:
                    i += 1
                cur = addr + i
                continue
            end = raw.find(b"\x00", i)
            if end == -1:
                end = len(raw)
            s = raw[i:end].decode("ascii", "replace")
            lines.append(DisassemblyTextLine([
                Tok(T.BraceToken, '"'), Tok(T.StringToken, s), Tok(T.BraceToken, '"'),
                Tok(T.TextToken, ', '), Tok(T.IntegerToken, '0'),
            ], cur))
            i = end
            cur = addr + i
        if not lines:
            return [DisassemblyTextLine(prefix, addr)]
        lines[0] = DisassemblyTextLine(prefix + lines[0].tokens, lines[0].address)
        return lines

MultiSzRenderer().register_type_specific()

[plafosse]

I think what you want here is the new CustomStringType documentation is a bit lacking at the moment but we're trying to get that sorted for the upcoming release.