[Rust] WIP: Replace log with tracing

- Added more documentation
- Replaced global named logger for plugins, fixing the issue when the CU has multiple (e.g. statically linked demo)
- Explicitly name the target for the log event, this is how it must be done to guarantee we send it to the correct one
- Simplified some misc code

This is a breaking change, but I believe there is no better time to make it, we cannot continue to use the `log` crate, it is too limited for our needs.

Author: emesare

Cargo.lock

@@ -8,7 +8,6 @@ license = "Apache-2.0"
 [dependencies]
 binaryninja.workspace = true
 binaryninjacore-sys.workspace = true
-log = "0.4"
 msp430-asm = "^0.2"
 
 [lib]

arch/msp430/Cargo.toml

@@ -8,7 +8,7 @@ use binaryninja::{
         UnusedIntrinsic, UnusedRegisterStack,
     },
     disassembly::{InstructionTextToken, InstructionTextTokenKind},
-    Endianness,
+    tracing, Endianness,
 };
 
 use msp430_asm::{
@@ -21,7 +21,6 @@ use binaryninja::architecture::{
 };
 use binaryninja::low_level_il::expression::ValueExpr;
 use binaryninja::low_level_il::{LowLevelILMutableExpression, LowLevelILMutableFunction};
-use log::error;
 
 const MIN_MNEMONIC: usize = 9;
 
@@ -321,7 +320,7 @@ impl Architecture for Msp430 {
         match id.try_into() {
             Ok(flag) => Some(flag),
             Err(_) => {
-                error!("invalid flag id {}", id);
+                tracing::error!(target: "MSP430", "invalid flag id {}", id);
                 None
             }
         }
@@ -331,7 +330,7 @@ impl Architecture for Msp430 {
         match id.try_into() {
             Ok(flag_write) => Some(flag_write),
             Err(_) => {
-                error!("invalid flag write id {}", id);
+                tracing::error!(target: "MSP430", "invalid flag write id {}", id);
                 None
             }
         }

arch/msp430/src/architecture.rs

@@ -1,28 +1,22 @@
-extern crate binaryninja;
-extern crate log;
-extern crate msp430_asm;
-
 use binaryninja::{
     add_optional_plugin_dependency,
     architecture::ArchitectureExt,
     calling_convention,
     custom_binary_view::{BinaryViewType, BinaryViewTypeExt},
     Endianness,
 };
-use log::LevelFilter;
 
 mod architecture;
 mod flag;
 mod lift;
 mod register;
 
 use architecture::Msp430;
-use binaryninja::logger::Logger;
 
 #[no_mangle]
 #[allow(non_snake_case)]
 pub extern "C" fn CorePluginInit() -> bool {
-    Logger::new("MSP430").with_level(LevelFilter::Info).init();
+    binaryninja::tracing::init();
     let arch =
         binaryninja::architecture::register_architecture("msp430", |custom_handle, handle| {
             Msp430::new(handle, custom_handle)

arch/msp430/src/lib.rs

@@ -2,7 +2,7 @@ use crate::architecture::offset_to_absolute;
 use crate::flag::{Flag, FlagWrite};
 use crate::register::Register;
 
-use binaryninja::{architecture::FlagCondition, low_level_il::lifting::LowLevelILLabel};
+use binaryninja::{architecture::FlagCondition, low_level_il::lifting::LowLevelILLabel, tracing};
 
 use msp430_asm::emulate::Emulated;
 use msp430_asm::instruction::Instruction;
@@ -13,7 +13,6 @@ use msp430_asm::two_operand::TwoOperand;
 
 use binaryninja::low_level_il::expression::ValueExpr;
 use binaryninja::low_level_il::{LowLevelILMutableExpression, LowLevelILMutableFunction};
-use log::info;
 
 macro_rules! auto_increment {
     ($src:expr, $il:ident) => {
@@ -550,7 +549,7 @@ pub(crate) fn lift_instruction(inst: &Instruction, addr: u64, il: &LowLevelILMut
                 il.set_reg(size, Register::try_from(*r as u32).unwrap(), il.pop(2))
                     .append();
             } else {
-                info!("pop: invalid destination operand");
+                tracing::info!(target: "MSP430", "pop: invalid destination operand");
             }
         }
         Instruction::Ret(_) => {

arch/msp430/src/lift.rs

@@ -9,7 +9,6 @@ license = "Apache-2.0"
 binaryninja.workspace = true
 binaryninjacore-sys.workspace = true
 riscv-dis = { path = "disasm" }
-log = "0.4"
 rayon = { version = "1.0", optional = true }
 
 [features]