small fix

Author: astrophysik

runtime-light/state/instance-state.cpp

@@ -214,4 +214,21 @@ kphp::coro::task<> InstanceState::run_instance_epilogue() noexcept {
     web_state.session_is_finished = true;
     web_state.session.reset();
   }
+
+  /*
+   * Unlike regular RPC requests whose results the user code waits for via rpc_fetch_responses,
+   * thereby guaranteeing they are sent, the user code does not wait for requests sent with the
+   * ignore_answer flag. Therefore, we can’t guarantee that the coroutines responsible for
+   * sending ignore_answer requests have finished. This means the requests might not be sent
+   * if the instance terminates.
+   *
+   * This await suspends the current coroutine until all pending ignore_answer requests are
+   * fully sent. While suspended, other forks and coroutines may continue running.
+   *
+   * After this call completes, delivery of all ignore_answer requests is guaranteed.
+   */
+  const auto ignore_answer_tasks{RpcClientInstanceState::get().ignore_answer_awaiter_tasks};
+  for (const auto& [_, awaiter_task] : ignore_answer_tasks) {
+    co_await awaiter_task.when_ready();
+  }
 }

runtime-light/stdlib/exit/exit-functions.h

@@ -28,20 +28,6 @@ inline kphp::coro::task<> f$exit(mixed v = 0) noexcept { // TODO: make it synchr
   }
   co_await kphp::forks::id_managed(instance_st.run_instance_epilogue());
 
-  /*
-   * Unlike regular RPC requests whose results the user code waits for via rpc_fetch_responses,
-   * thereby guaranteeing they are sent, the user code does not wait for requests sent with the
-   * ignore_answer flag. Therefore, we can’t guarantee that the coroutines responsible for
-   * sending ignore_answer requests have finished. This means the requests might not be sent
-   * if the instance terminates.
-   *
-   * This await suspends the current coroutine until all pending ignore_answer requests are
-   * fully sent. While suspended, other forks and coroutines may continue running.
-   *
-   * After this call completes, delivery of all ignore_answer requests is guaranteed.
-   */
-  co_await RpcClientInstanceState::get().ensure_ignore_answer_requests_sent();
-
   k2::exit(static_cast<int32_t>(exit_code));
 }
 

runtime-light/stdlib/rpc/rpc-client-state.h

@@ -32,16 +32,6 @@ struct RpcClientInstanceState final : private vk::not_copyable {
   RpcClientInstanceState() noexcept = default;
 
   static RpcClientInstanceState& get() noexcept;
-
-  kphp::coro::task<void> ensure_ignore_answer_requests_sent() noexcept {
-    while (!ignore_answer_awaiter_tasks.empty()) {
-      const auto it_ignore_answer_awaiter{ignore_answer_awaiter_tasks.begin()};
-      const auto& [query_id, awaiter_task]{*it_ignore_answer_awaiter};
-
-      ignore_answer_awaiter_tasks.erase(it_ignore_answer_awaiter);
-      co_await awaiter_task.when_ready();
-    }
-  }
 };
 
 // ================================================================================================