From ad716ac899fac1dda34a7ac5dc5ae6c0eaca1263 Mon Sep 17 00:00:00 2001 From: urrsk <41109954+urrsk@users.noreply.github.com> Date: Wed, 18 Mar 2026 11:42:44 +0100 Subject: [PATCH 1/2] Update gtest to fix MacOS build warnings Enabled warnings as errors for the MacOS build as well --- .github/workflows/mac-build.yml | 2 +- tests/CMakeLists.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/mac-build.yml b/.github/workflows/mac-build.yml index 7c4bf40cf..a5c940b49 100644 --- a/.github/workflows/mac-build.yml +++ b/.github/workflows/mac-build.yml @@ -25,7 +25,7 @@ jobs: steps: - uses: actions/checkout@v6 - name: configure - run: mkdir build && cd build && cmake .. -DBUILDING_TESTS=1 -DCMAKE_BUILD_TYPE=Debug -DCMAKE_OSX_ARCHITECTURES=${{ matrix.arch }} + run: mkdir build && cd build && cmake .. -DBUILDING_TESTS=1 -DCMAKE_BUILD_TYPE=Debug -DCMAKE_COMPILE_WARNING_AS_ERROR=ON -DCMAKE_OSX_ARCHITECTURES=${{ matrix.arch }} - name: build run: cmake --build build - name: test diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt index 99db15ba2..593f50f13 100644 --- a/tests/CMakeLists.txt +++ b/tests/CMakeLists.txt @@ -8,7 +8,7 @@ include(FetchContent) FetchContent_Declare( googletest GIT_REPOSITORY https://github.com/google/googletest.git - GIT_TAG v1.15.2 + GIT_TAG v1.17.0 ) # For Windows: Prevent overriding the parent project's compiler/linker settings set(gtest_force_shared_crt ON CACHE BOOL "" FORCE) From 2b362d1aa94f5eb42e29ca39e2d4e79d2f944c39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rune=20S=C3=B8e-Knudsen?= <41109954+urrsk@users.noreply.github.com> Date: Wed, 18 Mar 2026 13:58:38 +0100 Subject: [PATCH 2/2] Update .github/workflows/mac-build.yml Co-authored-by: Felix Exner --- .github/workflows/mac-build.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/mac-build.yml b/.github/workflows/mac-build.yml index a5c940b49..a90b0d3b1 100644 --- a/.github/workflows/mac-build.yml +++ b/.github/workflows/mac-build.yml @@ -25,7 +25,13 @@ jobs: steps: - uses: actions/checkout@v6 - name: configure - run: mkdir build && cd build && cmake .. -DBUILDING_TESTS=1 -DCMAKE_BUILD_TYPE=Debug -DCMAKE_COMPILE_WARNING_AS_ERROR=ON -DCMAKE_OSX_ARCHITECTURES=${{ matrix.arch }} + run: > + mkdir build && cd build && + cmake .. + -DBUILDING_TESTS=1 + -DCMAKE_BUILD_TYPE=Debug + -DCMAKE_COMPILE_WARNING_AS_ERROR=ON + -DCMAKE_OSX_ARCHITECTURES=${{ matrix.arch }} - name: build run: cmake --build build - name: test