trunk shadow changes: com.unity.netcode.gameobjects (#4120)

* Updated changelog and package version for Netcode in anticipation of v2.13.1 release

* typo in build automation

* trunk shadow changes: com.unity.netcode.gameobjects [skip ci]

* Revert CHANGELOG changes

* Added UNITY_TEST_FRAMEWORK_1_7_OR_NEWER guard and UnityCoreClrExplicitDisabledAttributeShim.cs to make attribute usage possible

* corrected svc bot exclusion

---------

Co-authored-by: netcode-automation <svc-netcode-sdk@unity3d.com>
Co-authored-by: Michał Chrobot <michal.chrobot@unity3d.com>
Co-authored-by: PETS automation <299490404+pets-svc[bot]@users.noreply.github.com>
Co-authored-by: Emma <emma.mcmillan@unity3d.com>

Author: 4 people

.github/workflows/pr-description-validation.yml

@@ -34,7 +34,7 @@ jobs:
             // This should be automations where we don't care that much about the description format
             const skipUserPatterns = [
               /^unity-renovate/,
-              /(^|-)svc(-|$)/
+              /svc/
             ];
 
             // If PR author matches the skip list, exit early

Tools/scripts/BuildAutomation/manifest_update.py

@@ -51,7 +51,7 @@ def main():
         # Extract the version, providing a default if not found
         local_package_version = local_package_data.get('version', 'N/A')
 
-        print(f"--> Verified local '{args.package-name}' version is: {local_package_version}")
+        print(f"--> Verified local '{args.package_name}' version is: {local_package_version}")
 
     except FileNotFoundError:
         print(f"Warning: Could not find package.json at '{local_package_json_path}'")

com.unity.netcode.gameobjects/Tests/Runtime/DistributedAuthority/DeferredDespawningTests.cs

@@ -53,6 +53,7 @@ protected override void OnServerAndClientsCreated()
 
 
         [UnityTest]
+        [UnityCoreClrExplicitDisabled("https://jira.unity3d.com/browse/UUM-149592", "NGO NetworkVariable serialization codegen not generated for some types on CoreCLR (falls back to FallbackSerializer)")]
         public IEnumerator DeferredDespawning()
         {
             // Setup for test

com.unity.netcode.gameobjects/Tests/Runtime/DistributedAuthority/NetworkClientAndPlayerObjectTests.cs

@@ -155,6 +155,7 @@ private bool AllNetworkClientsValidated()
         /// Validates the same thing when a client late joins and when a client disconnects.
         /// </summary>
         [UnityTest]
+        [UnityCoreClrExplicitDisabled("https://jira.unity3d.com/browse/UUM-149595", "ValidateNetworkClients throws duplicate-key ArgumentException on CoreCLR (DAHost)")]
         public IEnumerator ValidateNetworkClients()
         {
             // Validate the initial clients created

com.unity.netcode.gameobjects/Tests/Runtime/DocumentationCodeSamples/Configuration/SinglePlayerSessions.cs

@@ -151,6 +151,7 @@ protected override void OnNewClientCreated(NetworkManager networkManager)
         }
 
         [UnityTest]
+        [UnityCoreClrExplicitDisabled("https://jira.unity3d.com/browse/UUM-149592", "NGO NetworkVariable serialization codegen not generated for some types on CoreCLR (falls back to FallbackSerializer)")]
         public IEnumerator SwitchTransportTest()
         {
             var authority = GetAuthorityNetworkManager();

com.unity.netcode.gameobjects/Tests/Runtime/DocumentationCodeSamples/NetworkVariable/CustomSerializationDocsTests.cs

@@ -173,6 +173,7 @@ private bool ValidateAllAreEqual(StringBuilder errorLog)
         }
 
         [UnityTest]
+        [UnityCoreClrExplicitDisabled("https://jira.unity3d.com/browse/UUM-149592", "NGO NetworkVariable serialization codegen not generated for some types on CoreCLR (falls back to FallbackSerializer)")]
         public IEnumerator TestHealthCode()
         {
             var authority = GetAuthorityNetworkManager();

com.unity.netcode.gameobjects/Tests/Runtime/NetworkObject/NetworkObjectSynchronizationTests.cs

@@ -94,6 +94,7 @@ protected override void OnNewClientCreated(NetworkManager networkManager)
         }
 
         [UnityTest]
+        [UnityCoreClrExplicitDisabled("https://jira.unity3d.com/browse/UUM-149591", "NGO multi-instance test sessions fail to start/connect or time out on CoreCLR")]
         public IEnumerator NetworkObjectDeserializationFailure()
         {
             m_CurrentLogLevel = LogLevel.Nothing;
@@ -277,6 +278,7 @@ private void ValidateNetworkBehaviourWithNetworkVariables(NetworkObject authorit
         /// will still be initialized properly
         /// </summary>
         [UnityTest]
+        [UnityCoreClrExplicitDisabled("https://jira.unity3d.com/browse/UUM-149591", "NGO multi-instance test sessions fail to start/connect or time out on CoreCLR")]
         public IEnumerator NetworkBehaviourSynchronization()
         {
             var authority = GetAuthorityNetworkManager();
@@ -319,6 +321,7 @@ public IEnumerator NetworkBehaviourSynchronization()
         /// A basic validation for the NetworkBehaviour.OnSynchronize method
         /// </summary>
         [UnityTest]
+        [UnityCoreClrExplicitDisabled("https://jira.unity3d.com/browse/UUM-149591", "NGO multi-instance test sessions fail to start/connect or time out on CoreCLR")]
         public IEnumerator NetworkBehaviourOnSynchronize()
         {
             var authority = GetAuthorityNetworkManager();

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkListTests.cs

@@ -244,6 +244,7 @@ void TestForceUpdateCallback(NetworkListEvent<int> _)
 
         // don't extend this please
         [UnityTest]
+        [UnityCoreClrExplicitDisabled("https://jira.unity3d.com/browse/UUM-149592", "NGO NetworkVariable serialization codegen not generated for some types on CoreCLR (falls back to FallbackSerializer)")]
         public IEnumerator LegacyPredicateTesting()
         {
             var authority = GetAuthorityNetworkManager();

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkVariableAnticipationTests.cs

@@ -3,6 +3,7 @@
 using NUnit.Framework;
 using Unity.Netcode.TestHelpers.Runtime;
 using UnityEngine;
+using UnityEngine.TestTools;
 
 namespace Unity.Netcode.RuntimeTests
 {
@@ -58,6 +59,7 @@ public void SetReanticipateValueRpc(float f)
         }
     }
 
+    [UnityCoreClrExplicitDisabled("https://jira.unity3d.com/browse/UUM-149591", "NGO multi-instance test sessions fail to start/connect or time out on CoreCLR")]
     internal class NetworkVariableAnticipationTests : NetcodeIntegrationTest
     {
         protected override int NumberOfClients => 2;

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkVariableCollectionsChangingTests.cs

@@ -17,6 +17,7 @@ namespace Unity.Netcode.RuntimeTests
     [TestFixture(HostOrServer.Host, CollectionTypes.Dictionary)]
     [TestFixture(HostOrServer.Server, CollectionTypes.List)]
     [TestFixture(HostOrServer.Server, CollectionTypes.Dictionary)]
+    [UnityCoreClrExplicitDisabled("https://jira.unity3d.com/browse/UUM-149592", "NGO NetworkVariable serialization codegen not generated for some types on CoreCLR (falls back to FallbackSerializer)")]
     internal class NetworkVariableCollectionsChangingTests : NetcodeIntegrationTest
     {
         protected override int NumberOfClients => 2;