Skip to content

Commit 6f7964d

Browse files
authored
feat: update SonarCloud analysis job to wait for unit tests and improve workflow clarity (#172)
1 parent 797aa2e commit 6f7964d

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/frontend-pr-workflow.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,10 +396,11 @@ jobs:
396396
- name: Print GitHub SHA
397397
run: echo "The commit SHA is ${{ github.sha }}"
398398

399-
# Job 5: SonarCloud Analysis (runs immediately, parallel with build and tests)
399+
# Job 5: SonarCloud Analysis (waits for unit tests if enabled, otherwise runs immediately)
400400
sonarcloud:
401401
name: 🔍 SonarCloud
402402
if: inputs.run-sonarcloud
403+
needs: [build, unit-tests]
403404
permissions:
404405
contents: read
405406
uses: Typeform/.github/.github/workflows/sonarcloud-scan.yml@v1

0 commit comments

Comments
 (0)