Proposal
There are some functions in TransformerLens where position and keyed arguments are allowed for the purpose of passing down to other functions. model_args should be removed in favor of model_kwargs.
Motivation
Having the two together is only really adding some confusion. On top of that, we cannot change the order of params without causing subtle issues that many people may not even notice.
Pitch
We can keep model_kwargs, since that one is going to give us a much better compatibility, and it will help make the code more verbose.
Alternatives
Additional context
Checklist
Proposal
There are some functions in TransformerLens where position and keyed arguments are allowed for the purpose of passing down to other functions.
model_argsshould be removed in favor ofmodel_kwargs.Motivation
Having the two together is only really adding some confusion. On top of that, we cannot change the order of params without causing subtle issues that many people may not even notice.
Pitch
We can keep
model_kwargs, since that one is going to give us a much better compatibility, and it will help make the code more verbose.Alternatives
Additional context
Checklist