Skip to content

[Proposal] Remove instances where model_args and model_kwargs are provided #798

Description

@bryce13950

Proposal

There are some functions in TransformerLens where position and keyed arguments are allowed for the purpose of passing down to other functions. model_args should be removed in favor of model_kwargs.

Motivation

Having the two together is only really adding some confusion. On top of that, we cannot change the order of params without causing subtle issues that many people may not even notice.

Pitch

We can keep model_kwargs, since that one is going to give us a much better compatibility, and it will help make the code more verbose.

Alternatives

Additional context

Checklist

  • I have checked that there is no similar issue in the repo (required)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions