Create real sprite asset handoff from Objects render selection - PR_26161_003-object-render-asset-handoff

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -1,25 +1,32 @@
 # git status --short
-M docs_build/dev/reports/coverage_changed_js_guardrail.txt
+M docs_build/dev/reports/codex_changed_files.txt
+ M docs_build/dev/reports/codex_review.diff
+ M docs_build/dev/reports/coverage_changed_js_guardrail.txt
  M docs_build/dev/reports/playwright_v8_coverage_report.txt
+ M src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
+ M src/engine/object-model/objectDefinitionSchema.js
+ M src/engine/object-model/objectDefinitionValidator.js
+ M src/engine/object-model/objectModelRegistry.js
+ M tests/engine/ObjectModelContract.test.mjs
  M tests/playwright/tools/ObjectsTool.spec.mjs
  M toolbox/objects/index.html
  M toolbox/objects/objects.js
-?? docs_build/dev/reports/db-object-model-contract-report.md
-?? src/engine/object-model/
-?? tests/engine/ObjectModelContract.test.mjs
+?? docs_build/dev/reports/object-render-asset-handoff-report.md
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/db-object-model-contract-report.md
-src/engine/object-model/index.js
-src/engine/object-model/objectDefinitionSchema.js
-src/engine/object-model/objectDefinitionValidator.js
-src/engine/object-model/objectModelRegistry.js
-tests/engine/ObjectModelContract.test.mjs
+docs_build/dev/reports/object-render-asset-handoff-report.md
 
 # git diff --stat
-.../dev/reports/coverage_changed_js_guardrail.txt  |   6 +-
- .../dev/reports/playwright_v8_coverage_report.txt  |  34 ++--
- tests/playwright/tools/ObjectsTool.spec.mjs        |   7 +
- toolbox/objects/index.html                         |  15 +-
- toolbox/objects/objects.js                         | 179 +++++++++++++++++----
- 5 files changed, 185 insertions(+), 56 deletions(-)
+docs_build/dev/reports/codex_changed_files.txt     |   32 +-
+ docs_build/dev/reports/codex_review.diff           | 1990 +++++++++-----------
+ .../dev/reports/coverage_changed_js_guardrail.txt  |   12 +-
+ .../dev/reports/playwright_v8_coverage_report.txt  |   33 +-
+ .../tool-repositories/assets-mock-repository.js    |  179 ++
+ src/engine/object-model/objectDefinitionSchema.js  |   14 +
+ .../object-model/objectDefinitionValidator.js      |  103 +
+ src/engine/object-model/objectModelRegistry.js     |    8 -
+ tests/engine/ObjectModelContract.test.mjs          |   36 +-
+ tests/playwright/tools/ObjectsTool.spec.mjs        |   66 +-
+ toolbox/objects/index.html                         |   21 +-
+ toolbox/objects/objects.js                         |  147 +-
+ 12 files changed, 1473 insertions(+), 1168 deletions(-)

docs_build/dev/reports/codex_review.diff

@@ -6,12 +6,12 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(67%) src/engine/object-model/objectModelRegistry.js - executed lines 146/146; executed functions 4/6
-(70%) src/engine/object-model/objectDefinitionValidator.js - executed lines 269/269; executed functions 14/20
-(75%) src/engine/object-model/objectDefinitionSchema.js - executed lines 44/44; executed functions 3/4
-(94%) toolbox/objects/objects.js - executed lines 466/466; executed functions 58/62
+(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(67%) src/engine/object-model/objectModelRegistry.js - executed lines 139/139; executed functions 4/6
+(74%) src/engine/object-model/objectDefinitionValidator.js - executed lines 360/360; executed functions 17/23
+(75%) src/engine/object-model/objectDefinitionSchema.js - executed lines 58/58; executed functions 3/4
+(96%) toolbox/objects/objects.js - executed lines 590/590; executed functions 68/71
 (100%) src/engine/object-model/index.js - executed lines 29/29; executed functions 1/1
 
 Guardrail warnings:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -0,0 +1,77 @@
+# PR_26161_003 Object Render Asset Handoff Report
+
+## Branch Guard
+
+- Current branch: `main`
+- Expected branch: `main`
+- Local branches found: `* main`
+- Branch validation: PASS
+
+## Scope Result
+
+- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before edits.
+- PASS: Continued the PR_26161_002 object-model migration without restoring legacy `objectStatic` / `objectDynamic` / `objectKillable` classes.
+- PASS: Removed `bounces` from object identity traits. Bounce remains a future behavior/physics/event configuration concern.
+- PASS: Added object definition render config schema/validation for `None` and `Sprite`.
+- PASS: Wired Objects to the shared object-model registry and shared asset repository contract instead of owning duplicate sprite asset records.
+- PASS: Added Render Type = Sprite handoff that creates or resolves a real mock-adapter asset row named from the object key, for example `sprite_ball`.
+- PASS: Linked the object render config to the returned sprite asset key and shared asset preview path.
+- PASS: Objects shows the linked sprite key/path and an Edit Sprite route with `assetKey`, `objectKey`, and `sourceTool=objects` query context.
+- PASS: Missing sprite assets create a minimal editable default sprite asset record with visible status diagnostics.
+- PASS: No fake `placeholder` asset key/concept and no `imageDataUrl` were introduced.
+- PASS: Object ownership stays in Objects; sprite content ownership stays with Assets/Sprite Editor.
+- PASS: No sample JSON alignment, auth behavior, production DB behavior, or unrelated tool rewrites were added.
+- PASS: Toolbox/Admin tool metadata was not changed.
+
+## Implementation Evidence
+
+- `src/engine/object-model/objectModelRegistry.js`: removed `bounces` trait registration.
+- `src/engine/object-model/objectDefinitionSchema.js`: added declared render config shape.
+- `src/engine/object-model/objectDefinitionValidator.js`: added actionable render validation diagnostics.
+- `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js`: added mock-adapter `ensureSpriteAssetForObject` create/resolve support for sprite assets.
+- `toolbox/objects/index.html`: added Render Type input, Render Asset column, linked sprite preview, and Edit Sprite action using Theme V2 markup only.
+- `toolbox/objects/objects.js`: requests shared sprite assets, stores linked render config, logs warnings, and displays preview/action state.
+- `tests/engine/ObjectModelContract.test.mjs`: validates no `bounces` object trait and sprite render asset-key validation.
+- `tests/playwright/tools/ObjectsTool.spec.mjs`: validates sprite render selection creating/resolving `sprite_ball`, DB row evidence, no placeholder key, and no visible `bounces` trait.
+
+## Validation
+
+- PASS: Changed-file syntax checks:
+  - `node --check src/engine/object-model/objectModelRegistry.js`
+  - `node --check src/engine/object-model/objectDefinitionSchema.js`
+  - `node --check src/engine/object-model/objectDefinitionValidator.js`
+  - `node --check src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js`
+  - `node --check toolbox/objects/objects.js`
+  - `node --check tests/engine/ObjectModelContract.test.mjs`
+  - `node --check tests/playwright/tools/ObjectsTool.spec.mjs`
+- PASS: HTML restrictions check:
+  - Node assertion confirmed `toolbox/objects/index.html` has no inline `<script>` block, no `<style>` block, and no inline event handlers.
+- PASS: Targeted object-model validator test:
+  - `node tests/engine/ObjectModelContract.test.mjs`
+- PASS: Targeted Objects Playwright:
+  - `npx playwright test tests/playwright/tools/ObjectsTool.spec.mjs --reporter=line`
+  - Final result: 3 passed.
+  - Note: the first Playwright run exposed that Game Configuration readiness was being treated as a hard block for the sprite mock asset handoff. The final implementation records it as a visible warning when an active project path exists, and the final targeted run passed.
+- PASS: Playwright V8 coverage produced:
+  - `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+  - Browser-covered changed runtime JS includes `toolbox/objects/objects.js`, object-model schema/registry/validator, and shared object-model index.
+  - WARN: `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js` is server-side dev-runtime code and is not collected by browser V8 coverage.
+
+## Skipped Lanes
+
+- SKIP: Toolbox/Admin metadata Playwright. Safe to skip because no Toolbox/Admin metadata changed.
+- SKIP: Sprite Editor launch/handoff validation. Safe to skip because no Sprite Editor/Sprites files changed; Objects Playwright validates the routed `assetKey`/`objectKey`/`sourceTool` href context.
+- SKIP: Full samples validation. Safe to skip because sample JSON alignment was explicitly out of scope and no sample files changed.
+- SKIP: Full test suite. Safe to skip because this PR changed the targeted object-model contract, dev mock asset repository handoff, and Objects tool surface only; requested targeted lanes passed.
+
+## Remaining Follow-Up
+
+- Bounce/rebound configuration should be added later under behavior, physics, or event configuration contracts. It must not return as an object identity trait.
+- Sprite Editor content editing remains owned by the Sprite Editor/Sprites tool; this PR only provides the linked asset context and shared asset record handoff.
+
+## Required Artifacts
+
+- PASS: `docs_build/dev/reports/object-render-asset-handoff-report.md`
+- PASS: `docs_build/dev/reports/codex_review.diff`
+- PASS: `docs_build/dev/reports/codex_changed_files.txt`
+- PASS: `docs_build/dev/reports/playwright_v8_coverage_report.txt`

docs_build/dev/reports/object-render-asset-handoff-report.md

@@ -12,40 +12,39 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(88%) Toolbox Index - exercised 2 runtime JS files
+(89%) Toolbox Index - exercised 3 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(67%) src/engine/object-model/objectModelRegistry.js - executed lines 146/146; executed functions 4/6
-(70%) src/engine/object-model/objectDefinitionValidator.js - executed lines 269/269; executed functions 14/20
-(75%) src/engine/object-model/objectDefinitionSchema.js - executed lines 44/44; executed functions 3/4
-(94%) toolbox/objects/objects.js - executed lines 466/466; executed functions 58/62
+(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(67%) src/engine/object-model/objectModelRegistry.js - executed lines 139/139; executed functions 4/6
+(74%) src/engine/object-model/objectDefinitionValidator.js - executed lines 360/360; executed functions 17/23
+(75%) src/engine/object-model/objectDefinitionSchema.js - executed lines 58/58; executed functions 3/4
+(96%) toolbox/objects/objects.js - executed lines 590/590; executed functions 68/71
 (100%) src/engine/object-model/index.js - executed lines 29/29; executed functions 1/1
 
 Files with executed line/function counts where available:
-(36%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 5/14
+(53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
 (58%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 603/603; executed functions 30/52
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
-(67%) src/engine/object-model/objectModelRegistry.js - executed lines 146/146; executed functions 4/6
-(70%) src/engine/object-model/objectDefinitionValidator.js - executed lines 269/269; executed functions 14/20
-(75%) src/engine/object-model/objectDefinitionSchema.js - executed lines 44/44; executed functions 3/4
+(67%) src/engine/object-model/objectModelRegistry.js - executed lines 139/139; executed functions 4/6
+(67%) toolbox/assets/assets-api-client.js - executed lines 17/17; executed functions 2/3
+(74%) src/engine/object-model/objectDefinitionValidator.js - executed lines 360/360; executed functions 17/23
+(75%) src/engine/object-model/objectDefinitionSchema.js - executed lines 58/58; executed functions 3/4
 (75%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 21/28
-(94%) toolbox/objects/objects.js - executed lines 466/466; executed functions 58/62
+(96%) toolbox/objects/objects.js - executed lines 590/590; executed functions 68/71
 (100%) src/engine/object-model/index.js - executed lines 29/29; executed functions 1/1
 
 Uncovered or low-coverage changed JS files:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
 
 Changed JS files considered:
-(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - changed JS file not collected as browser runtime coverage
 (0%) tests/engine/ObjectModelContract.test.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/ObjectsTool.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/RootToolsFutureState.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs - changed JS file not collected as browser runtime coverage
 (67%) src/engine/object-model/objectModelRegistry.js - changed JS file with browser V8 coverage
-(70%) src/engine/object-model/objectDefinitionValidator.js - changed JS file with browser V8 coverage
+(74%) src/engine/object-model/objectDefinitionValidator.js - changed JS file with browser V8 coverage
 (75%) src/engine/object-model/objectDefinitionSchema.js - changed JS file with browser V8 coverage
-(94%) toolbox/objects/objects.js - changed JS file with browser V8 coverage
+(96%) toolbox/objects/objects.js - changed JS file with browser V8 coverage
 (100%) src/engine/object-model/index.js - changed JS file with browser V8 coverage