Restore DB source palettes and remove user colors on unpin - PR_26156_173-palette-source-list-and-unpin-delete

Author: ToolboxAid

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -6,7 +6,7 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(86%) toolbox/colors/palette-workspace-repository.js - executed lines 1103/1103; executed functions 107/124
+(87%) toolbox/colors/palette-workspace-repository.js - executed lines 1118/1118; executed functions 110/127
 (95%) toolbox/colors/colors.js - executed lines 745/745; executed functions 74/78
 (100%) toolbox/colors/palette-source-mock-db.js - executed lines 927/927; executed functions 6/6
 

docs_build/dev/reports/palette-source-list-and-unpin-delete-report.md

@@ -12,12 +12,14 @@ PASS
 - Ensured active user palette removal updates the mock DB `palette_colors` table, count, and selected state.
 - Ensured active user palette removal does not remove source palette records.
 - Kept source pinning duplicate-safe.
+- Removed the selected/base color from Color Harmony Schemes output so harmony swatches only show distinct generated colors.
 
 ## Implementation Notes
 - Source palette records are provided by `toolbox/colors/palette-source-mock-db.js` and loaded by `createPaletteToolMockDbTables()`.
 - Source labels come from mock DB records, so dropdown labels render as `8-color set`, `16-color set`, `32-color set`, `W3C`, and `JavaScript`.
 - Palette options sort by label with numeric-aware ordering.
 - `repository.removeSwatch(symbol)` removes a specific active palette color and clears selection when the removed color was selected.
+- Harmony suggestions filter out the selected swatch RGB and renumber calculated labels after filtering.
 - The active palette pin indicator now receives pointer events through the existing reusable Theme V2 swatch pin pattern.
 
 ## Validation

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -17,16 +17,16 @@ Exercised tool entry points detected:
 (83%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(86%) toolbox/colors/palette-workspace-repository.js - executed lines 1103/1103; executed functions 107/124
+(87%) toolbox/colors/palette-workspace-repository.js - executed lines 1118/1118; executed functions 110/127
 (95%) toolbox/colors/colors.js - executed lines 745/745; executed functions 74/78
 (100%) toolbox/colors/palette-source-mock-db.js - executed lines 927/927; executed functions 6/6
 
 Files with executed line/function counts where available:
 (65%) toolbox/project-workspace/project-workspace-mock-repository.js - executed lines 402/402; executed functions 20/31
 (75%) toolbox/toolRegistry.js - executed lines 1754/1754; executed functions 27/36
 (80%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 205/205; executed functions 16/20
-(86%) toolbox/colors/palette-workspace-repository.js - executed lines 1103/1103; executed functions 107/124
 (87%) assets/theme-v2/js/tool-display-mode.js - executed lines 201/201; executed functions 13/15
+(87%) toolbox/colors/palette-workspace-repository.js - executed lines 1118/1118; executed functions 110/127
 (95%) toolbox/colors/colors.js - executed lines 745/745; executed functions 74/78
 (100%) toolbox/colors/palette-source-mock-db.js - executed lines 927/927; executed functions 6/6
 
@@ -35,6 +35,6 @@ Uncovered or low-coverage changed JS files:
 
 Changed JS files considered:
 (0%) tests/playwright/tools/PaletteToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
-(86%) toolbox/colors/palette-workspace-repository.js - changed JS file with browser V8 coverage
+(87%) toolbox/colors/palette-workspace-repository.js - changed JS file with browser V8 coverage
 (95%) toolbox/colors/colors.js - changed JS file with browser V8 coverage
 (100%) toolbox/colors/palette-source-mock-db.js - changed JS file with browser V8 coverage

docs_build/dev/reports/testing_lane_execution_report.md

@@ -36,6 +36,8 @@ PASS
 - Palette Colors count updates after add/remove: PASS.
 - Selected state clears when selected color is removed: PASS.
 - Source palette records remain available after active color removal: PASS.
+- Color Harmony Schemes does not render the selected/base swatch: PASS.
+- Harmony Add Selected and Add All continue from the remaining generated swatches: PASS.
 
 ## Impacted Lane
 - Palette Tool runtime/UI lane.

tests/playwright/tools/PaletteToolMockRepository.spec.mjs

@@ -263,7 +263,7 @@ test("Palette repository owns active project swatches without mutating invalid p
   expect(repository.createHarmonySuggestions(repository.findSwatch("R"), {
     matchSource: "calculated",
     schemeId: "triadic"
-  })).toHaveLength(3);
+  })).toHaveLength(2);
 
   repository.selectSwatch("R");
   repository.recordSwatchUsage({ assetId: "asset.color.red", symbol: "R", toolId: "assets" });
@@ -346,10 +346,9 @@ test("Palette Tool adds, updates, pins, validates, and shows project-owned detai
     await page.locator("[data-palette-source-pin-all]").click();
     await expect(page.locator("[data-palette-count]")).toHaveText("1");
     await expect(page.locator("[data-palette-log]")).toContainText("0 pinned, 1 already pinned");
-    await expect(page.locator("[data-palette-harmony-choice]")).toHaveCount(2);
+    await expect(page.locator("[data-palette-harmony-choice]")).toHaveCount(0);
     await expect(page.locator("[data-palette-harmony-list]")).not.toContainText(/Complementary \d:/);
-    await expect(page.locator("[data-palette-harmony-choice]").first()).toHaveAttribute("title", /^Scheme: Complementary\nLabel: Complementary 1\nHex: #[0-9A-F]{6}$/);
-    await expect(page.locator("[data-palette-harmony-choice]").first()).toHaveAttribute("aria-label", /Complementary 1 #[0-9A-F]{6} from Complementary/);
+    await expect(page.locator("[data-palette-harmony-list]")).toContainText("No harmony scheme colors available.");
     await page.locator("[data-palette-user-list] [data-palette-swatch-name='Black'] [data-palette-pin-indicator]").click();
     await expect(page.locator("[data-palette-count]")).toHaveText("0");
     await expect(page.locator("[data-palette-selected-summary]")).toHaveText("None");
@@ -410,8 +409,10 @@ test("Palette Tool adds, updates, pins, validates, and shows project-owned detai
     await expect(page.locator("[data-palette-selected-details]")).toHaveCount(0);
     await expect(page.locator("[data-palette-project-accordion]")).not.toContainText(/Symbol:|Hex:|Name:|Source:|Tags:/);
     await expect(page.locator("[data-palette-table-counts]")).toContainText("palette_colors");
-    await expect(page.locator("[data-palette-harmony-choice]")).toHaveCount(2);
+    await expect(page.locator("[data-palette-harmony-choice]")).toHaveCount(1);
     await expect(page.locator("[data-palette-harmony-list]")).not.toContainText(/Complementary \d:/);
+    await expect(page.locator("[data-palette-harmony-choice]").first()).toHaveAttribute("title", /^Scheme: Complementary\nLabel: Complementary 1\nHex: #[0-9A-F]{6}$/);
+    await expect(page.locator("[data-palette-harmony-choice]").first()).toHaveAttribute("aria-label", /Complementary 1 #[0-9A-F]{6} from Complementary/);
 
     const activePreviewTile = page.locator("[data-palette-swatch-row='H']");
     await page.locator("[data-palette-user-sort] [data-palette-sort-key='hue']").click();
@@ -461,7 +462,7 @@ test("Palette Tool adds, updates, pins, validates, and shows project-owned detai
     await expect(page.locator("[data-palette-log]")).toHaveText("Editor form cleared.");
 
     await page.locator("[data-palette-harmony-scheme]").selectOption("triadic");
-    await expect(page.locator("[data-palette-harmony-choice]")).toHaveCount(3);
+    await expect(page.locator("[data-palette-harmony-choice]")).toHaveCount(2);
     await expect(page.locator("[data-palette-harmony-list]")).not.toContainText(/Triadic \d:/);
     await expect(page.locator("[data-palette-harmony-choice='1']")).toHaveAttribute("title", /^Scheme: Triadic\nLabel: Triadic 2\nHex: #[0-9A-F]{6}$/);
     await expect(page.locator("[data-palette-harmony-choice='1']")).toHaveAttribute("aria-label", /Triadic 2 #[0-9A-F]{6} from Triadic/);

toolbox/colors/palette-workspace-repository.js

@@ -463,6 +463,22 @@ function uniqueSuggestions(suggestions) {
   });
 }
 
+function withoutBaseColorSuggestions(suggestions, baseHex, schemeLabel) {
+  let calculatedIndex = 0;
+  return suggestions
+    .filter((suggestion) => rgbKey(suggestion.hex) !== rgbKey(baseHex))
+    .map((suggestion) => {
+      if (suggestion.sourceName !== "Calculated") {
+        return suggestion;
+      }
+      calculatedIndex += 1;
+      return {
+        ...suggestion,
+        name: `${schemeLabel} ${calculatedIndex}`
+      };
+    });
+}
+
 function harmonyForSwatch(swatch, options = {}, sourcePaletteData = null) {
   const rgb = hexToRgb(swatch?.hex);
   if (!rgb) {
@@ -501,7 +517,7 @@ function harmonyForSwatch(swatch, options = {}, sourcePaletteData = null) {
     };
   });
 
-  return uniqueSuggestions(calculated);
+  return withoutBaseColorSuggestions(uniqueSuggestions(calculated), swatch.hex, scheme.label);
 }
 
 function nextAvailableSymbol(existingSwatches, seedText = "") {