Skip to content

Commit ce0fc8b

Browse files
committed
Merge PR #217 PR_26177_CHARLIE_008-environment-management-complete
# Conflicts: # docs_build/dev/reports/codex_changed_files.txt # docs_build/dev/reports/codex_review.diff
2 parents d9d6f89 + 39d4231 commit ce0fc8b

12 files changed

Lines changed: 448 additions & 511 deletions
Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
# PR_26177_CHARLIE_008-environment-management-complete
2+
3+
## Summary
4+
5+
Team Charlie completed the Environment Management closeout slice.
6+
7+
This PR keeps runtime behavior scoped to environment diagnostics and validation:
8+
9+
- Environment Banner diagnostics now expose the environment safeguard state.
10+
- DEV/UAT-style labels remain visible as non-production safeguards.
11+
- Production labels remain hidden by default.
12+
- Missing local environment labels produce the existing actionable danger banner.
13+
- Configurable Runtime Ports are marked deprecated/superseded instead of pending/open work.
14+
- Environment Banner Playwright coverage now targets an existing legal page.
15+
16+
## Changed Files
17+
18+
- `src/dev-runtime/server/local-api-router.mjs`
19+
- `tests/dev-runtime/AdminHealthOperations.test.mjs`
20+
- `tests/dev-runtime/PublicEnvironmentConfig.test.mjs`
21+
- `tests/playwright/tools/AdminHealthOperationsPage.spec.mjs`
22+
- `tests/playwright/tools/EnvironmentBannerCoverage.spec.mjs`
23+
- `docs_build/dev/reports/PR_26177_CHARLIE_008-environment-management-complete.md`
24+
- `docs_build/dev/reports/PR_26177_CHARLIE_008-environment-management-complete_branch-validation.md`
25+
- `docs_build/dev/reports/PR_26177_CHARLIE_008-environment-management-complete_manual-validation-notes.md`
26+
- `docs_build/dev/reports/PR_26177_CHARLIE_008-environment-management-complete_requirements-checklist.md`
27+
- `docs_build/dev/reports/PR_26177_CHARLIE_008-environment-management-complete_validation-lane.md`
28+
- `docs_build/dev/reports/codex_changed_files.txt`
29+
- `docs_build/dev/reports/codex_review.diff`
30+
31+
## Implementation Notes
32+
33+
- Added `environmentSafeguard`, `environmentLabelNormalized`, `environmentBannerSource`, and `environmentBannerTone` diagnostics to `/api/public/config`.
34+
- Preserved the existing Environment Banner rendering contract and Theme V2 partial flow.
35+
- Changed System Health Local API startup diagnostics for Configurable Runtime Ports from `PENDING/deferred/cancelled` to `PASS/deprecated/superseded`.
36+
- Corrected Environment Banner Playwright coverage from missing `/legal/disclaimer.html` to existing `/legal/privacy-policy.html`.
37+
- No UI content, API data ownership, database, or storage behavior changes were introduced.
38+
39+
## Validation
40+
41+
- PASS: `node --check src/dev-runtime/server/local-api-router.mjs`
42+
- PASS: `node --check tests/dev-runtime/PublicEnvironmentConfig.test.mjs`
43+
- PASS: `node --check tests/dev-runtime/AdminHealthOperations.test.mjs`
44+
- PASS: `node --check tests/playwright/tools/EnvironmentBannerCoverage.spec.mjs`
45+
- PASS: `node --test tests/dev-runtime/PublicEnvironmentConfig.test.mjs tests/dev-runtime/AdminHealthOperations.test.mjs tests/api/admin-system-health/contract.test.mjs`
46+
- PASS: `npx playwright test tests/playwright/tools/EnvironmentBannerCoverage.spec.mjs --workers=1`
47+
- PASS: `npx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs --workers=1`
48+
- PASS: `git diff --check`
49+
50+
## ZIP
51+
52+
- `tmp/PR_26177_CHARLIE_008-environment-management-complete_delta.zip`
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# PR_26177_CHARLIE_008 Branch Validation
2+
3+
## Branch
4+
5+
- Branch: `PR_26177_CHARLIE_008-environment-management-complete`
6+
- Start branch: `main`
7+
- Main start commit: `8cdd87bf2eb2b9c0625e80881f1d359e902fa8fc`
8+
9+
## Checks
10+
11+
| Check | Result | Notes |
12+
| --- | --- | --- |
13+
| Started from `main` | PASS | Branch was created after `main` was clean and synchronized. |
14+
| Worktree clean before branch work | PASS | Startup status check returned no changes. |
15+
| One PR purpose only | PASS | Environment management diagnostics/tests only. |
16+
| No `start_of_day` changes | PASS | Changed-file list contains no `start_of_day` paths. |
17+
| Environment Banner complete | PASS | DEV/UAT visible safeguards, production hidden, missing local label diagnostic covered. |
18+
| Configurable Runtime Ports not open work | PASS | System Health reports deprecated/superseded. |
19+
| No runtime data ownership regression | PASS | Browser remains a consumer of public config and System Health API contracts. |
20+
| Repo-structured ZIP created | PASS | `tmp/PR_26177_CHARLIE_008-environment-management-complete_delta.zip`. |
21+
22+
## Result
23+
24+
PASS
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# PR_26177_CHARLIE_008 Manual Validation Notes
2+
3+
## Manual Review
4+
5+
- Confirmed changed files are limited to environment diagnostics, targeted tests, and required reports.
6+
- Confirmed no `start_of_day` paths were modified.
7+
- Confirmed no inline styles, style blocks, script blocks, page-local CSS, or inline event handlers were introduced.
8+
- Confirmed no browser-owned authoritative product data was added.
9+
- Confirmed no secrets are exposed in public config diagnostics.
10+
11+
## Notes
12+
13+
- Environment Banner coverage previously referenced missing `/legal/disclaimer.html`; the targeted legal coverage route now uses existing `/legal/privacy-policy.html`.
14+
- DEV/custom labels and UAT labels render visible non-production banners.
15+
- Production labels are normalized to `PROD` diagnostics and hidden by default.
16+
- Configurable Runtime Ports are closed as deprecated/superseded and are not tracked as active work.
17+
18+
## Result
19+
20+
PASS
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# PR_26177_CHARLIE_008 Requirements Checklist
2+
3+
| Requirement | Result | Evidence |
4+
| --- | --- | --- |
5+
| Complete Environment Management from 90% to 100% | PASS | Environment safeguards and runtime-port closeout are explicit. |
6+
| Environment Banner complete | PASS | Public config diagnostics and Playwright banner coverage passed. |
7+
| Update reports/checklists accordingly | PASS | This report set contains branch validation, checklist, validation lane, manual notes, and shared diff/list artifacts. |
8+
| Mark Configurable Runtime Ports deprecated/superseded, not open work | PASS | Local API startup diagnostics now return `deprecated/superseded` with PASS. |
9+
| DEV/UAT/PROD environment safeguards | PASS | DEV/custom and UAT labels render visible safeguards; Production hides by default. |
10+
| Environment-aware diagnostics | PASS | `/api/public/config` reports normalized label and safeguard state. |
11+
| Final Charlie completion checklist | PASS | This checklist records the final Environment Management completion items. |
12+
| Targeted tests | PASS | Public config, Admin System Health, Environment Banner, and Admin System Health Playwright tests passed. |
13+
| No MEM DB/local-mem/fake-login/browser SSoT | PASS | No product-data ownership changes. |
14+
| No SQLite direction | PASS | No SQLite additions or terminology. |
15+
| Theme V2 rules | PASS | Existing Theme V2 partial flow preserved; no inline styles/scripts added. |
16+
17+
## Result
18+
19+
PASS
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# PR_26177_CHARLIE_008 Validation Lane
2+
3+
## Commands
4+
5+
| Command | Result |
6+
| --- | --- |
7+
| `node --check src/dev-runtime/server/local-api-router.mjs` | PASS |
8+
| `node --check tests/dev-runtime/PublicEnvironmentConfig.test.mjs` | PASS |
9+
| `node --check tests/dev-runtime/AdminHealthOperations.test.mjs` | PASS |
10+
| `node --check tests/playwright/tools/EnvironmentBannerCoverage.spec.mjs` | PASS |
11+
| `node --test tests/dev-runtime/PublicEnvironmentConfig.test.mjs tests/dev-runtime/AdminHealthOperations.test.mjs tests/api/admin-system-health/contract.test.mjs` | PASS, 10 tests |
12+
| `npx playwright test tests/playwright/tools/EnvironmentBannerCoverage.spec.mjs --workers=1` | PASS, 3 tests |
13+
| `npx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs --workers=1` | PASS, 3 tests |
14+
| `git diff --check` | PASS |
15+
16+
## Playwright
17+
18+
Impacted: Yes, Environment Banner diagnostics and System Health startup diagnostics changed.
19+
20+
Result: PASS.
21+
22+
## Full Samples Smoke
23+
24+
Not run. Not required for this targeted Environment Management PR.
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
docs_build/dev/reports/codex_changed_files.txt
22
docs_build/dev/reports/codex_review.diff
3-
docs_build/dev/reports/PR_26177_CHARLIE_007-runtime-configuration-complete.md
4-
docs_build/dev/reports/PR_26177_CHARLIE_007-runtime-configuration-complete_branch-validation.md
5-
docs_build/dev/reports/PR_26177_CHARLIE_007-runtime-configuration-complete_manual-validation-notes.md
6-
docs_build/dev/reports/PR_26177_CHARLIE_007-runtime-configuration-complete_requirements-checklist.md
7-
docs_build/dev/reports/PR_26177_CHARLIE_007-runtime-configuration-complete_validation-lane.md
8-
scripts/start-local-api-server.mjs
3+
docs_build/dev/reports/PR_26177_CHARLIE_008-environment-management-complete.md
4+
docs_build/dev/reports/PR_26177_CHARLIE_008-environment-management-complete_branch-validation.md
5+
docs_build/dev/reports/PR_26177_CHARLIE_008-environment-management-complete_manual-validation-notes.md
6+
docs_build/dev/reports/PR_26177_CHARLIE_008-environment-management-complete_requirements-checklist.md
7+
docs_build/dev/reports/PR_26177_CHARLIE_008-environment-management-complete_validation-lane.md
98
src/dev-runtime/server/local-api-router.mjs
10-
src/dev-runtime/storage/storage-config.mjs
119
tests/dev-runtime/AdminHealthOperations.test.mjs
12-
tests/dev-runtime/LocalApiStartupLogging.test.mjs
13-
tests/dev-runtime/StorageConfig.test.mjs
10+
tests/dev-runtime/PublicEnvironmentConfig.test.mjs
11+
tests/playwright/tools/AdminHealthOperationsPage.spec.mjs
12+
tests/playwright/tools/EnvironmentBannerCoverage.spec.mjs

0 commit comments

Comments
 (0)