Complete final migration done check without blocking on ignored review artifacts - PR_26154_051-final-done-check-no-review-artifact-blocker

Author: ToolboxAid

README.md

@@ -30,7 +30,7 @@ This repository follows a docs-first game/runtime model, combining a stable engi
 
 1. Review the repo model in [docs/README.md](docs/README.md)
 2. Explore the roadmap in [docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE.md](docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE.md)
-3. Browse deprecated reference samples from [old_samples/index.html](old_samples/index.html)
+3. Browse archived reference samples from [archive/v1-v2/samples/index.html](archive/v1-v2/samples/index.html)
 4. Explore tools under [toolbox/](toolbox/)
 5. Review engine and architecture boundaries in [docs/architecture/](docs/architecture/)
 6. Follow the workflow in [docs_build/dev/](docs_build/dev/) and [docs_build/pr/](docs_build/pr/)

docs_build/dev/codex_commands.md

@@ -31,3 +31,26 @@ Required reports:
 - `docs_build/dev/reports/archive_policy_final_alignment_report.md`
 - `docs_build/dev/reports/legacy_alias_removal_closeout_report.md`
 - `docs_build/dev/reports/migration_done_status_report.md`
+
+## PR_26154_051
+
+Changes:
+- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Ran final active-path checks for `tools/`, `samples/`, `old-tools`, `old_games`, `old_samples`, `assets/theme/v2`, `src/engine/theme`, `favicon.ico`, and `styles.css`.
+- Ignored `archive/v1-v2/`, `tmp/`, and generated review artifacts for active stale-path classification.
+- Fixed the remaining active README reference from `old_samples/index.html` to `archive/v1-v2/samples/index.html`.
+- Generated local review artifacts when possible and documented their handling.
+- Created the repo-structured delta ZIP at `tmp/PR_26154_051-final-done-check-no-review-artifact-blocker_delta.zip`.
+
+Validation:
+- Targeted active-path reference checks.
+- `git diff --check`
+- `node --check playwright.config.cjs`
+- UTF-8/read validation for changed Markdown, text, and JS/CJS files.
+- `npm run test:workspace-v2` skipped because active toolbox launch/navigation/runtime behavior did not change.
+- Full samples smoke test skipped per request.
+- Tests against `archive/v1-v2/` skipped per request.
+
+Required reports:
+- `docs_build/dev/reports/final_done_check_report.md`
+- `docs_build/dev/reports/review_artifact_handling_report.md`

docs_build/dev/commit_comment.txt

@@ -1 +1 @@
-Finalize active toolbox registry, archive SpriteEditor reference material, and remove legacy root aliases - PR_26154_048-050-toolbox-registry-archive-alias-closeout
+Run final stale-path done check and document non-blocking review artifact handling - PR_26154_051-final-done-check-no-review-artifact-blocker

docs_build/dev/reports/final_done_check_report.md

@@ -0,0 +1,65 @@
+# PR_26154_051 Final Done Check Report
+
+## Scope
+- Final active-path done check for PR_26154_051-final-done-check-no-review-artifact-blocker.
+- Source of truth read first: `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Baseline used: PR_26154_048-050-toolbox-registry-archive-alias-closeout.
+- Ignored historical/reference content under `archive/v1-v2/`.
+- Ignored generated/local output under `tmp/`.
+
+## Baseline State
+- Pre-existing unrelated working tree change found before PR_051 edits:
+  - `playwright.config.cjs`: `slowMo` changed from `50` to `5`.
+- That Playwright config change was left untouched.
+
+## Directory Existence Check
+All stale root/public paths requested for final verification are absent as folders/files:
+
+| Path | Exists |
+| --- | --- |
+| `tools/` | No |
+| `samples/` | No |
+| `old-tools` | No |
+| `old_games` | No |
+| `old_samples` | No |
+| `assets/theme/v2` | No |
+| `src/engine/theme` | No |
+| `favicon.ico` | No |
+| `styles.css` | No |
+
+## Active Reference Check
+Targeted reference checks were run outside `archive/v1-v2/`, `tmp/`, `node_modules/`, `.git/`, and `start_of_day/`.
+
+| Pattern | Active result |
+| --- | --- |
+| `tools/` | No stale active root-tool links found. Remaining hits are allowed non-root contexts such as `assets/theme-v2/images/tools/`, `assets/theme-v2/css/tools/`, `src/shared/schemas/tools/`, `src/shared/contracts/tools/`, and active test folder names. |
+| `samples/` | One active stale README reference was found through `old_samples/index.html` and fixed. Remaining hits are allowed schema/test or historical validation contexts. |
+| `old-tools` | No active hits found. |
+| `old_games` | No active hits found. |
+| `old_samples` | Fixed the root README hit. No active hits remain outside historical/report artifacts. |
+| `assets/theme/v2` | No active hits found. |
+| `src/engine/theme` | No active page/runtime hits found. Remaining non-runtime references are generated or historical documentation/report evidence, including `tests/validation/samples.shared.boundaries.report.json`. |
+| `favicon.ico` | No active hits found. |
+| `styles.css` | No stale root `styles.css` file or active root reference found. Theme V2 still owns `assets/theme-v2/css/styles.css` as an aggregate file. |
+
+## Fix Applied
+- Updated `README.md` from:
+  - `old_samples/index.html`
+- To:
+  - `archive/v1-v2/samples/index.html`
+
+No runtime behavior was changed.
+
+## Validation
+- PASS: Targeted final active-path reference checks.
+- PASS: `git diff --check`.
+- PASS: `node --check playwright.config.cjs`.
+- PASS: UTF-8/read validation for changed Markdown, text, and JS/CJS files.
+- SKIPPED: `npm run test:workspace-v2` because no active toolbox launch/navigation/runtime behavior changed.
+- SKIPPED: Full samples smoke test per request.
+- SKIPPED: Tests against `archive/v1-v2/` per request.
+
+## Delta Package
+- Repo-structured delta ZIP produced at `tmp/PR_26154_051-final-done-check-no-review-artifact-blocker_delta.zip`.
+- The ZIP excludes `tmp/` itself and excludes the pre-existing unrelated `playwright.config.cjs` change.
+- Local review artifacts were generated successfully but skipped from repo/delta inclusion by `.gitignore`.

docs_build/dev/reports/review_artifact_handling_report.md

@@ -0,0 +1,18 @@
+# PR_26154_051 Review Artifact Handling Report
+
+## Request
+- Generate `codex_changed_files.txt` and `codex_review.diff` locally if possible.
+- Do not fail this PR if generated review artifacts are excluded from the repo/delta by ignore rules.
+- State whether review artifacts were generated locally, skipped by ignore rules, or unavailable.
+
+## Result
+- `docs_build/dev/reports/codex_changed_files.txt`: generated locally.
+- `docs_build/dev/reports/codex_review.diff`: generated locally.
+- Ignore-rule status: `.gitignore` blocks these generated artifact filenames:
+  - `.gitignore:26:codex_changed_files.txt`
+  - `.gitignore:28:codex_review.diff`
+- Inclusion status: generated locally, skipped by ignore rules, and treated as non-blocking for PR_051 handling.
+
+## Notes
+- The generated review diff reflects the current working tree at generation time.
+- A pre-existing unrelated `playwright.config.cjs` edit was present before PR_051 and is called out in the final done check report.

playwright.config.cjs

@@ -21,7 +21,7 @@ module.exports = {
   use: {
     headless: false,
     launchOptions: {
-      slowMo: 50
+      slowMo: 5
     },
     trace: "on"
   }