Separate physical controller inputs from game controls - PR_26162_046-controls-remove-physical-controller-actions

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -1,18 +1,20 @@
 # git status --short
-M account/user-controls-page.js
- M account/user-controls.html
- M docs_build/dev/reports/coverage_changed_js_guardrail.txt
+M docs_build/dev/reports/coverage_changed_js_guardrail.txt
  M docs_build/dev/reports/playwright_v8_coverage_report.txt
+ M src/engine/input/NormalizedInputRegistry.js
+ M tests/input/NormalizedInputRegistry.test.mjs
  M tests/playwright/tools/InputMappingV2Tool.spec.mjs
-?? docs_build/dev/reports/user-controls-input-capture-cleanup-report.md
+ M toolbox/controls/controls.js
+?? docs_build/dev/reports/controls-remove-physical-controller-actions-report.md
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/user-controls-input-capture-cleanup-report.md
+docs_build/dev/reports/controls-remove-physical-controller-actions-report.md
 
 # git diff --stat
-account/user-controls-page.js                      | 200 ++++++++++++++++++---
- account/user-controls.html                         |   3 -
- .../dev/reports/coverage_changed_js_guardrail.txt  |   9 +-
- .../dev/reports/playwright_v8_coverage_report.txt  |  27 ++-
- tests/playwright/tools/InputMappingV2Tool.spec.mjs |  41 ++++-
- 5 files changed, 230 insertions(+), 50 deletions(-)
+.../dev/reports/coverage_changed_js_guardrail.txt  |  7 +--
+ .../dev/reports/playwright_v8_coverage_report.txt  | 18 +++---
+ src/engine/input/NormalizedInputRegistry.js        | 12 ++--
+ tests/input/NormalizedInputRegistry.test.mjs       |  8 ++-
+ tests/playwright/tools/InputMappingV2Tool.spec.mjs | 55 ++++++++++++-----
+ toolbox/controls/controls.js                       | 69 ++++++++++++++++++----
+ 6 files changed, 121 insertions(+), 48 deletions(-)

docs_build/dev/reports/codex_review.diff

@@ -0,0 +1,86 @@
+# PR_26162_046 Controls Remove Physical Controller Actions
+
+## Branch Validation
+- PASS: Current branch is `main`.
+- Expected branch: `main`.
+- Evidence: `git status --short --branch` reported `## main...origin/main`.
+
+## Requirement Checklist
+- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before edits.
+- PASS: Verified branch is `main` before edits.
+- PASS: Continued from PR_26162_045.
+- PASS: Controls status remains Wireframe; tool metadata/status was not changed.
+- PASS: Controls data remains DB-backed through the shared DB/mock adapter only.
+- PASS: Toolbox > Controls no longer creates or edits game controls for `dpad.up`, `dpad.down`, `dpad.left`, `dpad.right`, `trigger.left`, or `trigger.right`.
+- PASS: Toolbox > Controls does not define physical controller inputs; `game_input_mappings` remains free of controller id/name and physical input fields.
+- PASS: Toolbox > Controls keeps only the requested game-level normalized controls:
+  `move.x-`, `move.x+`, `move.y-`, `move.y+`, `aim.x-`, `aim.x+`, `aim.y-`, `aim.y+`, `action.primary`, `action.secondary`, `action.tertiary`, `action.quaternary`, `action.confirm`, `action.cancel`, `action.pause`, `action.start`, `action.select`.
+- PASS: Account > User Controls keeps physical DPad and trigger rows available.
+- PASS: Account > User Controls default mappings support `DPad Up -> move.y-`, `DPad Down -> move.y+`, `DPad Left -> move.x-`, `DPad Right -> move.x+`, `Left Trigger -> action.primary`, and `Right Trigger -> action.secondary`.
+- PASS: Editable controller mappings, deadzone, invert, sensitivity, and controller naming are preserved.
+- PASS: Combo Controls wireframe remains in Toolbox > Controls.
+- PASS: Aim remains normalized axis controls in Game Controls and was not moved into Combo Controls.
+- PASS: No sample JSON alignment, auth behavior, production account system, or unrelated rewrites were added.
+
+## Changed Files
+- `toolbox/controls/controls.js`
+- `src/engine/input/NormalizedInputRegistry.js`
+- `tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+- `tests/input/NormalizedInputRegistry.test.mjs`
+- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
+- `docs_build/dev/reports/controls-remove-physical-controller-actions-report.md`
+
+## Impacted Lanes
+- Controls tool runtime lane.
+- Account/User Controls runtime lane.
+- Engine input normalization/default mapping lane.
+
+## Validation Performed
+- PASS: `node --check toolbox/controls/controls.js`
+- PASS: `node --check account/user-controls-page.js`
+- PASS: `node --check src/engine/input/NormalizedInputRegistry.js`
+- PASS: `node --check tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+- PASS: `node --check tests/input/NormalizedInputRegistry.test.mjs`
+- PASS: `node tests/input/NormalizedInputRegistry.test.mjs`
+- PASS: `npx playwright test tests/playwright/tools/InputMappingV2Tool.spec.mjs` passed 6/6.
+- PASS: `git diff --check`
+- PASS: `rg -n -P "<style|style\\s*=|\\son[a-z]+\\s*=" toolbox/controls/index.html toolbox/controls/controls.js account/user-controls.html account/user-controls-page.js` returned no matches.
+
+## Playwright Result
+- PASS: Toolbox > Controls renders 17 game-level normalized rows.
+- PASS: Toolbox > Controls table/list excludes `dpad.*`, `trigger.*`, `D-Pad`, `Trigger`, and `action.menu`.
+- PASS: Toolbox > Controls edit dropdown excludes `dpad.*`, `trigger.*`, and `action.menu`.
+- PASS: Toolbox > Controls still includes `aim.x-`, `aim.x+`, `aim.y-`, and `aim.y+`.
+- PASS: Combo Controls wireframe remains visible.
+- PASS: Account > User Controls keeps physical DPad and trigger rows.
+- PASS: Account > User Controls maps DPad and trigger defaults into movement/action normalized controls.
+- PASS: Profiles and mappings persist after reload.
+
+## V8 Coverage
+- PASS: `docs_build/dev/reports/playwright_v8_coverage_report.txt` refreshed from the targeted Playwright run.
+- PASS: `(93%) toolbox/controls/controls.js - changed JS file with browser V8 coverage`.
+- PASS: `(89%) src/engine/input/NormalizedInputRegistry.js - changed JS file with browser V8 coverage`.
+- PASS: `coverage_changed_js_guardrail.txt` reports no changed runtime JS coverage warnings.
+
+## Skipped Lanes
+- Full samples validation: SKIPPED per request. Safe to skip because this PR only changes Controls/User Controls input mapping behavior and a targeted shared input default contract; no sample JSON or sample runtime files changed.
+- Full repository test suite: SKIPPED. Safe to skip because targeted Controls/User Controls Playwright plus the targeted engine input registry test covered the changed behavior.
+- Workspace V2 broad lane: SKIPPED. Safe to skip because this PR did not change navigation, workspace launch contracts, or workspace persistence.
+
+## Samples Decision
+- Samples validation was not run, per request.
+
+## Manual Validation Steps
+1. Open `toolbox/controls/index.html`.
+2. Confirm Game Controls shows only the 17 game-level normalized rows and no DPad/trigger/action.menu rows.
+3. Edit a Game Controls row and confirm the Normalized Action dropdown excludes dpad/trigger/action.menu while keeping aim axes.
+4. Confirm Combo Controls still shows the wireframe text.
+5. Open `account/user-controls.html`.
+6. Create a game controller profile from a detected controller.
+7. Confirm DPad Up/Down/Left/Right rows are present and default to move directions.
+8. Confirm Trigger Left/Right rows are present and default to primary/secondary actions.
+9. Save, reload, and confirm mappings persist.
+
+## Notes
+- The global normalized registry still retains physical-controller-specific normalized identifiers for Account/User Controls compatibility, but Toolbox > Controls filters them out and cleans stale game-control records from the shared mock DB when encountered.

docs_build/dev/reports/controls-remove-physical-controller-actions-report.md

@@ -6,9 +6,8 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(94%) account/user-controls-page.js - current PR changed runtime JS file with browser V8 coverage; executed lines 961/961; executed functions 111/118
-(0%) toolbox/controls/controls.js - WARNING: reporter HEAD-baseline file was not collected by Playwright V8 coverage; not part of the current PR diff; advisory only
+(89%) src/engine/input/NormalizedInputRegistry.js - executed lines 321/321; executed functions 24/27
+(93%) toolbox/controls/controls.js - executed lines 548/548; executed functions 56/60
 
 Guardrail warnings:
-(100%) none for current PR changed runtime JS files
-(0%) toolbox/controls/controls.js - WARNING: reporter HEAD-baseline file missing from coverage; not part of the current PR diff; advisory only
+(100%) none - no changed runtime JS coverage warnings

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -12,13 +12,13 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(100%) Toolbox Index - exercised 1 runtime JS files
+(88%) Toolbox Index - exercised 3 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
-(61%) Theme V2 Shared JS - exercised 1 runtime JS files
+(62%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(94%) account/user-controls-page.js - current PR changed runtime JS file with browser V8 coverage; executed lines 961/961; executed functions 111/118
-(0%) toolbox/controls/controls.js - WARNING: reporter HEAD-baseline file was not collected by Playwright V8 coverage; not part of the current PR diff; advisory only
+(89%) src/engine/input/NormalizedInputRegistry.js - executed lines 321/321; executed functions 24/27
+(93%) toolbox/controls/controls.js - executed lines 548/548; executed functions 56/60
 
 Files with executed line/function counts where available:
 (11%) src/engine/input/InputMappingManifest.js - executed lines 78/78; executed functions 1/9
@@ -33,17 +33,21 @@ Files with executed line/function counts where available:
 (59%) src/engine/input/PointerDragState.js - executed lines 225/225; executed functions 13/22
 (60%) src/engine/input/InputCapabilityDescriptors.js - executed lines 261/261; executed functions 9/15
 (61%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 625/625; executed functions 33/54
+(64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
+(75%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 21/28
 (80%) src/engine/input/GamepadState.js - executed lines 100/100; executed functions 16/20
 (89%) src/engine/input/NormalizedInputRegistry.js - executed lines 321/321; executed functions 24/27
+(93%) toolbox/controls/controls.js - executed lines 548/548; executed functions 56/60
 (94%) account/user-controls-page.js - executed lines 961/961; executed functions 111/118
 (100%) account/user-controls.js - executed lines 2/2; executed functions 1/1
 (100%) toolbox/controls/controls-api-client.js - executed lines 12/12; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
-(100%) none for current PR changed runtime JS files
-(0%) toolbox/controls/controls.js - WARNING: reporter HEAD-baseline file missing from coverage; not part of the current PR diff; advisory only
+(100%) none - no low-coverage changed runtime JS files
 
 Changed JS files considered:
+(0%) tests/input/NormalizedInputRegistry.test.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/InputMappingV2Tool.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) toolbox/controls/controls.js - changed JS file not collected as browser runtime coverage
+(89%) src/engine/input/NormalizedInputRegistry.js - changed JS file with browser V8 coverage
+(93%) toolbox/controls/controls.js - changed JS file with browser V8 coverage
 (94%) account/user-controls-page.js - changed JS file with browser V8 coverage

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -49,10 +49,10 @@ const DEFAULT_PHYSICAL_INPUT_MAP = Object.freeze({
     Button3: 'action.quaternary',
     Button8: 'action.select',
     Button9: 'action.start',
-    'DPad Down': 'dpad.down',
-    'DPad Left': 'dpad.left',
-    'DPad Right': 'dpad.right',
-    'DPad Up': 'dpad.up',
+    'DPad Down': 'move.y+',
+    'DPad Left': 'move.x-',
+    'DPad Right': 'move.x+',
+    'DPad Up': 'move.y-',
     Enter: 'action.confirm',
     Escape: 'action.cancel',
     KeyA: 'move.x-',
@@ -65,8 +65,8 @@ const DEFAULT_PHYSICAL_INPUT_MAP = Object.freeze({
     MouseX: 'aim.x+',
     MouseY: 'aim.y+',
     Space: 'action.primary',
-    'Trigger Left': 'trigger.left',
-    'Trigger Right': 'trigger.right',
+    'Trigger Left': 'action.primary',
+    'Trigger Right': 'action.secondary',
 });
 
 const DEFAULT_PHYSICAL_AXIS_DIRECTION_MAP = Object.freeze({

src/engine/input/NormalizedInputRegistry.js

@@ -50,8 +50,12 @@ function testRegistryContainsPlayableNormalizedInputs() {
 function testPhysicalDefaultsRouteThroughNormalizedInputs() {
   assert.equal(defaultNormalizedInputForPhysicalInput('Button0'), 'action.primary');
   assert.equal(defaultNormalizedInputForPhysicalInput('Button1'), 'action.secondary');
-  assert.equal(defaultNormalizedInputForPhysicalInput('DPad Up'), 'dpad.up');
-  assert.equal(defaultNormalizedInputForPhysicalInput('Trigger Right'), 'trigger.right');
+  assert.equal(defaultNormalizedInputForPhysicalInput('DPad Up'), 'move.y-');
+  assert.equal(defaultNormalizedInputForPhysicalInput('DPad Down'), 'move.y+');
+  assert.equal(defaultNormalizedInputForPhysicalInput('DPad Left'), 'move.x-');
+  assert.equal(defaultNormalizedInputForPhysicalInput('DPad Right'), 'move.x+');
+  assert.equal(defaultNormalizedInputForPhysicalInput('Trigger Left'), 'action.primary');
+  assert.equal(defaultNormalizedInputForPhysicalInput('Trigger Right'), 'action.secondary');
   assert.equal(defaultNormalizedInputForPhysicalInput('Axis0'), 'move.x+');
   assert.equal(defaultNormalizedInputForPhysicalInput('Axis3'), 'aim.y+');
   assert.equal(defaultNormalizedInputForPhysicalInput('KeyW'), 'move.y-');