Close toolbox template gaps, reconcile active tests, and polish final root structure - PR_26154_031-033-cleanup-stack

Author: ToolboxAid

admin/grouping-colors.html

@@ -256,7 +256,7 @@ <h3><span class="brand-color-code"><span
                             cues inside those categories, and tile colors can be corrected later.</div>
                         <div class="callout"><strong>Shared grouping color layer:</strong> grouping colors are applied
                             through shared group classes and per-group imports under
-                            <code>assets/css/tools/grouping/</code>. Tools can be rethemed by changing the grouping CSS
+                            <code>assets/theme-v2/css/tools/grouping/</code>. Tools can be rethemed by changing the grouping CSS
                             import or token mapping, and pages should not define their own group colors. The current
                             mapping follows the Color-Aligned Grouping Option: Build &amp; Create pink, Content &amp;
                             Assets orange, Media &amp; Audio red, AI &amp; Learning purple, Platform &amp; Cloud blue,

docs_build/account/grouping-colors.html

@@ -39,7 +39,7 @@ <h2>Future Alignment Note</h2>
     <section>
       <h2>Shared Grouping Color Layer</h2>
       <p>Grouping colors are applied by shared grouping classes and per-group imports under
-        <code>assets/css/tools/grouping/</code>. Tools can be rethemed by changing the grouping CSS import or token
+        <code>assets/theme-v2/css/tools/grouping/</code>. Tools can be rethemed by changing the grouping CSS import or token
         mapping. Pages should not define their own group colors. The current mapping follows the Color-Aligned Grouping
         Option: Build &amp; Create pink, Content &amp; Assets orange, Media &amp; Audio red, AI &amp; Learning purple,
         Platform &amp; Cloud blue, and Development &amp; System gray.</p>

docs_build/dev/codex_commands.md

@@ -2,53 +2,63 @@
 
 Task:
 
-- `PR_26154_030-toolbox-nav-character-closeout`
+- `PR_26154_031-toolbox-template-mismatch-closeout`
+- `PR_26154_032-active-test-suite-reconciliation`
+- `PR_26154_033-root-structure-final-polish`
 
 Changes:
 
 - Read `.codex/skills/repo-build/SKILL.md`.
 - Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
-- Used `PR_26154_029-theme-v2-root-rename` as the current baseline.
-- Updated shared Theme V2/toolbox character styling in `assets/theme-v2/css/panels.css`.
-- Kept the character image on the left by preserving the existing ToolDisplayMode DOM order.
-- Confirmed 15px character-to-content spacing through the existing `--space-15` token.
-- Updated the stale aggregate Theme V2 selector in `assets/theme-v2/css/gamefoundrystudio.css`.
-- Updated `assets/theme-v2/partials/header-nav.html` so all active toolbox tool pages appear in the Toolbox navigation.
-- Added Toolbox nav submenus for multi-tool groups, including Audio with MIDI and Sound.
-- Added route-map entries for Tool Builder and Tool Creator in `assets/theme-v2/js/gamefoundry-partials.js`.
-- Removed Marketplace from the active toolbox index data in `toolbox/tools-page-accordions.js`.
-- Kept Marketplace in the header and footer as a product/capability destination outside Toolbox.
+- Used the latest applied PR state as the baseline.
+- Re-ran template consistency checks for active public/root pages and active toolbox pages.
+- Updated stale grouping CSS copy in `admin/grouping-colors.html` and `docs_build/account/grouping-colors.html`.
+- Removed deprecated-only tests for old games, old samples, removed V2 tool pages, removed integration surfaces, and old template/tool registries.
+- Rewired active test lane metadata to `tests/playwright/tools/RootToolsFutureState.spec.mjs`.
+- Updated Playwright structure ownership metadata and V8 coverage entry-point labels for `toolbox/` and `assets/theme-v2/`.
+- Confirmed Marketplace is absent from `toolbox/index.html` and `toolbox/tools-page-accordions.js`.
+- Confirmed shared header/footer still keep Marketplace as a product destination.
 - Did not modify `old-tools/`, `old_games/`, `old_samples/`, or `start_of_day/`.
 
 Validation:
 
-- Ran targeted reference checks for `toolbox/index.html`, `toolbox/tools-page-accordions.js`, shared header nav, Marketplace entries, `.tool-display-mode__character`, and `assets/theme-v2` paths.
-- Ran template consistency audit after the Toolbox nav update.
-- Ran static validation for changed HTML, JS, CSS, JSON, and Markdown files.
-- Ran changed JavaScript syntax checks.
+- Ran changed JavaScript syntax checks:
+  - `node --check scripts/run-targeted-test-lanes.mjs`
+  - `node --check scripts/audit-playwright-test-locations.mjs`
+  - `node --check tests/run-tests.mjs`
+  - `node --check tests/helpers/playwrightV8CoverageReporter.mjs`
+- Ran template consistency audit:
+  - Public/root pages: `43/43`
+  - Active toolbox pages: `20/20`
+- Ran targeted stale reference checks for `toolbox`, `assets/theme-v2`, footer/header links, `styles.css`, `favicon.ico`, `assets/theme/v2`, `GameFoundryStudio/`, `src/engine/theme`, removed `tools/` routes, and removed `samples/` routes.
+- Ran active toolbox index ordering and header coverage checks.
+- Ran direct removed-samples import/route scan in active tests.
+- Ran `npm run test:playwright:static`.
 - Ran `npm run test:workspace-v2`.
 - Ran `git diff --check`.
-- Ran `npm run codex:review-artifacts`.
+- Regenerated required Codex review artifacts.
 - Packaged repo-structured ZIP:
-  - `tmp/PR_26154_030-toolbox-nav-character-closeout_delta.zip`
+  - `tmp/PR_26154_031-033-template-test-root-polish_delta.zip`
 
 Required reports:
 
 - `docs_build/dev/reports/codex_changed_files.txt`
 - `docs_build/dev/reports/codex_review.diff`
-- `docs_build/dev/reports/toolbox_nav_character_closeout_report.md`
-- `docs_build/dev/reports/template_consistency_after_toolbox_nav_report.md`
+- `docs_build/dev/reports/toolbox_template_mismatch_closeout_report.md`
+- `docs_build/dev/reports/active_test_suite_reconciliation_report.md`
+- `docs_build/dev/reports/root_structure_final_polish_report.md`
+- `docs_build/dev/reports/remaining_cleanup_report.md`
 
 Validation summary:
 
+- PASS template audit: public/root pages `43/43`.
+- PASS template audit: active toolbox pages `20/20`.
 - PASS active toolbox header coverage: `20/20`.
-- PASS Marketplace removed from `toolbox/index.html` rendered data.
-- PASS Marketplace remains in footer Product column.
-- PASS `.tool-display-mode__character` is 150px by 150px in shared Theme V2 styling.
-- PASS 15px character spacing is present through `--space-15`.
-- PASS zero active references remain to the retired Theme V2 root path.
-- PASS post-change template audit: public/root pages `43/43`, active toolbox pages `20/20`.
-- PASS `npm run test:workspace-v2`.
+- PASS Marketplace is absent from active toolbox index data.
+- PASS active public pages do not use `assets/theme-v2/css/styles.css`.
+- PASS zero active public `tools/` route references remain.
+- PASS `npm run test:playwright:static`.
+- PASS `npm run test:workspace-v2` with `2 passed`.
 - PASS `git diff --check`.
-- SKIPPED tests against `old-tools/`, `old_games/`, and `old_samples/` per request.
+- SKIPPED tests against `old-tools/`, `old_games/`, and `old_samples` per request.
 - SKIPPED full samples smoke test per request.

docs_build/dev/commit_comment.txt

@@ -1,6 +1,8 @@
-Close out toolbox nav coverage and ToolDisplayMode character sizing - PR_26154_030-toolbox-nav-character-closeout
+Close out toolbox templates, reconcile active tests, and polish root paths - PR_26154_031-033
 
-- Set shared Theme V2 `.tool-display-mode__character` rendering to 150px by 150px with 15px adjacent spacing.
-- Add all active toolbox tools to the shared header Toolbox navigation, including grouped Audio, Assets, Objects, Tooling, and Worlds submenus.
-- Remove Marketplace from the active toolbox index data while preserving Marketplace as a product/footer destination.
-- Validate active toolbox nav coverage, template consistency, Workspace V2, static changed files, diff hygiene, and review artifacts.
+- Confirm active public/root and toolbox template consistency remains clean at 43/43 and 20/20.
+- Fix stale Theme V2 grouping CSS path copy in active admin/docs pages.
+- Remove deprecated-only tests for old games, old samples, removed V2 tools, old template baselines, and removed integration surfaces.
+- Rewire active test lanes and coverage labels to current toolbox and assets/theme-v2 paths.
+- Confirm Marketplace stays outside toolbox index while remaining in product header/footer navigation.
+- Validate static checks, Workspace V2, targeted stale-path scans, diff hygiene, and repo-structured delta packaging.

docs_build/dev/reports/active_test_suite_reconciliation_report.md

@@ -0,0 +1,112 @@
+# PR_26154_032 Active Test Suite Reconciliation
+
+Baseline used: latest applied root/theme/toolbox migration state after `PR_26154_031-toolbox-template-mismatch-closeout`.
+
+## Scope
+
+- Classified active test entry points, fixtures, helpers, and Playwright folders.
+- Removed tests that only targeted deprecated `old-tools`, `old_games`, `old_samples`, removed `tools/`, removed `samples/`, or removed legacy V2 tool folders.
+- Rewired active test lane metadata only where the intended active target was clear.
+- Kept root `package.json` in place.
+
+## Active
+
+- `tests/run-tests.mjs`: active explicit Node test runner after deprecated-only entries were removed.
+- `tests/playwright/tools/RootToolsFutureState.spec.mjs`: active toolbox/root future-state Playwright coverage.
+- `tests/helpers/playwrightRepoServer.mjs`: active shared Playwright server fixture.
+- `tests/helpers/playwrightStorageIsolation.mjs`: active shared Playwright storage fixture.
+- `tests/helpers/workspaceV2CoverageReporter.mjs`: active Workspace V2 coverage helper.
+- `tests/helpers/playwrightV8CoverageReporter.mjs`: active V8 coverage helper, updated to current `toolbox/` and `assets/theme-v2/` entry points.
+- `tests/tools/*.test.mjs` files still imported by `tests/run-tests.mjs`: active engine/tool contract coverage unless noted as ambiguous below.
+
+## Rewired
+
+| File | Change | Reason |
+| --- | --- | --- |
+| `tests/run-tests.mjs` | Removed deprecated-only test imports and runner entries. | The removed tests targeted old tool/sample/template contracts. |
+| `scripts/run-targeted-test-lanes.mjs` | Pointed `tool-runtime` to `tests/playwright/tools/RootToolsFutureState.spec.mjs`. | Keeps the active toolbox lane current. |
+| `scripts/run-targeted-test-lanes.mjs` | Removed stale integration Playwright lane commands and discovery targets. | The integration specs only validated old tool/sample launch surfaces. |
+| `scripts/audit-playwright-test-locations.mjs` | Removed deprecated Playwright tool ownership names and old fixture mappings. | Prevents deleted V2/old tool specs from remaining required locations. |
+| `tests/helpers/playwrightV8CoverageReporter.mjs` | Updated format entry points to `toolbox/`, `toolbox/_tool_template-v2/`, and `assets/theme-v2/js/`. | Aligns coverage summaries with the current root structure. |
+
+## Deleted Deprecated-Only Tests
+
+Removed `61` deprecated-only test files:
+
+- `tests/games/GravityValidation.test.mjs`
+- `tests/games/GravityWorld.test.mjs`
+- `tests/games/MultiBallChaosValidation.test.mjs`
+- `tests/games/MultiBallChaosWorld.test.mjs`
+- `tests/games/PacmanLiteValidation.test.mjs`
+- `tests/games/PacmanLiteWorld.test.mjs`
+- `tests/games/PaddleInterceptValidation.test.mjs`
+- `tests/games/PaddleInterceptWorld.test.mjs`
+- `tests/games/ThrusterValidation.test.mjs`
+- `tests/games/ThrusterWorld.test.mjs`
+- `tests/playwright/integration/GameIndexPreviewManifestBroadScan.spec.mjs`
+- `tests/playwright/integration/GameIndexPreviewManifestResolution.spec.mjs`
+- `tests/playwright/integration/ToolsIndexFirstClassToolRegistration.spec.mjs`
+- `tests/playwright/tools/AssetManagerV2.spec.mjs`
+- `tests/playwright/tools/CollisionInspectorV2.spec.mjs`
+- `tests/playwright/tools/MidiStudioV2.spec.mjs`
+- `tests/playwright/tools/ObjectVectorStudioV2FirstClassToolStarter.spec.mjs`
+- `tests/playwright/tools/PaletteManagerV2Coverage.spec.mjs`
+- `tests/playwright/tools/PreviewGeneratorV2Baseline.spec.mjs`
+- `tests/playwright/tools/ToolTemplateV2Baseline.spec.mjs`
+- `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+- `tests/runtime/Phase16AdvancedBatch1Sanity.test.mjs`
+- `tests/runtime/Phase16AdvancedBatch2Sanity.test.mjs`
+- `tests/runtime/Phase16AdvancedBatch3Sanity.test.mjs`
+- `tests/runtime/Phase16AdvancedBatch4Sanity.test.mjs`
+- `tests/runtime/Phase16AdvancedBatch5Sanity.test.mjs`
+- `tests/runtime/Phase16RenderingAnimationTrackSanity.test.mjs`
+- `tests/runtime/Phase16VisibilitySanity.test.mjs`
+- `tests/runtime/Phase17DebugOverlayBottomRightPosition.test.mjs`
+- `tests/runtime/Phase17OverlayDiagnosticsTooling.test.mjs`
+- `tests/runtime/Phase17OverlayExpansionFramework.test.mjs`
+- `tests/runtime/Phase17OverlayGameplayRuntimeIntegration.test.mjs`
+- `tests/runtime/Phase17OverlayInputEdgeCases.test.mjs`
+- `tests/runtime/Phase17OverlayMultiLayerComposition.test.mjs`
+- `tests/runtime/Phase17RealGameplaySample.test.mjs`
+- `tests/runtime/Phase17RenderingTechniqueExpansionSanity.test.mjs`
+- `tests/runtime/Phase17Sample1709MovementModelsLab.test.mjs`
+- `tests/runtime/Phase17Sample1712GameplayMetricsTelemetry.test.mjs`
+- `tests/runtime/Phase17Sample1713FinalReferenceGame.test.mjs`
+- `tests/runtime/Phase17TabDebugOverlayCycle1707Plus.test.mjs`
+- `tests/runtime/Phase18CoreServicesSkeleton.test.mjs`
+- `tests/runtime/Phase18IntegrationFlowPass.test.mjs`
+- `tests/runtime/Phase18RuntimeLayerScaffold.test.mjs`
+- `tests/runtime/Phase19CoreServicesSkeleton.test.mjs`
+- `tests/runtime/Phase19IntegrationFlowPass.test.mjs`
+- `tests/runtime/Phase19OverlayExpansionFramework.test.mjs`
+- `tests/runtime/Phase19OverlayPluginRegistry.test.mjs`
+- `tests/runtime/Phase19RuntimeLayerScaffold.test.mjs`
+- `tests/runtime/SampleStandaloneToolDataFlow.test.mjs`
+- `tests/runtime/V2ToolSmoke.test.mjs`
+- `tests/samples/FullscreenAbility0713ViewportFit.test.mjs`
+- `tests/samples/OrbitLabModel.test.mjs`
+- `tests/samples/OrbitLabScene.test.mjs`
+- `tests/samples/ProjectileLabModel.test.mjs`
+- `tests/samples/ProjectileLabScene.test.mjs`
+- `tests/samples/SamplesProgramCombinedPass.test.mjs`
+- `tests/tools/ToolEntryLaunchContract.test.mjs`
+- `tests/tools/ToolLocalSampleMigration.test.mjs`
+- `tests/tools/ToolSchemaStrictModeValidation.test.mjs`
+- `tests/tools/ToolsIndexRegistrySmoke.test.mjs`
+- `tests/tools/VectorTemplateSampleGame.test.mjs`
+
+## Ambiguous / Retained
+
+- `tests/final/ReleaseReadinessSystems.test.mjs` retains `old_samples/shared/theme.css` as a string fixture for packager deduplication behavior; it is not a deprecated sample runtime test.
+- Active contract tests that assert paths are not `samples/` or `GameFoundryStudio/` were retained because they enforce current boundaries.
+- `tests/validation/samples.*.json` remains as historical validation fixture data. It is not invoked by the removed samples tests.
+- `tests/fixtures/v2-tools/` remains as ambiguous fixture inventory because this PR only deleted deprecated-only tests, not fixture archives.
+
+## Validation
+
+- PASS direct removed-samples import/route scan in active tests.
+- PASS stale deleted-spec-name scan; only a historical roadmap line mentions `SamplesProgramCombinedPass`.
+- PASS changed JavaScript syntax checks.
+- PASS `npm run test:playwright:static`.
+- PASS `npm run test:workspace-v2`.
+- SKIPPED tests against `old-tools/`, `old_games`, and `old_samples` per request.

docs_build/dev/reports/remaining_cleanup_report.md

@@ -0,0 +1,31 @@
+# PR_26154_031-033 Remaining Cleanup Report
+
+## Remaining Candidates
+
+These items were not moved or deleted because they are ambiguous, historical, or outside this stacked PR scope.
+
+| Item | Status | Reason |
+| --- | --- | --- |
+| `toolbox/toolRegistry.js` | Ambiguous legacy registry | It still references `old-tools/` and `old_samples/`, but no active page/import path in this PR proved it is safe to delete. |
+| `toolbox/renderToolsIndex.js` | Ambiguous legacy renderer | It references `old_samples/` and may belong with the legacy registry cleanup, but was not touched without a clear active dependency answer. |
+| `toolbox/shared/preview/*.html` | Ambiguous preview tooling | Still references `old_samples/`; requires a dedicated preview-generator/tooling ownership PR. |
+| `toolbox/dev/*.baseline.json` | Ambiguous guard baselines | Baselines preserve `old_samples/` evidence and may still support active guard scripts. |
+| `tests/fixtures/v2-tools/` | Deprecated-looking fixture archive | Deprecated tests were removed, but fixture deletion was not required by this PR and may need a separate fixture inventory. |
+| `tests/validation/samples.*.json` | Historical validation data | Retained because active contract tests still inspect schema/report boundaries. |
+| `docs_build/dev/roadmaps/*` and archived docs | Historical references | Old path references are preserved history, not active runtime/page wiring. |
+| `old_games/index.html` and `old_samples/index.html` | Deprecated playable references | Excluded by request; still preserve old playable/reference access. |
+
+## Confirmed Clean
+
+- No active public/root or toolbox page references `assets/theme/v2`.
+- No active public/root or toolbox page references `assets/theme-v2/css/styles.css`.
+- No active public/root or toolbox page references `favicon.ico`.
+- No active public `tools/` routes remain.
+- Active toolbox template audit remains clean.
+- Active toolbox nav coverage remains complete.
+
+## Deferred Work
+
+- Decide whether `toolbox/toolRegistry.js`, `toolbox/renderToolsIndex.js`, and `toolbox/shared/preview/` should move to `old-tools/` or be replaced by a current active toolbox registry.
+- Inventory and retire `tests/fixtures/v2-tools/` if no future active test plan needs those payloads.
+- Separate historical docs cleanup from runtime cleanup so old path history is not mistaken for active wiring.

docs_build/dev/reports/root_structure_final_polish_report.md

@@ -0,0 +1,58 @@
+# PR_26154_033 Root Structure Final Polish
+
+Baseline used: latest applied root/theme/toolbox migration state after `PR_26154_032-active-test-suite-reconciliation`.
+
+## Scope
+
+- Audited active references for stale root migration paths.
+- Confirmed footer/header paths are current.
+- Confirmed Marketplace is not listed in `toolbox/index.html`.
+- Confirmed active Toolbox navigation covers all active toolbox tools.
+- Fixed stale active path copy where the intended path was clear.
+
+## Path Fixes
+
+| File | Old Copy | New Copy |
+| --- | --- | --- |
+| `admin/grouping-colors.html` | `assets/css/tools/grouping/` | `assets/theme-v2/css/tools/grouping/` |
+| `docs_build/account/grouping-colors.html` | `assets/css/tools/grouping/` | `assets/theme-v2/css/tools/grouping/` |
+
+## Active Stale Reference Audit
+
+Tracked active files were checked excluding `old-tools/`, `old_games/`, `old_samples/`, `start_of_day/`, `docs_build/`, and `tmp/`.
+
+| Path / Token | Active Runtime/Page References | Notes |
+| --- | ---: | --- |
+| `assets/theme/v2` | 0 | PASS |
+| `favicon.ico` | 0 | PASS |
+| `assets/theme-v2/css/styles.css` | 0 | PASS |
+| active public `tools/` route references | 0 | PASS |
+| `GameFoundryStudio/` | 2 | Both are negative assertions in active tests. |
+| `src/engine/theme` | 1 | Historical validation fixture JSON only. |
+
+## Header / Footer / Toolbox
+
+- PASS shared header still contains `marketplace/index.html` as a Product destination.
+- PASS shared footer still contains `marketplace/index.html` as a Product destination.
+- PASS `toolbox/index.html` and `toolbox/tools-page-accordions.js` have zero Marketplace entries.
+- PASS active toolbox header coverage: `20/20` active tool pages.
+- PASS `toolbox/tools-page-accordions.js` group order is alphabetical.
+- PASS each toolbox group in `toolbox/tools-page-accordions.js` is alphabetized by visible tool title.
+
+Active toolbox groups:
+
+- AI: AI Assistant
+- Assets: Cloud, Localization, Publish, Storage Inspector
+- Audio: MIDI, Sound
+- Colors: Palette Manager
+- Input: Input
+- Objects: Animation, Assets, Custom Extensions, Object Vector
+- Worlds: Game Builder, Game Design, Particles, World Vector
+
+## Validation
+
+- PASS targeted reference checks for `toolbox`, `assets/theme-v2`, tests, footer/header links, and stale paths.
+- PASS template consistency audit: public/root pages `43/43`, active toolbox pages `20/20`.
+- PASS active toolbox header coverage: `20/20`.
+- PASS `npm run test:playwright:static`.
+- PASS `npm run test:workspace-v2`.