Harden MIDI Studio V2 finish-line persistence SSoT UI song builder timeline instruments export manifest readiness and final reports - PR_26146_133-140-midi-studio-v2-finish-line-hardening-lane

ToolboxAid · ToolboxAid · commit a8f37cd2247c · 2026-05-30T10:47:06.000-04:00
diff --git a/docs/dev/reports/PR_26146_133_140_bundle_validation.md b/docs/dev/reports/PR_26146_133_140_bundle_validation.md
@@ -0,0 +1,38 @@
+# PR_26146_133-140 Bundle Validation
+
+Status: WARN
+
+Scope:
+- Hardened MIDI Studio V2 tool-only JSON import/export persistence.
+- Hardened Workspace Manager payload handoff persistence.
+- Preserved canonical song model, generated ID behavior, canvas-backed Octave Timeline, Song Sheet sequence builder, instrument ownership, export ownership, and launch split.
+
+Changed files:
+- `tools/midi-studio-v2/js/services/MidiStudioStateSerializer.js`
+- `tools/midi-studio-v2/js/controls/StatusLogControl.js`
+- `tools/midi-studio-v2/js/MidiStudioV2App.js`
+- `tests/playwright/tools/MidiStudioV2.spec.mjs`
+
+Validation:
+- PASS changed-file syntax checks:
+  - `node --check tools/midi-studio-v2/js/services/MidiStudioStateSerializer.js`
+  - `node --check tools/midi-studio-v2/js/controls/StatusLogControl.js`
+  - `node --check tools/midi-studio-v2/js/MidiStudioV2App.js`
+  - `node --check tests/playwright/tools/MidiStudioV2.spec.mjs`
+- PASS targeted MIDI Studio Playwright validation:
+  - `npx playwright test tests/playwright/tools/MidiStudioV2.spec.mjs --grep "PR133-140" --reporter=line`
+  - Result: 2 passed.
+- WARN `npm run test:workspace-v2`
+  - Result: timed out after 604057 ms with no final pass/fail result.
+  - Cleanup: leftover Playwright/Node processes from the timed-out run were stopped.
+- PASS `git diff --check`
+  - Exit code 0.
+  - Note: Git emitted a CRLF working-copy warning for `tests/playwright/tools/MidiStudioV2.spec.mjs`; no whitespace errors were reported.
+
+Playwright coverage:
+- Tool-only JSON workflow round-trips exported `html-js-gaming.tool-state` payloads without relying on hidden localStorage/sessionStorage.
+- Workspace launch updates both `workspace.tools.midi-studio-v2` and the host context payload.
+- Song Sheet populated-section rules, missing-section rejection, sequence duplicate/remove, parse, generation targets, and canonical JSON updates are covered.
+- Canvas timeline section headers, drag paint, drag erase, manual note persistence, keyboard audition, and playback completion/loop are covered.
+- Instrument selected ID synchronization, settings persistence, duplicate, move, delete safety, and future unwired controls are covered.
+- Export/Manifest readiness honesty and red/unwired rendered output controls are covered.
diff --git a/docs/dev/reports/PR_26146_133_140_export_manifest_audit.md b/docs/dev/reports/PR_26146_133_140_export_manifest_audit.md
@@ -0,0 +1,27 @@
+# PR_26146_133-140 Export and Manifest Audit
+
+Status: PASS
+
+Export ownership:
+- Export tab owns rendered target path fields and visible Save WAV/MP3/OGG actions.
+- Rendered output Save actions remain visible and red/unwired because real audio rendering is incomplete.
+- SoundFont/rendering controls remain red/unwired.
+- JSON export remains separate from rendered audio save actions.
+
+Persistence:
+- PASS Export JSON writes a wrapped `html-js-gaming.tool-state` preview into JSON Details.
+- PASS Import JSON now accepts that wrapped exported tool-state payload.
+- PASS PASS/WARN/FAIL style status is visible:
+  - import success emits PASS
+  - JSON export success emits PASS
+  - Save Project serialization emits PASS
+  - missing rendered targets emit FAIL
+  - unimplemented rendering emits WARN when a selected target exists
+
+Manifest readiness:
+- Export readiness continues to summarize selected song, classification, generated ID, sequence, sections, instruments, notes, target output formats, and game usage assignment readiness.
+- Missing assignments remain WARN-level readiness content, not UAT-blocking FAIL.
+
+Honesty checks:
+- PASS targeted Playwright verifies rendered Save does not claim file creation.
+- PASS status surfaces report missing rendered targets honestly.
diff --git a/docs/dev/reports/PR_26146_133_140_final_readiness_report.md b/docs/dev/reports/PR_26146_133_140_final_readiness_report.md
@@ -0,0 +1,53 @@
+# PR_26146_133-140 Final Readiness Report
+
+Status: WARN
+
+PASS workflows:
+- Tool-only Import JSON Manifest.
+- Tool-only Export JSON tool-state preview.
+- Tool-state JSON round-trip import.
+- Workspace Manager launch split and Return to Workspace.
+- Workspace payload handoff for classification, generated ID, Song Sheet sequence, instrument settings, and manual notes.
+- Generated ID remains `camelCase(Name) + "-" + Classification`.
+- Song Sheet populated-section builder and sequence workflow.
+- Parse Guided Song Sheet visible updates.
+- Canvas-backed Octave Timeline edit, drag paint, drag erase, section selection, keyboard audition, and playback highlighting.
+- Instrument selected ID sync, duplicate, move, delete safety, settings persistence, and audition.
+- Export readiness/status honesty.
+- Red/unwired incomplete controls remain visible.
+- No duplicate editable ownership found by targeted visible-control audit.
+
+WARN workflows:
+- `npm run test:workspace-v2` timed out after 604057 ms and did not produce a final pass/fail result.
+- Broad all-suite accordion and frozen-scroll coverage were not rerun to completion in this lane because of that timeout.
+
+FAIL workflows:
+- No new targeted MIDI Studio runtime failures remain after fixes.
+
+Red/unwired future controls:
+- Rendered Save WAV/MP3/OGG real file generation.
+- SoundFont/render settings.
+- Song Sequence drag/drop.
+- Future history/autosave controls.
+- Future game usage runtime sync.
+- Future MIDI input and advanced MIDI conversion.
+- Future instrument effects/advanced controls.
+
+Playback audit:
+- PASS Play starts audible preview.
+- PASS natural completion clears playing state and re-enables Play.
+- PASS Loop playback advances playhead.
+- PASS Stop clears looping state and re-enables Play.
+
+Persistence audit:
+- PASS canonical payload persists songs, sections, sequence, instruments, and note edits through JSON export/import.
+- PASS Workspace handoff writes both tool session data and host context tool data.
+- PASS no hidden localStorage/sessionStorage dependency is required for tool-only correctness.
+
+Export/manifest audit:
+- PASS JSON export/import is distinct from rendered audio saving.
+- PASS rendered output controls do not falsely claim file creation.
+- PASS manifest/export readiness summaries remain visible and honest.
+
+Recommended next PRs:
+- Revisit the broad `npm run test:workspace-v2` timeout/performance separately if the full workspace gate is still required for every MIDI Studio lane.
diff --git a/docs/dev/reports/PR_26146_133_140_instrument_audit.md b/docs/dev/reports/PR_26146_133_140_instrument_audit.md
@@ -0,0 +1,31 @@
+# PR_26146_133-140 Instrument Audit
+
+Status: PASS
+
+Validated workflows:
+- selectedInstrumentId synchronization across:
+  - Instruments tab
+  - Octave Timeline quick instrument rows
+  - Audition keyboard
+- Instrument setting persistence for:
+  - volume
+  - pan
+  - transpose
+  - preview lane settings in exported/reimported tool-state JSON
+- Instrument lifecycle:
+  - duplicate selected instrument
+  - move selected instrument up
+  - move selected instrument down
+  - delete safety confirmation
+  - remove duplicated instrument
+- Audition workflow:
+  - selected instrument keyboard audition emits visible status
+  - timeline keyboard audition remains responsive
+
+SSoT result:
+- PASS instrument detail editing remains owned by the Instruments tab.
+- PASS Octave Timeline quick rows are action/sync surfaces, not duplicate full editable owners.
+- PASS future effects and advanced controls remain red/unwired.
+
+Residual risk:
+- WARN broad workspace-v2 run timed out, but targeted MIDI Studio validation covers the finish-line instrument lifecycle path.
diff --git a/docs/dev/reports/PR_26146_133_140_persistence_audit.md b/docs/dev/reports/PR_26146_133_140_persistence_audit.md
@@ -0,0 +1,32 @@
+# PR_26146_133-140 Persistence Audit
+
+Status: PASS
+
+Implemented:
+- Import now accepts wrapped `html-js-gaming.tool-state` JSON exported by MIDI Studio V2.
+- Import now accepts normalized Workspace Manager tool-state objects shaped as `workspace/data/dirty`.
+- `previewLaneSettings` are preserved through canonical song normalization instead of falling back to `previewInstruments` only.
+- Import, Export JSON, and Save Project emit visible PASS status lines while preserving existing OK/WARN/FAIL log behavior.
+
+Tool-only Import/Export JSON:
+- PASS exported `toolState.payload.songs[]` retained:
+  - song name
+  - classification
+  - generated ID
+  - Song Sheet sections
+  - Song Sequence
+  - generated/manual lane content
+  - instrument volume/pan/transpose settings
+  - rendered target metadata
+- PASS reimport of the exported tool-state restored the canonical payload from JSON alone.
+- PASS targeted Playwright verified no `workspace.tools.midi-studio-v2` sessionStorage dependency in tool mode.
+
+Workspace handoff:
+- PASS launch from Workspace Manager hides tool-only import/save controls and shows Return to Workspace.
+- PASS edits to classification, generated ID, Song Sheet sequence, instrument settings, and manual notes update:
+  - `sessionStorage["workspace.tools.midi-studio-v2"].data`
+  - `sessionStorage[hostContextId].tools["midi-studio-v2"]`
+- PASS dirty metadata records changed keys and final edit reason.
+
+Residual risk:
+- WARN broad `npm run test:workspace-v2` timed out, so only the targeted MIDI Studio handoff slice is confirmed in this lane.
diff --git a/docs/dev/reports/PR_26146_133_140_song_builder_audit.md b/docs/dev/reports/PR_26146_133_140_song_builder_audit.md
@@ -0,0 +1,25 @@
+# PR_26146_133-140 Song Builder Audit
+
+Status: PASS
+
+Validated workflows:
+- Intro, Verse, Chorus, Bridge, Outro editors remain first-class.
+- Custom sections remain supported.
+- Empty Bridge section is excluded from Available Sections.
+- Populated Available Sections show section labels and chord/bar counts.
+- Song Sequence supports Add, Duplicate, Remove in the targeted test and Move Up/Move Down in existing coverage.
+- Missing/unpopulated section references are rejected with a visible FAIL status.
+- Parse Guided Song Sheet updates:
+  - canonical song model
+  - Song Sheet summary
+  - Octave Timeline section map
+  - diagnostics / JSON Details
+  - status log
+- Apply Song Sheet To selections drive generation target summary and lane mapping.
+
+Regression coverage:
+- Targeted PR133-140 Playwright verifies missing-section rejection, populated-section-only availability, duplicate/remove sequence behavior, parse updates, target lane summary, and JSON persistence.
+- Existing PR117-124 and PR125-132 tests continue to cover section library, regeneration warning, and broader sequence workflows.
+
+Residual risk:
+- WARN broad workspace-v2 run timed out, so this lane relies on targeted MIDI Studio validation for finish-line song builder coverage.
diff --git a/docs/dev/reports/PR_26146_133_140_ssot_ownership_matrix.md b/docs/dev/reports/PR_26146_133_140_ssot_ownership_matrix.md
@@ -0,0 +1,30 @@
+# PR_26146_133-140 SSoT Ownership Matrix
+
+Status: PASS
+
+Canonical value | Editable owner | Derived/read-only surfaces | Result
+--- | --- | --- | ---
+Song name | Song Setup / Song Details | Song list, action nav, export source, diagnostics | PASS
+Classification | Song Setup / Song Details | generated ID preview, export source, diagnostics, classification guide | PASS
+Generated ID | derived from Name + Classification | Song Details read-only ID, export source, diagnostics | PASS
+Tempo | Song Setup | playback tempo and diagnostics | PASS
+Key | Song Setup | diagnostics and generation context | PASS
+Style | Song Setup | diagnostics and generation context | PASS
+Song Sheet sections | Song Setup first-class section editors and custom section editor | Available Sections, sequence labels, timeline sections, diagnostics | PASS
+Song Sequence | Song Setup sequence builder | Octave Timeline section labels and playback/build order | PASS
+Apply Song Sheet To | Song Setup | generation summary and lane mapping | PASS
+Instrument GM/type/patch/settings | Instruments tab | Octave Timeline read-only lane summaries and audition context | PASS
+selectedInstrumentId | Instruments and Octave Timeline selection actions | Audition keyboard dataset and selected row highlights | PASS
+Generated/manual notes | Octave Timeline and Auto-Create Parts canonical arrangement | counts, diagnostics, export readiness | PASS
+Rendered target paths | Export tab target fields | status, diagnostics, manifest readiness | PASS
+Rendered Save WAV/MP3/OGG | Export tab | none | PASS as visible red/unwired future renderer
+Diagnostics | Diagnostics tab | read-only derived surfaces except explicit Copy JSON / Clear Status actions | PASS
+Workspace save ownership | Workspace Manager | MIDI Studio Workspace nav proxy | PASS
+
+Duplicate editable ownership:
+- PASS targeted Playwright scanned visible controls across Song Setup, Octave Timeline, Instruments, Auto-Create Parts, MIDI Import, Diagnostics, and Export.
+- PASS no canonical editable value had more than one editable owner.
+
+Notes:
+- Timeline quick instrument controls remain action/sync surfaces; Instruments tab owns editable instrument details.
+- Rendered audio save controls remain Export-owned but red/unwired because real rendering is not complete.
diff --git a/docs/dev/reports/PR_26146_133_140_timeline_audit.md b/docs/dev/reports/PR_26146_133_140_timeline_audit.md
@@ -0,0 +1,24 @@
+# PR_26146_133-140 Timeline Audit
+
+Status: PASS
+
+Validated workflows:
+- Canvas-backed Octave Timeline remains the authoritative visual editor.
+- Timeline section labels render from Song Sequence.
+- Musical section colors are present in canvas section state.
+- Clicking a section header selects the matching Song Sequence item.
+- Timeline quick instrument selection synchronizes `selectedInstrumentId`.
+- Drag paint writes manual notes into the canonical arrangement.
+- Drag erase removes manual notes from the canonical arrangement.
+- Single-cell paint persists through exported and reimported tool-state JSON.
+- Piano-key audition remains functional.
+- Natural playback completion clears playing state and re-enables Play.
+- Loop playback advances playhead and Stop clears loop playback state.
+
+Preserved behaviors:
+- Frozen Bar/Beat behavior remains in existing MIDI Studio coverage.
+- Canvas rendering remains intact after parse and tool-state reimport.
+- Manual note edits remain distinguishable from generated notes in arrangement/source count surfaces.
+
+Residual risk:
+- WARN only targeted PR133-140 canvas interactions were run after this change; broad workspace-v2 timed out.
diff --git a/docs/dev/reports/PR_26146_133_140_ui_completion_audit.md b/docs/dev/reports/PR_26146_133_140_ui_completion_audit.md
@@ -0,0 +1,43 @@
+# PR_26146_133-140 UI Completion Audit
+
+Status: PASS
+
+Audited UI areas:
+- Song Setup
+- Octave Timeline
+- Instruments
+- Auto-Create Parts
+- MIDI Import
+- Diagnostics
+- Export
+- Tool mode navigation
+- Workspace mode navigation
+
+PASS implemented controls:
+- Import JSON Manifest in tool mode.
+- Export JSON tool-state preview.
+- Save Project serialization preview.
+- Song Details Name and Classification editing.
+- Generated ID read-only display.
+- Song Sheet section editors, custom sections, Available Sections, sequence actions, parse, regenerate warning flow.
+- Canvas-backed timeline note edit, drag paint, drag erase, section header selection, keyboard audition, Play/Stop, loop state.
+- Instrument duplicate, move up, move down, delete confirmation, audition, range/settings persistence.
+- Export readiness summaries and rendered target path fields.
+
+PASS red/unwired controls:
+- SoundFont/render pipeline controls.
+- Rendered Save WAV/MP3/OGG real file generation.
+- Song Sequence drag/drop.
+- Future history/autosave controls.
+- Future game usage runtime sync.
+- Future MIDI input and advanced MIDI conversion.
+- Future instrument effects/advanced controls.
+- Workspace proxy import/copy/export controls outside a real Workspace Manager launch.
+
+Accordion audit:
+- PASS targeted PR133-140 test verifies open/close state and icon state for Song Details.
+- PASS existing MIDI Studio accordion regression remains in the suite for all accordions.
+
+Dead control audit:
+- PASS no new dead controls were added.
+- PASS incomplete controls remain visibly red/unwired with status/tooltip metadata.
diff --git a/tests/playwright/tools/MidiStudioV2.spec.mjs b/tests/playwright/tools/MidiStudioV2.spec.mjs
diff --git a/tools/midi-studio-v2/js/MidiStudioV2App.js b/tools/midi-studio-v2/js/MidiStudioV2App.js
diff --git a/tools/midi-studio-v2/js/controls/StatusLogControl.js b/tools/midi-studio-v2/js/controls/StatusLogControl.js
diff --git a/tools/midi-studio-v2/js/services/MidiStudioStateSerializer.js b/tools/midi-studio-v2/js/services/MidiStudioStateSerializer.js
