You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs_build/dev/PROJECT_INSTRUCTIONS.md
+33-6Lines changed: 33 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -784,12 +784,13 @@ The full samples smoke test rule remains separate and runs only when broadly imp
784
784
785
785
## CODEX REVIEW DIFF REQUIREMENT
786
786
787
-
Every Codex PR must produce review artifacts so ChatGPT can review the exact code changes.
787
+
Every completed Codex PR or completed Codex run must produce review artifacts so ChatGPT can review the exact repo changes or the no-change evidence.
788
788
789
789
Codex must create:
790
790
791
791
-`docs_build/dev/reports/codex_review.diff`
792
792
-`docs_build/dev/reports/codex_changed_files.txt`
793
+
- a PR-specific or EOD-specific report under `docs_build/dev/reports/`
793
794
794
795
`codex_review.diff` must contain:
795
796
-`git diff --cached`
@@ -804,6 +805,9 @@ Rules:
804
805
- Do not pause commits
805
806
- Do not add dependencies
806
807
- Do not change runtime behavior just to create review artifacts
808
+
- Required reports remain required even when a ZIP is created.
809
+
- Required report evidence must include branch validation PASS/FAIL, a requirement-by-requirement PASS/FAIL checklist, a validation lane report, and manual validation notes.
810
+
- A ZIP artifact must not replace or move required report files out of `docs_build/dev/reports/`.
807
811
808
812
When user asks for code review, they should upload:
809
813
- PR delta ZIP
@@ -812,7 +816,7 @@ When user asks for code review, they should upload:
812
816
813
817
## MANUAL TEST REQUIREMENT
814
818
815
-
Every PR must include:
819
+
Every completed PR, audit, report-only, validation-only, or EOD closeout run must include:
816
820
- exact manual validation steps
817
821
- expected outcome
818
822
- any known out-of-scope checks
@@ -870,8 +874,15 @@ Codex ZIPs must:
870
874
- be repo-structured
871
875
- preserve exact repo-relative paths
872
876
- be placed under `<project folder>/tmp/`
873
-
- use the PR name in the ZIP filename
877
+
- use the PR or EOD run name in the ZIP filename
874
878
- contain no extra files outside the defined structure
879
+
- include all changed or preserved repo files from the completed run
880
+
- not include or depend on generated loose files under `tmp/`
881
+
- not replace required report files under `docs_build/dev/reports/`
882
+
883
+
If a completed run changes no repo files, Codex must still create a ZIP containing the PR or EOD report that proves no repo files changed.
884
+
885
+
The no-change ZIP rule does not apply when the run hard-stopped before producing outputs.
875
886
876
887
Before Codex returns any ZIP, Codex must:
877
888
1. Physically create the ZIP file.
@@ -1584,11 +1595,21 @@ Required reports:
1584
1595
1585
1596
## REQUIRED ZIP OUTPUT
1586
1597
1587
-
Codex must ALWAYS produce a repo-structured ZIP for every PR.
1598
+
Codex must ALWAYS produce a repo-structured ZIP for every completed Codex run.
1599
+
1600
+
This applies to:
1601
+
- implementation PRs
1602
+
- audit PRs
1603
+
- report-only PRs
1604
+
- validation-only PRs
1605
+
- EOD closeout runs
1606
+
- governance and cleanup runs
1588
1607
1589
1608
The ZIP must follow the existing CODEX ZIP STANDARD.
1590
1609
1591
-
The ZIP is required output, not optional.
1610
+
The ZIP must include all changed or preserved repo files from the run.
1611
+
1612
+
The ZIP is required output, not optional, and it does not replace required reports under `docs_build/dev/reports/`.
1592
1613
1593
1614
## HTML FILE RESTRICTIONS
1594
1615
@@ -1823,10 +1844,12 @@ Do NOT require:
1823
1844
1824
1845
## CODEX ZIP RETURN CONTRACT
1825
1846
1826
-
Codex must include the repo-structured ZIP in returned artifacts for user and ChatGPT review.
1847
+
Codex must include the repo-structured ZIP path in returned artifacts for user and ChatGPT review for every completed run.
1827
1848
1828
1849
The ZIP must still follow the CODEX ZIP STANDARD.
1829
1850
1851
+
If no repo files changed, the returned ZIP must contain the PR or EOD report proving the no-change result unless the run hard-stopped before outputs were produced.
1852
+
1830
1853
## CODE REVIEW EVIDENCE RULE
1831
1854
1832
1855
ChatGPT must not claim code review was completed unless it inspected uploaded source, ZIP contents, or `codex_review.diff`.
@@ -2044,6 +2067,7 @@ Required steps:
2044
2067
- local/origin sync = 0 0
2045
2068
5. Record final main commit.
2046
2069
6. Report final repository state.
2070
+
7. Produce the required repo-structured ZIP under `tmp/` containing the EOD report and any changed or preserved repo files from the closeout.
2047
2071
2048
2072
Required final state:
2049
2073
@@ -2235,6 +2259,9 @@ Completion hard stops:
2235
2259
- If required reports are missing, HARD STOP.
2236
2260
- If `docs_build/dev/reports/codex_review.diff` is missing, HARD STOP.
2237
2261
- If `docs_build/dev/reports/codex_changed_files.txt` is missing, HARD STOP.
2262
+
- If branch validation PASS/FAIL is missing, HARD STOP.
2263
+
- If the requirement-by-requirement PASS/FAIL checklist is missing, HARD STOP.
2264
+
- If the validation lane report is missing, HARD STOP.
2238
2265
- If manual validation notes are missing, HARD STOP.
2239
2266
- If the PR-specific report is missing, HARD STOP.
2240
2267
- If an instruction compliance checklist is required and missing, HARD STOP.
Copy file name to clipboardExpand all lines: docs_build/dev/ProjectInstructions/addendums/multi_team.md
+4Lines changed: 4 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -121,6 +121,7 @@ Required gate:
121
121
- blocked PRs with blockers
122
122
- next review queue
123
123
- final branch/worktree/local-origin sync
124
+
- repo-structured ZIP path under `tmp/`
124
125
125
126
OWNER_049 lesson:
126
127
- PRs #129, #132, and #134 were merge-approved and still required merge execution.
@@ -148,6 +149,7 @@ Required steps:
148
149
- local/origin sync = 0 0
149
150
5. Record final main commit.
150
151
6. Report final repository state.
152
+
7. Produce a repo-structured ZIP under `tmp/` that includes the EOD report and all changed or preserved repo files from the closeout.
151
153
152
154
Required final state:
153
155
@@ -165,6 +167,8 @@ Rules:
165
167
- A workstream is not considered closed until the repository is returned to main.
166
168
- A PI is not considered complete until main is current and synchronized.
167
169
- Do not leave Codex on a feature, team, workstream, recovery, governance, or owner branch after successful merge.
170
+
- A completed EOD closeout must produce the required ZIP even when the closeout changed no repo files; in that case, the ZIP must contain the EOD report proving the no-change result.
171
+
- The EOD ZIP does not replace the EOD report or other required reports under `docs_build/dev/reports/`.
168
172
- If merge succeeds but repository is not returned to main:
Copy file name to clipboardExpand all lines: docs_build/dev/ProjectInstructions/addendums/pr_workflow.md
+4Lines changed: 4 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -34,6 +34,10 @@ Define the standard pull request workflow for Game Foundry Studio.
34
34
- If validation fails, stop and report.
35
35
- If conflict occurs, stop and report.
36
36
- If OWNER decision is required, stop and report.
37
+
- Every completed Codex PR run must produce a repo-structured ZIP under `tmp/`.
38
+
- The ZIP rule applies to implementation, audit, report-only, validation-only, governance, and cleanup PRs.
39
+
- The ZIP must include all changed or preserved repo files from the run and must not replace required reports under `docs_build/dev/reports/`.
40
+
- If no repo files changed, Codex must still create a ZIP containing the PR report that proves the no-change result, unless the run hard-stopped before producing outputs.
# PR_26175_OWNER_047 Codex ZIP Required For All Runs
2
+
3
+
## Summary
4
+
This governance-only PR clarifies that every completed Codex run must produce a repo-structured ZIP under `tmp/`, including implementation PRs, audit PRs, report-only PRs, validation-only PRs, governance/cleanup runs, and EOD closeouts.
5
+
6
+
No runtime code changed.
7
+
8
+
## Located Governance Files
9
+
| File | Role | Change |
10
+
| --- | --- | --- |
11
+
|`docs_build/dev/PROJECT_INSTRUCTIONS.md`| Authoritative root project instructions for Codex outputs, report requirements, ZIP standard, PR completion, and EOD hard stops. | Updated |
12
+
|`docs_build/dev/ProjectInstructions/addendums/pr_workflow.md`| PR workflow addendum for standard PR execution rules. | Updated |
13
+
|`docs_build/dev/ProjectInstructions/addendums/multi_team.md`| Multi-team and EOD closeout addendum. | Updated |
14
+
|`docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md`| Index for the append-first Project Instructions operating system. | Reviewed; no output rules to update |
15
+
|`docs_build/dev/ProjectInstructions/TEAM_START_COMMANDS.md`| Team start and EOD reminder text. | Reviewed; no output rules to update |
16
+
17
+
## Requirement Checklist
18
+
| Requirement | Result | Evidence |
19
+
| --- | --- | --- |
20
+
| Use main branch only | PASS | Branch validation confirmed current branch is `main`. |
21
+
| Scope governance docs only | PASS | Changed files are governance docs and required reports only. |
22
+
| No runtime code changes | PASS | No `src/`, `assets/`, `toolbox/`, or test runtime files changed. |
23
+
| Locate active governance files | PASS | Active output rules found in root instructions, PR workflow addendum, and EOD multi-team addendum. |
24
+
| Require ZIP for every completed Codex run | PASS | Root instructions now require ZIPs for every completed Codex run. |
25
+
| Cover implementation, audit, report-only, validation-only, and EOD runs | PASS | Root instructions and PR/EOD addendums list those run types. |
26
+
| ZIP includes changed/preserved repo files | PASS | Root ZIP standard and PR/EOD addendums require inclusion of all changed or preserved repo files. |
27
+
| ZIP does not replace reports | PASS | Root instructions and addendums state ZIPs do not replace `docs_build/dev/reports/` files. |
| No-change runs still produce ZIP | PASS | Root instructions and PR/EOD addendums require a ZIP containing the PR/EOD no-change report unless the run hard-stopped before outputs. |
30
+
| Required reports created | PASS | This report, `codex_review.diff`, and `codex_changed_files.txt` were created/updated. |
31
+
| Repo-structured ZIP under `tmp/`| PASS | ZIP created at `tmp/PR_26175_OWNER_047-codex-zip-required-for-all-runs_delta.zip`. |
32
+
33
+
## Branch Validation
34
+
| Check | Result | Evidence |
35
+
| --- | --- | --- |
36
+
| Current branch is `main`| PASS |`git branch --show-current` returned `main`. |
37
+
| Branch validation recorded | PASS | This section records PASS/FAIL branch evidence. |
38
+
39
+
## Validation Lane Report
40
+
| Lane | Result | Evidence |
41
+
| --- | --- | --- |
42
+
| Docs-only validation | PASS | Changed paths are limited to `docs_build/dev/` governance and report files. |
0 commit comments