Skip to content

Commit 95b52a5

Browse files
committed
Reduce Audio SFX left description margins - PR_26145_015-audio-sfx-left-description-margin-reduction
1 parent db24d7b commit 95b52a5

2 files changed

Lines changed: 63 additions & 3 deletions

File tree

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
1+
# Audio / SFX Playground V2 Left Margin Reduction
2+
3+
PR: `PR_26145_015-audio-sfx-left-description-margin-reduction`
4+
5+
## Targeted Static Validation
6+
7+
- HTML external script/style guard for `tools/audio-sfx-playground-v2/index.html` - PASS
8+
- `git diff --check -- tools/audio-sfx-playground-v2/index.html tools/audio-sfx-playground-v2/styles/audioSfxLayoutDensity.css` - PASS, with existing LF/CRLF working-copy warning for CSS only
9+
10+
## Focused Playwright Validation
11+
12+
Command: custom Playwright validation using the repo test server and installed Microsoft Edge at `C:/Program Files (x86)/Microsoft/Edge/Application/msedge.exe`.
13+
14+
Result: PASS
15+
16+
Validated:
17+
18+
- Audio / SFX Playground V2 launches with no console or page errors.
19+
- `#styleDescription` has `margin-left: 5px`.
20+
- `#styleExamples` has `margin-left: 5px`.
21+
- `#settingsHelper` has `margin-left: 5px`.
22+
- The three guidance blocks align to the normal left field edge plus 5px.
23+
- The three guidance blocks extend to the same right edge as other left-column controls.
24+
- No horizontal clipping or overflow occurs.
25+
- Existing validation message alignment remains unchanged.
26+
27+
Measured layout highlights:
28+
29+
- Left field width: 236px
30+
- `#styleDescription`: left 60px, width 231px, no overflow
31+
- `#styleExamples`: left 60px, width 231px, no overflow
32+
- `#settingsHelper`: left 60px, width 231px, no overflow
33+
34+
## Required Workspace V2 Test
35+
36+
Command: `npm.cmd run test:workspace-v2`
37+
38+
Result: FAIL due environment browser install, not this PR's spacing change.
39+
40+
Observed:
41+
42+
- 72 tests collected.
43+
- 1 test passed.
44+
- 71 tests failed before executing page assertions because Playwright could not launch its managed Chromium executable.
45+
- Error: `Executable doesn't exist at C:\Users\DavidQ\AppData\Local\ms-playwright\chromium-1217\chrome-win64\chrome.exe`
46+
- Playwright requested: `npx playwright install`
47+
48+
## Full Samples Smoke
49+
50+
Skipped. This PR only impacts Audio / SFX Playground V2 left-column spacing/layout.
51+
52+
## Manual Validation Steps
53+
54+
1. Open `tools/audio-sfx-playground-v2/index.html` through the repo test server or Workspace V2 tile.
55+
2. Select a Sound Style with description/examples, such as `Atari-style`.
56+
3. Confirm the style description, examples, and helper text align near the left edge of the left panel.
57+
4. Confirm the text wraps naturally across the available left-column width.
58+
5. Confirm no clipping, horizontal scrolling, or console errors appear.
59+
60+
Expected outcome: the three guidance blocks use `5px` left margin and fill the left-column width more naturally.

tools/audio-sfx-playground-v2/styles/audioSfxLayoutDensity.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,15 +145,15 @@ body[data-tool-id="audio-sfx-playground-v2"] #sfxValidationMessage {
145145

146146
body[data-tool-id="audio-sfx-playground-v2"] .audio-sfx__style-description {
147147
min-height: 30px;
148-
margin: -1px 0 0 80px;
148+
margin: -1px 0 0 5px;
149149
line-height: 1.28;
150150
}
151151

152152
body[data-tool-id="audio-sfx-playground-v2"] .audio-sfx__style-examples {
153153
display: flex;
154154
flex-wrap: wrap;
155155
gap: 5px;
156-
margin: -4px 0 0 80px;
156+
margin: -4px 0 0 5px;
157157
padding: 0;
158158
list-style: none;
159159
}
@@ -172,7 +172,7 @@ body[data-tool-id="audio-sfx-playground-v2"] .audio-sfx__style-examples li {
172172

173173
body[data-tool-id="audio-sfx-playground-v2"] .audio-sfx__settings-helper {
174174
min-height: 34px;
175-
margin: -2px 0 1px 80px;
175+
margin: -2px 0 1px 5px;
176176
line-height: 1.28;
177177
}
178178

0 commit comments

Comments
 (0)