oops - PR_26155_106-109-tool-image-registry

Author: ToolboxAid

docs_build/dev/reports/tool-image-coverage-report.md

@@ -0,0 +1,67 @@
+# Tool Image Coverage Report
+
+| Tool ID | Tool Label | Badge Path | Badge Exists | Tool Path | Tool Image Exists | Fallback Used |
+| --- | --- | --- | --- | --- | --- | --- |
+| ai-assistant | AI Assistant | /assets/theme-v2/images/badges/ai-assistant.png | yes | /assets/theme-v2/images/tools/ai-assistant.png | yes | no |
+| project-workspace | Project Workspace | /assets/theme-v2/images/badges/project-workspace.png | yes | /assets/theme-v2/images/tools/project-workspace.png | yes | no |
+| game-design | Game Design | /assets/theme-v2/images/badges/game-design.png | yes | /assets/theme-v2/images/tools/game-design.png | yes | no |
+| game-configuration | Game Configuration | /assets/theme-v2/images/badges/game-configuration.png | yes | /assets/theme-v2/images/tools/game-configuration.png | yes | no |
+| assets | Assets | /assets/theme-v2/images/badges/assets.png | yes | /assets/theme-v2/images/tools/assets.png | yes | no |
+| colors | Colors | /assets/theme-v2/images/badges/colors.png | yes | /assets/theme-v2/images/tools/colors.png | yes | no |
+| fonts | Fonts | /assets/theme-v2/images/badges/fonts.png | yes | /assets/theme-v2/images/tools/fonts.png | yes | no |
+| sprites | Sprites | /assets/theme-v2/images/badges/sprites.png | no | /assets/theme-v2/images/tools/sprites.png | yes | yes |
+| characters | Characters | /assets/theme-v2/images/badges/characters.png | yes | /assets/theme-v2/images/tools/characters.png | yes | no |
+| objects | Objects | /assets/theme-v2/images/badges/objects.png | yes | /assets/theme-v2/images/tools/objects.png | yes | no |
+| worlds | Worlds | /assets/theme-v2/images/badges/worlds.png | yes | /assets/theme-v2/images/tools/worlds.png | yes | no |
+| animations | Animations | /assets/theme-v2/images/badges/animations.png | yes | /assets/theme-v2/images/tools/animation.png | yes | no |
+| audio | Audio | /assets/theme-v2/images/badges/audio.png | yes | /assets/theme-v2/images/tools/audio.png | yes | no |
+| music | Music | /assets/theme-v2/images/badges/music.png | no | /assets/theme-v2/images/tools/music.png | yes | yes |
+| voices | Voices | /assets/theme-v2/images/badges/voices.png | yes | /assets/theme-v2/images/tools/voices.png | yes | no |
+| videos | Videos | /assets/theme-v2/images/badges/videos.png | no | /assets/theme-v2/images/tools/videos.png | yes | yes |
+| build-game | Build Game | /assets/theme-v2/images/badges/build-game.png | yes | /assets/theme-v2/images/tools/build-game.png | yes | no |
+| game-testing | Game Testing | /assets/theme-v2/images/badges/game-testing.png | yes | /assets/theme-v2/images/tools/game-testing.png | yes | no |
+| controls | Controls | /assets/theme-v2/images/badges/controls.png | yes | /assets/theme-v2/images/tools/controls.png | yes | no |
+| hitboxes | Hitboxes | /assets/theme-v2/images/badges/hitboxes.png | yes | /assets/theme-v2/images/tools/hitboxes.png | yes | no |
+| saved-data | Saved Data | /assets/theme-v2/images/badges/saved-data.png | no | /assets/theme-v2/images/tools/saved-data.png | yes | yes |
+| debug | Debug | /assets/theme-v2/images/badges/debug.png | yes | /assets/theme-v2/images/tools/debug.png | yes | no |
+| performance | Performance | /assets/theme-v2/images/badges/performance.png | no | /assets/theme-v2/images/tools/performance.png | yes | yes |
+| events | Events | /assets/theme-v2/images/badges/events.png | yes | /assets/theme-v2/images/tools/events.png | yes | no |
+| publish | Publish | /assets/theme-v2/images/badges/publish.png | no | /assets/theme-v2/images/tools/publish.png | yes | yes |
+| marketplace | Marketplace | /assets/theme-v2/images/badges/marketplace.png | yes | /assets/theme-v2/images/tools/marketplace.png | yes | no |
+| community | Community | /assets/theme-v2/images/badges/community.png | yes | /assets/theme-v2/images/tools/community.png | yes | no |
+| languages | Languages | /assets/theme-v2/images/badges/languages.png | yes | /assets/theme-v2/images/tools/languages.png | yes | no |
+| achievements | Achievements | /assets/theme-v2/images/badges/achievement.png | yes | /assets/theme-v2/images/tools/achievement.png | yes | no |
+| ratings | Ratings | /assets/theme-v2/images/badges/ratings.png | no | /assets/theme-v2/images/tools/ratings.png | yes | yes |
+| cloud | Cloud | /assets/theme-v2/images/badges/cloud.png | yes | /assets/theme-v2/images/tools/cloud.png | yes | no |
+| code | Custom Extensions | /assets/theme-v2/images/badges/code.png | yes | /assets/theme-v2/images/tools/code.png | yes | no |
+| midi | MIDI | /assets/theme-v2/images/badges/midi.png | no | /assets/theme-v2/images/tools/midi.png | yes | yes |
+| particles | Particles | /assets/theme-v2/images/badges/particles.png | no | /assets/theme-v2/images/tools/particles.png | yes | yes |
+| audio-effects | Audio Effects | /assets/theme-v2/images/badges/audio-effects.png | yes | /assets/theme-v2/images/tools/audio-effects.png | yes | no |
+| speech-to-text | Voice Capture | /assets/theme-v2/images/badges/speech-to-text.png | no | /assets/theme-v2/images/tools/speech-to-text.png | yes | yes |
+| text-to-speech | Voice Output | /assets/theme-v2/images/badges/text-to-speech.png | no | /assets/theme-v2/images/tools/text-to-speech.png | no | yes |
+| users | Users | /assets/theme-v2/images/badges/users.png | no | /assets/theme-v2/images/tools/users.png | yes | yes |
+| environments | Environments | /assets/theme-v2/images/badges/environments.png | yes | /assets/theme-v2/images/tools/environments.png | yes | no |
+| game-migration | Game Migration | /assets/theme-v2/images/badges/game-migration.png | yes | /assets/theme-v2/images/tools/game-migration.png | yes | no |
+| platform-settings | Platform Settings | /assets/theme-v2/images/badges/platform-settings.png | no | /assets/theme-v2/images/tools/platform-settings.png | yes | yes |
+
+## Missing Images
+
+- sprites (Sprites): badge missing, tool exists
+- music (Music): badge missing, tool exists
+- videos (Videos): badge missing, tool exists
+- saved-data (Saved Data): badge missing, tool exists
+- performance (Performance): badge missing, tool exists
+- publish (Publish): badge missing, tool exists
+- ratings (Ratings): badge missing, tool exists
+- midi (MIDI): badge missing, tool exists
+- particles (Particles): badge missing, tool exists
+- speech-to-text (Voice Capture): badge missing, tool exists
+- text-to-speech (Voice Output): badge missing, tool missing
+- users (Users): badge missing, tool exists
+- platform-settings (Platform Settings): badge missing, tool exists
+
+## Validation Notes
+
+- Coverage generated from `getToolImageCoverage()` in `toolbox/toolRegistry.js`.
+- Missing files are reported as coverage gaps and resolve through `/assets/theme-v2/images/image-missing.svg` at runtime.
+- No generated image files were added in this PR.

docs_build/dev/reports/tool-image-mapping.md

@@ -0,0 +1,51 @@
+# Tool Image Mapping
+
+## Mapping Summary
+
+- Registry entries mapped: 41.
+- Existing no-size-suffix images are used where present.
+- No images were generated.
+- No image files were renamed.
+- `achievements` maps to existing singular artwork files `achievement.png` where present.
+- `animations` uses existing `badges/animations.png` and existing `tools/animation.png`.
+- Missing no-size-suffix artwork falls back through registry helpers at runtime and is reported below.
+- Stale local Toolbox placeholder image fields were removed from `toolbox/tools-page-accordions.js` so registry data is the active image source.
+
+## Missing Artwork
+
+- sprites (Sprites): badge missing, tool exists
+- music (Music): badge missing, tool exists
+- videos (Videos): badge missing, tool exists
+- saved-data (Saved Data): badge missing, tool exists
+- performance (Performance): badge missing, tool exists
+- publish (Publish): badge missing, tool exists
+- ratings (Ratings): badge missing, tool exists
+- midi (MIDI): badge missing, tool exists
+- particles (Particles): badge missing, tool exists
+- speech-to-text (Voice Capture): badge missing, tool exists
+- text-to-speech (Voice Output): badge missing, tool missing
+- users (Users): badge missing, tool exists
+- platform-settings (Platform Settings): badge missing, tool exists
+
+## Path Rules
+
+- Badge root: `/assets/theme-v2/images/badges/`.
+- Tool root: `/assets/theme-v2/images/tools/`.
+- Banned size suffixes are not used in registry image fields.
+- Existing suffixed files, such as `*-1024.png`, were not referenced by the registry.
+
+## Validation Notes
+
+- `node --check toolbox/toolRegistry.js` - PASS
+- `node --check toolbox/tools-page-accordions.js` - PASS
+- `node --check assets/theme-v2/js/tool-display-mode.js` - PASS
+- `node --check scripts/run-targeted-test-lanes.mjs` - PASS
+- `node --check tests/playwright/tools/ToolImageRegistry.spec.mjs` - PASS
+- `npm run test:lane:tool-images` - PASS, 4 Playwright tests
+- `git diff --check` - PASS
+
+## Manual Test Notes
+
+- Open `toolbox/index.html?role=admin` and confirm Toolbox cards render preview images and badges without 404s.
+- Open `toolbox/project-workspace/index.html`, `toolbox/game-design/index.html`, `toolbox/game-configuration/index.html`, and `toolbox/build-game/index.html` and confirm Tool Display Mode badge/tool images render without console errors.
+- Confirm any missing artwork uses the shared `image-missing.svg` fallback instead of a broken image request.

docs_build/dev/reports/tool-image-registry-contract.md

@@ -0,0 +1,49 @@
+# Tool Image Registry Contract
+
+Stacked PRs:
+- PR_26155_106-tool-image-registry-contract
+- PR_26155_107-tool-image-mapping
+- PR_26155_108-tool-image-coverage-report
+- PR_26155_109-tool-image-targeted-msj-tests
+
+## Contract
+
+- Every active/planned Toolbox registry entry now defines direct `badge` and `tool` fields.
+- `badge` paths are rooted under `/assets/theme-v2/images/badges/`.
+- `tool` paths are rooted under `/assets/theme-v2/images/tools/`.
+- The registry does not use a `hero` image field.
+- Registry image paths avoid banned size suffixes: `-64`, `-1024`, and `-400x225`.
+- Missing artwork resolves through the registry-owned `TOOL_IMAGE_FALLBACK` helper, not page-specific fallback logic.
+
+## Runtime Consumers
+
+- `toolbox/tools-page-accordions.js` imports `getToolRegistry`, `getToolImageSource`, and `TOOL_IMAGE_FALLBACK` from `toolbox/toolRegistry.js`.
+- The transitional Toolbox renderer no longer carries local `tool.image` placeholder fields; card preview and badge sources come from the registry helper.
+- `assets/theme-v2/js/tool-display-mode.js` dynamically imports `toolbox/toolRegistry.js` and applies `getToolImageSource()` for badge/tool display images.
+
+## Validation
+
+- `node --check toolbox/toolRegistry.js` - PASS
+- `node --check toolbox/tools-page-accordions.js` - PASS
+- `node --check assets/theme-v2/js/tool-display-mode.js` - PASS
+- `node --check scripts/run-targeted-test-lanes.mjs` - PASS
+- `node --check tests/playwright/tools/ToolImageRegistry.spec.mjs` - PASS
+- `npm run test:lane:tool-images` - PASS, 4 Playwright tests
+- `git diff --check` - PASS
+
+## Targeted Lane Notes
+
+- Impacted lane: `tool-images`.
+- Skipped lanes: `workspace-contract`, `project-workspace`, `game-design`, `game-configuration`, `build-path`, `tools-progress`, `tool-navigation`, `tool-display-mode`, `tool-runtime`, `game-runtime`, `integration`, `engine-src`, `samples`.
+- Skipped-lane rationale: this PR changes Toolbox image registry metadata, the Toolbox image consumer, and Tool Display Mode image consumption only; it does not change launch/navigation contracts, DB/auth/persistence, samples, engine runtime, or unrelated tool behavior.
+- `npm run test:workspace-v2` was skipped because that command name is legacy for the Project Workspace lane and the narrow image-registry lane proves this scoped change.
+
+## Manual Test Notes
+
+- Open `toolbox/index.html?role=admin` and confirm Toolbox cards render preview images and badges without 404s.
+- Open `toolbox/project-workspace/index.html`, `toolbox/game-design/index.html`, `toolbox/game-configuration/index.html`, and `toolbox/build-game/index.html` and confirm Tool Display Mode badge/tool images render without console errors.
+- Confirm any missing artwork uses the shared `image-missing.svg` fallback instead of a broken image request.
+
+## Theme V2 Gap Findings
+
+No new CSS was added. No Theme V2 styling gap was found for this registry/image mapping change.

docs_build/dev/reports/tool-image-targeted-msj-tests.md

@@ -0,0 +1,46 @@
+# Tool Image Targeted MSJ Tests
+
+## Test Lane
+
+- Added package script: `npm run test:lane:tool-images`.
+- Added lane registration in `scripts/run-targeted-test-lanes.mjs`.
+- Added Playwright spec: `tests/playwright/tools/ToolImageRegistry.spec.mjs`.
+
+## Covered Behavior
+
+- Every active/planned registry tool has `badge` and `tool` fields.
+- Registry paths stay under the approved Theme V2 badge/tool directories.
+- Registry paths do not contain banned size suffixes.
+- Missing artwork uses the registry fallback.
+- Toolbox cards consume registry image sources.
+- Representative tool pages consume registry images in Tool Display Mode.
+- Page load checks reported no console errors, page errors, failed requests, or request failures.
+
+## Validation
+
+- `node --check toolbox/toolRegistry.js` - PASS
+- `node --check toolbox/tools-page-accordions.js` - PASS
+- `node --check assets/theme-v2/js/tool-display-mode.js` - PASS
+- `node --check scripts/run-targeted-test-lanes.mjs` - PASS
+- `node --check tests/playwright/tools/ToolImageRegistry.spec.mjs` - PASS
+- `npm run test:lane:tool-images` - PASS, 4 Playwright tests
+- `git diff --check` - PASS
+
+## Targeted Lane Notes
+
+- Impacted lane: `tool-images`.
+- Skipped lanes: `workspace-contract`, `project-workspace`, `game-design`, `game-configuration`, `build-path`, `tools-progress`, `tool-navigation`, `tool-display-mode`, `tool-runtime`, `game-runtime`, `integration`, `engine-src`, `samples`.
+- Skipped-lane rationale: this PR changes Toolbox image registry metadata, the Toolbox image consumer, and Tool Display Mode image consumption only; it does not change launch/navigation contracts, DB/auth/persistence, samples, engine runtime, or unrelated tool behavior.
+- `npm run test:workspace-v2` was skipped because that command name is legacy for the Project Workspace lane and the narrow image-registry lane proves this scoped change.
+
+## Manual Test Notes
+
+- Open `toolbox/index.html?role=admin` and confirm Toolbox cards render preview images and badges without 404s.
+- Open `toolbox/project-workspace/index.html`, `toolbox/game-design/index.html`, `toolbox/game-configuration/index.html`, and `toolbox/build-game/index.html` and confirm Tool Display Mode badge/tool images render without console errors.
+- Confirm any missing artwork uses the shared `image-missing.svg` fallback instead of a broken image request.
+
+## Coverage Notes
+
+- Playwright V8 coverage was produced by the targeted lane.
+- Changed browser runtime files covered: `toolbox/toolRegistry.js`, `toolbox/tools-page-accordions.js`, and `assets/theme-v2/js/tool-display-mode.js`.
+- Node/test runner files are not browser runtime coverage targets.