Skip to content

Commit 82ff294

Browse files
ToolboxAidToolboxAid
authored
Merge PR #6: [codex] PR_26171_031 idea board inline tree grid actions
[codex] PR_26171_031 idea board inline tree grid actions
2 parents 4d5cc50 + f79af9b commit 82ff294

42 files changed

Lines changed: 1966 additions & 2656 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎docs_build/dev/codex_commands.md‎

Lines changed: 37 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,39 @@
11
# Codex Commands
22

3-
- Read skill: repo-build.
4-
- Read skill: github:yeet.
5-
- Read source of truth: docs_build/dev/PROJECT_INSTRUCTIONS.md.
6-
- Re-read original Idea Board request from prior conversation and docs_build/pr/BUILD_PR_26170_002-idea-board-tool.md.
7-
- Inspected toolbox/_tool_template-v2/index.html.
8-
- Inspected toolbox/idea-board/index.html and toolbox/idea-board/index.js.
9-
- Inspected tests/playwright/tools/IdeaBoardTableNotes.spec.mjs.
10-
- Inspected tests/playwright/tools/ToolboxRoutePages.spec.mjs.
11-
- Inspected tests/playwright/tools/RootToolsFutureState.spec.mjs.
12-
- git fetch origin main --prune.
13-
- git pull --ff-only origin main.
14-
- git switch -c codex/fix-idea-board-pr-workflow.
15-
- node --check toolbox/idea-board/index.js.
16-
- node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs.
17-
- node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs.
18-
- node --check tests/playwright/tools/RootToolsFutureState.spec.mjs.
19-
- Inline HTML guard for toolbox/idea-board/index.html.
20-
- npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line.
21-
- npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches".
22-
- npm run test:workspace-v2.
23-
- git diff --check.
3+
## PR
4+
- `PR_26171_031-idea-board-inline-tree-grid-actions`
5+
6+
## Source Documents
7+
- `docs_build/dev/PROJECT_INSTRUCTIONS.md`
8+
- `docs_build/pr/PLAN_PR_26171_031-idea-board-inline-tree-grid-actions.md`
9+
- `docs_build/pr/BUILD_PR_26171_031-idea-board-inline-tree-grid-actions.md`
10+
- `docs_build/pr/APPLY_PR_26171_031-idea-board-inline-tree-grid-actions.md`
11+
12+
## Git Workflow Commands
13+
- `git branch --show-current`
14+
- `git status -sb`
15+
- `git branch --list`
16+
- `git pull --ff-only origin main`
17+
- `git switch -c codex/pr-26171-031-idea-board-inline-tree-grid-actions`
18+
19+
## Inspection Commands
20+
- `Get-Content -Raw docs_build/dev/PROJECT_INSTRUCTIONS.md`
21+
- `Get-Content -Raw toolbox/idea-board/index.html`
22+
- `Get-Content -Raw toolbox/idea-board/index.js`
23+
- `Get-Content -Raw tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
24+
- `Get-Content -Raw tests/playwright/tools/ToolboxRoutePages.spec.mjs`
25+
26+
## Validation Commands
27+
- `node --check toolbox/idea-board/index.js`
28+
- `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
29+
- `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`
30+
- `node -e "<Idea Board inline HTML restriction guard>"`
31+
- `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line`
32+
- `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"`
33+
- `npm run test:workspace-v2`
34+
35+
## Artifact Commands
36+
- Generate `docs_build/dev/reports/codex_changed_files.txt`
37+
- Generate `docs_build/dev/reports/codex_review.diff`
38+
- Create `tmp/PR_26171_031-idea-board-inline-tree-grid-actions_delta.zip`
39+
- Verify ZIP size and repo-relative paths

‎docs_build/dev/commit_comment.txt‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
PR_26171_030 idea board workflow fix
1+
PR_26171_031 idea board inline tree grid actions
22

3-
- fix Idea Board selected-idea notes context
4-
- update targeted Playwright and workspace-v2 validation harness
5-
- refresh Idea Board workflow docs and reports
3+
- render selected idea notes directly under the idea row
4+
- add inline idea and note add/edit/delete workflows
5+
- update targeted Idea Board Playwright coverage and reports

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 41 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
1-
# Codex Changed Files - PR_26171_030-idea-board-workflow-fix
1+
# Codex Changed Files - PR_26171_031-idea-board-inline-tree-grid-actions
22

33
## Git Workflow
4-
- Branch: `codex/fix-idea-board-pr-workflow`
5-
- Base: `origin/main`
6-
- PR URL: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/4
7-
- Merge conflicts: resolved in `docs_build/dev/reports/codex_changed_files.txt` and `docs_build/dev/reports/codex_review.diff` by regenerating both reports from the final `origin/main` diff.
8-
- Commit hash, push result, merge result, and final main commit: reported after commit, push, PR merge, and final main pull.
4+
- Current branch: `codex/pr-26171-031-idea-board-inline-tree-grid-actions`
5+
- Expected starting branch: `main` (PASS before branch creation).
6+
- Created branch: `codex/pr-26171-031-idea-board-inline-tree-grid-actions`.
7+
- Push result: pending until after commit.
8+
- PR URL: pending until after push.
9+
- Merge result: pending until after PR validation/merge.
10+
- Final main commit: pending until after merge and final pull.
911

1012
## Changed Files
1113
- docs_build/dev/codex_commands.md
@@ -43,23 +45,10 @@
4345
- docs_build/dev/reports/testing_lane_execution_report.md
4446
- docs_build/dev/reports/validation_cache_report.md
4547
- docs_build/dev/reports/zero_browser_preflight_report.md
46-
- docs_build/pr/APPLY_PR_26171_026-idea-board-template-cleanup.md
47-
- docs_build/pr/APPLY_PR_26171_027-idea-board-table-work-surface.md
48-
- docs_build/pr/APPLY_PR_26171_028-idea-board-notes-table-governance.md
49-
- docs_build/pr/APPLY_PR_26171_029-idea-board-validation-playwright.md
50-
- docs_build/pr/APPLY_PR_26171_030-idea-board-workflow-fix.md
51-
- docs_build/pr/BUILD_PR_26171_026-idea-board-template-cleanup.md
52-
- docs_build/pr/BUILD_PR_26171_027-idea-board-table-work-surface.md
53-
- docs_build/pr/BUILD_PR_26171_028-idea-board-notes-table-governance.md
54-
- docs_build/pr/BUILD_PR_26171_029-idea-board-validation-playwright.md
55-
- docs_build/pr/BUILD_PR_26171_030-idea-board-workflow-fix.md
56-
- docs_build/pr/PLAN_PR_26171_026-idea-board-template-cleanup.md
57-
- docs_build/pr/PLAN_PR_26171_027-idea-board-table-work-surface.md
58-
- docs_build/pr/PLAN_PR_26171_028-idea-board-notes-table-governance.md
59-
- docs_build/pr/PLAN_PR_26171_029-idea-board-validation-playwright.md
60-
- docs_build/pr/PLAN_PR_26171_030-idea-board-workflow-fix.md
48+
- docs_build/pr/APPLY_PR_26171_031-idea-board-inline-tree-grid-actions.md
49+
- docs_build/pr/BUILD_PR_26171_031-idea-board-inline-tree-grid-actions.md
50+
- docs_build/pr/PLAN_PR_26171_031-idea-board-inline-tree-grid-actions.md
6151
- tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
62-
- tests/playwright/tools/RootToolsFutureState.spec.mjs
6352
- tests/playwright/tools/ToolboxRoutePages.spec.mjs
6453
- toolbox/idea-board/index.html
6554
- toolbox/idea-board/index.js
@@ -100,46 +89,45 @@
10089
- M docs_build/dev/reports/testing_lane_execution_report.md
10190
- M docs_build/dev/reports/validation_cache_report.md
10291
- M docs_build/dev/reports/zero_browser_preflight_report.md
103-
- A docs_build/pr/APPLY_PR_26171_026-idea-board-template-cleanup.md
104-
- A docs_build/pr/APPLY_PR_26171_027-idea-board-table-work-surface.md
105-
- A docs_build/pr/APPLY_PR_26171_028-idea-board-notes-table-governance.md
106-
- A docs_build/pr/APPLY_PR_26171_029-idea-board-validation-playwright.md
107-
- A docs_build/pr/APPLY_PR_26171_030-idea-board-workflow-fix.md
108-
- A docs_build/pr/BUILD_PR_26171_026-idea-board-template-cleanup.md
109-
- A docs_build/pr/BUILD_PR_26171_027-idea-board-table-work-surface.md
110-
- A docs_build/pr/BUILD_PR_26171_028-idea-board-notes-table-governance.md
111-
- A docs_build/pr/BUILD_PR_26171_029-idea-board-validation-playwright.md
112-
- A docs_build/pr/BUILD_PR_26171_030-idea-board-workflow-fix.md
113-
- A docs_build/pr/PLAN_PR_26171_026-idea-board-template-cleanup.md
114-
- A docs_build/pr/PLAN_PR_26171_027-idea-board-table-work-surface.md
115-
- A docs_build/pr/PLAN_PR_26171_028-idea-board-notes-table-governance.md
116-
- A docs_build/pr/PLAN_PR_26171_029-idea-board-validation-playwright.md
117-
- A docs_build/pr/PLAN_PR_26171_030-idea-board-workflow-fix.md
118-
- A tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
119-
- M tests/playwright/tools/RootToolsFutureState.spec.mjs
92+
- A docs_build/pr/APPLY_PR_26171_031-idea-board-inline-tree-grid-actions.md
93+
- A docs_build/pr/BUILD_PR_26171_031-idea-board-inline-tree-grid-actions.md
94+
- A docs_build/pr/PLAN_PR_26171_031-idea-board-inline-tree-grid-actions.md
95+
- M tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
12096
- M tests/playwright/tools/ToolboxRoutePages.spec.mjs
12197
- M toolbox/idea-board/index.html
122-
- A toolbox/idea-board/index.js
123-
124-
## Copied Files Verified
125-
- PASS: Re-read `toolbox/_tool_template-v2/index.html`; verified Theme V2 stylesheet, header/footer partials, left/center/right `tool-workspace tool-workspace--wide` shell, accordion stack, ToolDisplayMode host, and external Theme V2 scripts.
126-
- PASS: Verified `toolbox/_tool_template-v2` currently contains `index.html` only; there was no template-local JavaScript file to copy.
127-
- PASS: Verified `toolbox/idea-board/index.html` adapts the template structure with Theme V2 CSS, header/footer partials, left and right tool columns, center panel, ToolDisplayMode host, accordions, and external scripts.
128-
- PASS: Verified no inline `<script>`, `<style>`, `style=`, or inline event handlers in `toolbox/idea-board/index.html`.
98+
- M toolbox/idea-board/index.js
12999

130100
## Requirement Evidence
131-
- PASS 026: Idea Board is migrated to Tool Template V2 / Theme V2 shell with clean left/center/right layout and external-only JavaScript/CSS.
132-
- PASS 027: Idea Board is table-first; the primary work surface is `data-idea-board-table`, with selected idea row controls and no form-first primary workflow.
133-
- PASS 028: Notes are scoped to the selected idea through `data-idea-board-selected-title`, `data-idea-board-notes-table`, and selected idea state in `toolbox/idea-board/index.js`; Add Note opens an inline row inside the selected notes table; creator notes expose Edit/Delete on the right; system notes expose neither Edit nor Delete; note metadata is table columns.
134-
- PASS 029: Targeted Playwright coverage validates table columns, selected idea switching, scoped note add/edit/delete, system note lockout, placeholder-only Create Project, and no mutating API calls.
135-
- PASS 030: Workspace V2 validation harness pins public API/site env to the ephemeral test server and updates current registry/count expectations so the required workspace lane passes on the rebased branch.
101+
- PASS: Main Idea Board table removes the Owner column.
102+
- PASS: Main table columns are Idea, Pitch, Status, Updated, Notes, Actions.
103+
- PASS: Notes column shows note counts such as `2 Notes` and `0 Notes`.
104+
- PASS: Selected idea expands as `data-idea-board-expanded-row` immediately after its matching `data-idea-board-idea-row`.
105+
- PASS: Detached `Notes for Sky Orchard` section was removed.
106+
- PASS: Visible `Selected idea context` text was removed.
107+
- PASS: Notes subtable no longer shows Type, Created By, Created, or Updated columns.
108+
- PASS: Notes subtable visible columns are Note and Actions.
109+
- PASS: Idea normal rows expose Edit and Delete in the Actions column.
110+
- PASS: Idea edit/add rows expose Save and Cancel.
111+
- PASS: Idea edit Status field is a `select` dropdown.
112+
- PASS: Note normal rows expose Edit and Delete when deletion is allowed.
113+
- PASS: System notes expose Edit and do not expose Delete.
114+
- PASS: Note edit/add rows expose Save and Cancel.
115+
- PASS: Add Idea opens an inline idea row inside the main table.
116+
- PASS: Add Note opens an inline note row inside the selected idea expanded row.
117+
- PASS: The implementation changes runtime HTML/JS and Playwright tests; this is not docs-only work.
118+
- PASS: No detached notes panels were introduced.
119+
- PASS: The primary workflow remains table-first, not form-first.
136120

137-
## Validation After Conflict Resolution
121+
## Validation
138122
- PASS: `node --check toolbox/idea-board/index.js`.
139123
- PASS: `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`.
140124
- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`.
141-
- PASS: `node --check tests/playwright/tools/RootToolsFutureState.spec.mjs`.
142125
- PASS: Idea Board inline HTML guard found no inline `<script>`, `<style>`, `style=`, or inline event handlers.
143126
- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line` (1 passed).
144127
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"` (1 passed).
145128
- PASS: `npm run test:workspace-v2` (5 passed).
129+
- SKIP: Full samples smoke was not run; samples are not in scope and the user explicitly prohibited full samples smoke.
130+
131+
## ZIP
132+
- Path: `tmp/PR_26171_031-idea-board-inline-tree-grid-actions_delta.zip`.
133+
- Size and contents: reported after final ZIP generation.

0 commit comments

Comments
 (0)