Skip to content

Commit 80f732e

Browse files
committed
ALFA 009 fix bootstrap team forwarding
1 parent 3594ef8 commit 80f732e

9 files changed

Lines changed: 238 additions & 333 deletions

dev/reports/PR_26171_ALFA_009-team-aware-bootstrap_manual-validation-notes.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,21 @@ Expected result:
4545
npm run dev:bootstrap -- --team owner
4646
npm run dev:bootstrap -- --team bravo
4747
npm run dev:bootstrap -- --team charlie
48+
npm run dev:bootstrap -- charlie
4849
npm run dev:bootstrap -- --team delta
4950
npm run dev:bootstrap -- --team echo
5051
npm run dev:bootstrap -- --team foxtrot
5152
npm run dev:bootstrap -- --team golf
5253
npm run dev:bootstrap -- --team hotel
5354
```
5455

56+
For Charlie, both forms should show:
57+
58+
- `Team: charlie`
59+
- `Web URL: http://127.0.0.1:5530`
60+
- `API URL: http://127.0.0.1:5531/api`
61+
- `Browser launch: http://127.0.0.1:5530/index.html`
62+
5563
## Failure Checks
5664

5765
```powershell

dev/reports/PR_26171_ALFA_009-team-aware-bootstrap_report.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ Per OWNER instruction, those uncommitted changes were discarded with `git reset
3030
- Added focused node tests for team resolution, role offsets, invalid team/role validation, script wiring, `.env` loading behavior, and bootstrap diagnostics.
3131
- Added automatic browser launch for owner-role `dev:bootstrap` after the API and web servers are both ready.
3232
- Suppressed automatic browser launch for the `codex` role.
33+
- Fixed npm argument forwarding/parsing so both `--team charlie` and positional `charlie` select the same team after the package script's `--mode bootstrap` argument.
3334

3435
## Supported Teams
3536

@@ -96,6 +97,8 @@ npm run dev:bootstrap -- --team alfa --role codex
9697
- Browser launch happens only after both API and web servers are ready.
9798
- The Alfa owner launch target is `http://127.0.0.1:5510/index.html`.
9899
- The Alfa codex launch target is suppressed while using web `5512` and API `5513`.
100+
- The Charlie launch target is `http://127.0.0.1:5530/index.html` for both `npm run dev:bootstrap -- --team charlie` and `npm run dev:bootstrap -- charlie`.
101+
- Computed team/role ports override any `.env` port values loaded before bootstrap startup.
99102

100103
## Files Changed
101104

dev/reports/PR_26171_ALFA_009-team-aware-bootstrap_requirement-checklist.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@
1616
| Do not use single-letter public team commands | PASS | Scan returned no matches in new bootstrap files. |
1717
| Validate unknown team names | PASS | `omega` fails clearly with supported team list. |
1818
| Validate unknown role names | PASS | `reviewer` fails clearly with supported role list. |
19+
| Support `--team` argument forwarding | PASS | `npm run dev:bootstrap -- --team charlie` resolves Charlie ports. |
20+
| Support positional team forwarding | PASS | `npm run dev:bootstrap -- charlie` resolves Charlie ports. |
21+
| Prevent `.env` port override | PASS | Unit test confirms computed team/role ports overwrite loaded API/site port values. |
1922
| Load environment | PASS | Orchestrator loads `.env` values without overriding existing environment values. |
2023
| Resolve team ports | PASS | Unit tests cover all teams and both roles. |
2124
| Start Local API | PASS | `dev:bootstrap` starts the existing Local API server on resolved API port. |

dev/reports/PR_26171_ALFA_009-team-aware-bootstrap_validation-report.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,13 @@
1313
| `npm run validate:canonical-structure` | PASS | Canonical repository structure guardrail passed. |
1414
| `npm run dev:bootstrap -- --team alfa` | PASS | Started with team `alfa`, role `owner`, web `5510`, API `5511`, launched browser to `http://127.0.0.1:5510/index.html`, then process tree was stopped. |
1515
| `npm run dev:bootstrap -- --team alfa --role codex` | PASS | Started with team `alfa`, role `codex`, web `5512`, API `5513`, suppressed browser launch, then process tree was stopped. |
16+
| `npm run dev:bootstrap -- --team charlie` | PASS | Started with team `charlie`, role `owner`, web `5530`, API `5531`, launched browser to `http://127.0.0.1:5530/index.html`, then process tree was stopped. |
17+
| `npm run dev:bootstrap -- charlie` | PASS | Positional team forwarding selected team `charlie`, web `5530`, API `5531`, and browser target `http://127.0.0.1:5530/index.html`. |
18+
| `npm run dev:bootstrap -- --team bravo` | PASS | Started with team `bravo`, role `owner`, web `5520`, API `5521`, and browser target `http://127.0.0.1:5520/index.html`. |
1619
| `npm run dev:bootstrap -- --team omega` | PASS | Failed clearly with supported team list. |
1720
| `npm run dev:bootstrap -- --team alfa --role reviewer` | PASS | Failed clearly with supported role list. |
1821
| `npm run dev:local-api` | PASS | Legacy command started and printed legacy startup diagnostics, then process tree was stopped. |
1922

2023
## Notes
2124

22-
The startup-command validations used short-lived process launches and `taskkill /T /F` cleanup after expected diagnostics appeared, so no dev servers were left running. The owner-role validation opened the configured browser target after both server diagnostics were available.
25+
The startup-command validations used short-lived process launches and `taskkill /T /F` cleanup after expected diagnostics appeared, so no dev servers were left running. Owner-role validations opened the configured browser target after both server diagnostics were available. Unit coverage verifies loaded `.env` port values are overwritten by computed team/role ports.

dev/reports/codex_changed_files.txt

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,18 @@ M dev/reports/PR_26171_ALFA_009-team-aware-bootstrap_manual-validation-notes.md
44
M dev/reports/PR_26171_ALFA_009-team-aware-bootstrap_requirement-checklist.md
55
M dev/reports/PR_26171_ALFA_009-team-aware-bootstrap_validation-report.md
66
M dev/scripts/start-dev.mjs
7+
M dev/scripts/team-port-config.mjs
78
M dev/tests/dev-runtime/TeamAwareBootstrap.test.mjs
89

910
# git ls-files --others --exclude-standard
1011
(no output)
1112

1213
# git diff --stat
13-
...team-aware-bootstrap_manual-validation-notes.md | 2 +
14-
...R_26171_ALFA_009-team-aware-bootstrap_report.md | 10 ++
15-
...9-team-aware-bootstrap_requirement-checklist.md | 3 +
16-
...A_009-team-aware-bootstrap_validation-report.md | 8 +-
17-
dev/scripts/start-dev.mjs | 76 +++++++++++--
18-
dev/tests/dev-runtime/TeamAwareBootstrap.test.mjs | 119 +++++++++++++++++++++
19-
6 files changed, 208 insertions(+), 10 deletions(-)
14+
...team-aware-bootstrap_manual-validation-notes.md | 8 ++++++
15+
...R_26171_ALFA_009-team-aware-bootstrap_report.md | 3 ++
16+
...9-team-aware-bootstrap_requirement-checklist.md | 3 ++
17+
...A_009-team-aware-bootstrap_validation-report.md | 5 +++-
18+
dev/scripts/start-dev.mjs | 2 +-
19+
dev/scripts/team-port-config.mjs | 29 +++++++++++++++++++-
20+
dev/tests/dev-runtime/TeamAwareBootstrap.test.mjs | 32 +++++++++++++++++++++-
21+
7 files changed, 78 insertions(+), 4 deletions(-)

0 commit comments

Comments
 (0)