Merge PR_26179_ALFA_012 Object Properties MVP

Author: ToolboxAid

assets/toolbox/objects/js/index.js

@@ -0,0 +1,26 @@
+# PR_26179_ALFA_012 Branch Validation
+
+Branch: PR_26179_ALFA_012-objects-properties-mvp
+Base stack: PR_26179_ALFA_011-objects-manager-mvp
+
+## Gates
+- Current branch is PR_26179_ALFA_012-objects-properties-mvp: PASS
+- Project Instructions loaded from `dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS.md`: PASS
+- Canonical report path `dev/reports/`: PASS
+- Canonical ZIP path `dev/workspace/zips/`: PASS
+- No `docs_build/` report output created: PASS
+- No `tmp/` ZIP output created: PASS
+- One PR purpose only: PASS
+- No API architecture change: PASS
+
+## Validation Commands
+- `node --check assets/toolbox/objects/js/index.js`: PASS
+- `node --check src/dev-runtime/toolbox-api/alfa-tool-services.mjs`: PASS
+- `node --check dev/tests/playwright/tools/ObjectsTool.spec.mjs`: PASS
+- `node --test dev/tests/dev-runtime/ObjectsApiService.test.mjs`: PASS
+- `npx playwright test dev/tests/playwright/tools/ObjectsTool.spec.mjs -g "Object Details panel"`: PASS
+- `npx playwright test dev/tests/playwright/tools/ObjectsTool.spec.mjs`: PASS
+- `git diff --check`: PASS
+- `npm run validate:canonical-structure`: PASS
+
+Branch validation: PASS

dev/reports/PR_26179_ALFA_012-objects-properties-mvp_branch_validation.md

@@ -0,0 +1,22 @@
+# PR_26179_ALFA_012 Manual Validation Notes
+
+## Manual Review Path
+1. Open `toolbox/objects/index.html` with the API server running.
+2. Add an object from the Objects table.
+3. Select `Details` on the object row.
+4. Confirm Object Details shows Name, Description, Type, Tags, Active, Visible, Sprite reference, Audio reference, and Default values.
+5. Edit Description and confirm `Unsaved changes: yes` appears.
+6. Press Cancel and confirm the field resets and dirty state clears.
+7. Clear Name and press Save Details; confirm the friendly Name validation message appears.
+8. Enter valid details and press Save Details.
+9. Refresh the page; confirm saved details reload from the API-backed object record.
+
+## Expected Owner Review Result
+The panel is reviewable as a normal product form. It does not expose a behavior editor, Rules, Worlds, JSON editor, or engine internals.
+
+## Known Out-of-Scope Items
+- Behavior editor.
+- Rules integration.
+- Worlds integration.
+- Database schema expansion.
+- New API routes.

dev/reports/PR_26179_ALFA_012-objects-properties-mvp_manual_validation_notes.md

@@ -0,0 +1,40 @@
+# PR_26179_ALFA_012-objects-properties-mvp Report
+
+## Summary
+Implemented the Objects Object Details panel as the PR012 vertical slice. The panel lets a signed-in Creator review and edit Name, Description, Type, Tags, Active, Visible, Sprite reference, Audio reference, and Default values for the selected object.
+
+## Scope
+- Added Object Details inspector form to `toolbox/objects/index.html`.
+- Added detail selection, unsaved-change detection, save/cancel behavior, required-field validation, duplicate-name validation, and sprite-reference validation to `assets/toolbox/objects/js/index.js`.
+- Persisted details through the existing Objects API service and existing `object_definition_records` JSON payloads without adding routes, tables, or new API architecture.
+- Updated Objects service tests to prove details round-trip through the database adapter.
+- Updated Objects Playwright tests to cover the human-testable details flow and refresh persistence.
+
+## Architecture Notes
+- No behavior editor added.
+- No Rules integration added.
+- No Worlds integration added.
+- No browser-owned product data added.
+- No page-local product data source of truth added.
+- Object Details are persisted through the existing API-backed Objects service from PR011.
+- Review-only details are stripped before engine object-definition validation so engine schema remains unchanged.
+
+## Validation Outcome
+PASS. Final targeted validation completed successfully.
+
+## Corrective Notes From Validation
+- Initial Playwright run exposed engine validation rejecting the new review-only `details` field. Fixed by validating a stripped engine-definition shape.
+- Initial details save exposed nonexistent sprite references reaching DB persistence. Fixed by adding a friendly Sprite reference validation message.
+- Row/details rename saves preserved the old object slug. Fixed by regenerating object ids from the edited name.
+
+## Changed Runtime Surface
+- Objects page Object Details inspector.
+- Objects browser controller.
+- Objects API service serialization for existing object records.
+
+## Not Changed
+- API routes.
+- Database schema.
+- Behavior editor.
+- Rules or Worlds integrations.
+- Engine object model contract.

dev/reports/PR_26179_ALFA_012-objects-properties-mvp_report.md

@@ -0,0 +1,23 @@
+# PR_26179_ALFA_012 Requirement Checklist
+
+- Complete Object Details panel using existing Objects API persistence from PR011: PASS
+- Do not modify API architecture: PASS
+- Focus on Product Owner reviewability: PASS
+- Name property: PASS
+- Description property: PASS
+- Type property: PASS
+- Tags property: PASS
+- Active property: PASS
+- Visible property: PASS
+- Sprite reference property: PASS
+- Audio reference property: PASS
+- Default values property: PASS
+- Required-field validation: PASS
+- Friendly validation messages: PASS
+- Save behavior: PASS
+- Cancel behavior: PASS
+- Unsaved-change detection: PASS
+- No behavior editor: PASS
+- No Rules integration: PASS
+- No Worlds integration: PASS
+- One PR purpose only: PASS

dev/reports/PR_26179_ALFA_012-objects-properties-mvp_requirement_checklist.md

@@ -0,0 +1,23 @@
+# PR_26179_ALFA_012 Validation Lane Report
+
+Lane: Objects tool focused validation
+
+## Commands
+1. `node --check assets/toolbox/objects/js/index.js`
+2. `node --check src/dev-runtime/toolbox-api/alfa-tool-services.mjs`
+3. `node --check dev/tests/playwright/tools/ObjectsTool.spec.mjs`
+4. `node --test dev/tests/dev-runtime/ObjectsApiService.test.mjs`
+5. `npx playwright test dev/tests/playwright/tools/ObjectsTool.spec.mjs -g "Object Details panel"`
+6. `npx playwright test dev/tests/playwright/tools/ObjectsTool.spec.mjs`
+7. `git diff --check`
+8. `npm run validate:canonical-structure`
+
+## Result
+PASS
+
+## Impacted Coverage
+- Objects API service database adapter round-trip.
+- Objects table behavior.
+- Object Details panel properties, validation, save/cancel, dirty state, and refresh persistence.
+- Guest write redirect coverage retained.
+- Sprite asset link behavior retained.

dev/reports/PR_26179_ALFA_012-objects-properties-mvp_validation_lane.md

@@ -0,0 +1,18 @@
+# PR_26179_ALFA_012 Validation Report
+
+## Final Targeted Validation
+
+PASS: `node --check assets/toolbox/objects/js/index.js`
+PASS: `node --check src/dev-runtime/toolbox-api/alfa-tool-services.mjs`
+PASS: `node --check dev/tests/playwright/tools/ObjectsTool.spec.mjs`
+PASS: `node --test dev/tests/dev-runtime/ObjectsApiService.test.mjs`
+PASS: `npx playwright test dev/tests/playwright/tools/ObjectsTool.spec.mjs -g "Object Details panel"`
+PASS: `npx playwright test dev/tests/playwright/tools/ObjectsTool.spec.mjs`
+PASS: `git diff --check`
+PASS: `npm run validate:canonical-structure`
+
+## Playwright Coverage
+The focused Objects Playwright suite passed 8/8 tests after fixes.
+
+## Notes
+The first browser run intentionally remained in this report history because it caught useful defects before final packaging. Those defects were fixed and final validation passed.

dev/reports/PR_26179_ALFA_012-objects-properties-mvp_validation_report.md

@@ -1,13 +1,15 @@
-M	assets/toolbox/objects/js/index.js
-A	dev/reports/PR_26179_ALFA_011-objects-manager-mvp_branch-validation.md
-A	dev/reports/PR_26179_ALFA_011-objects-manager-mvp_manual-validation-notes.md
-A	dev/reports/PR_26179_ALFA_011-objects-manager-mvp_report.md
-A	dev/reports/PR_26179_ALFA_011-objects-manager-mvp_requirement-checklist.md
-A	dev/reports/PR_26179_ALFA_011-objects-manager-mvp_validation-lane.md
-A	dev/reports/PR_26179_ALFA_011-objects-manager-mvp_validation-report.md
-M	dev/reports/codex_changed_files.txt
-M	dev/reports/codex_review.diff
-A	dev/tests/dev-runtime/ObjectsApiService.test.mjs
-M	dev/tests/playwright/tools/ObjectsTool.spec.mjs
-M	src/dev-runtime/server/local-api-router.mjs
-M	src/dev-runtime/toolbox-api/alfa-tool-services.mjs
+assets/toolbox/objects/js/index.js
+dev/reports/codex_changed_files.txt
+dev/reports/codex_review.diff
+dev/reports/coverage_changed_js_guardrail.txt
+dev/reports/playwright_v8_coverage_report.txt
+dev/reports/PR_26179_ALFA_012-objects-properties-mvp_branch_validation.md
+dev/reports/PR_26179_ALFA_012-objects-properties-mvp_manual_validation_notes.md
+dev/reports/PR_26179_ALFA_012-objects-properties-mvp_report.md
+dev/reports/PR_26179_ALFA_012-objects-properties-mvp_requirement_checklist.md
+dev/reports/PR_26179_ALFA_012-objects-properties-mvp_validation_lane.md
+dev/reports/PR_26179_ALFA_012-objects-properties-mvp_validation_report.md
+dev/tests/dev-runtime/ObjectsApiService.test.mjs
+dev/tests/playwright/tools/ObjectsTool.spec.mjs
+src/dev-runtime/toolbox-api/alfa-tool-services.mjs
+toolbox/objects/index.html