Skip to content

Commit 706c469

Browse files
ToolboxAidToolboxAid
committed
PR_26172_OWNER_031 PI closeout governance
1 parent 8f7140e commit 706c469

7 files changed

Lines changed: 253 additions & 102 deletions

‎docs_build/dev/PROJECT_INSTRUCTIONS.md‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2088,6 +2088,35 @@ Rules:
20882088
- Active workstream branches remain.
20892089
- No branch deletion is performed by this governance rule unless a later owner-approved cleanup task explicitly scopes deletion.
20902090

2091+
## PI CLOSEOUT GOVERNANCE
2092+
2093+
At PI completion, Codex must verify that the repository, GitHub workstream, and deferred-work record are ready for the next PI.
2094+
2095+
Required PI completion checks:
2096+
- all approved work merged
2097+
- repository returned to main
2098+
- main pulled clean
2099+
- local/origin sync = 0 0
2100+
- open PR review complete
2101+
- branch review complete
2102+
- active workstream review complete
2103+
- deferred work list recorded
2104+
- next PI queue recommendation recorded
2105+
2106+
Required PI closeout report fields:
2107+
- final main commit
2108+
- active PRs
2109+
- active branches
2110+
- closed/superseded PRs
2111+
- deleted branch candidates
2112+
- deferred work
2113+
- next PI priorities
2114+
2115+
Rules:
2116+
- EOD Workstream Closeout remains authoritative for final repository state.
2117+
- PI closeout must not imply approval to merge, close PRs, delete branches, or remove deferred work without explicit owner approval.
2118+
- If the repository is not on clean, synchronized main, PI closeout status = FAIL.
2119+
20912120
## OWNER-CONTROLLED STABLE AND MERGE APPROVAL
20922121

20932122
Stable promotion and merge approval are owner-controlled.

‎docs_build/dev/ProjectInstructions/addendums/multi_team.md‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,35 @@ Rules:
107107
- Active workstream branches remain.
108108
- No branch deletion is performed by this governance rule unless a later owner-approved cleanup task explicitly scopes deletion.
109109

110+
## PI Closeout Governance
111+
112+
At PI completion, Codex must verify that the repository, GitHub workstream, and deferred-work record are ready for the next PI.
113+
114+
Required PI completion checks:
115+
- all approved work merged
116+
- repository returned to main
117+
- main pulled clean
118+
- local/origin sync = 0 0
119+
- open PR review complete
120+
- branch review complete
121+
- active workstream review complete
122+
- deferred work list recorded
123+
- next PI queue recommendation recorded
124+
125+
Required PI closeout report fields:
126+
- final main commit
127+
- active PRs
128+
- active branches
129+
- closed/superseded PRs
130+
- deleted branch candidates
131+
- deferred work
132+
- next PI priorities
133+
134+
Rules:
135+
- EOD Workstream Closeout remains authoritative for final repository state.
136+
- PI closeout must not imply approval to merge, close PRs, delete branches, or remove deferred work without explicit owner approval.
137+
- If the repository is not on clean, synchronized main, PI closeout status = FAIL.
138+
110139
## Conflict Note
111140

112141
Existing ProjectInstructions wording that appears to require immediate or automatic merge remains preserved for traceability.

‎docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance-instruction-compliance-checklist.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# Instruction Compliance Checklist
2+
3+
PR: $pr
4+
5+
- [x] Read docs_build/dev/PROJECT_INSTRUCTIONS.md.
6+
- [x] Read docs_build/dev/PROJECT_MULTI_PC.txt.
7+
- [x] Verified current branch was the approved OWNER workstream branch.
8+
- [x] Verified repository was clean/synced after PR 030 push before PR 031 edits.
9+
- [x] Verified PR TEAM token is OWNER.
10+
- [x] Verified OWNER governance scope matches TEAM ownership.
11+
- [x] Updated only scoped governance documentation and required reports.
12+
- [x] Ran git diff --check.
13+
- [x] Verified no conflicting governance wording.
14+
- [x] Verified EOD closeout remains authoritative.
15+
- [x] Documented skipped Playwright and samples lanes.
16+
- [x] Created required Codex reports.
17+
- [x] Created repo-structured delta ZIP under mp/.

‎docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance-manual-validation-notes.md‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# Manual Validation Notes
2+
3+
PR: $pr
4+
5+
## Checks Performed
6+
7+
- Confirmed PI Closeout governance was added to legacy and active ProjectInstructions governance.
8+
- Confirmed PI completion checks include all approved work merged, repository returned to main, clean pull, local/origin sync, open PR review, branch review, active workstream review, deferred work, and next PI queue recommendation.
9+
- Confirmed required PI closeout report fields include final main commit, active PRs, active branches, closed/superseded PRs, deleted branch candidates, deferred work, and next PI priorities.
10+
- Confirmed EOD Workstream Closeout remains authoritative for final repository state.
11+
- Confirmed the governance does not approve merging, PR closure, branch deletion, or deferred-work removal without owner approval.
12+
13+
## Manual Result
14+
15+
PASS
16+
17+
## Skipped Validation
18+
19+
- Playwright was not run because no UI or runtime behavior changed.
20+
- Samples were not run because no samples or sample-impacting runtime changed.

‎docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance.md‎

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
# PR_26172_OWNER_031-pi-closeout-governance
2+
3+
## Scope
4+
5+
Add PI Closeout governance for final PI repository and GitHub hygiene review.
6+
7+
## Team Ownership
8+
9+
- TEAM token: OWNER
10+
- Ownership classification: governance / workflow governance
11+
- TEAM ownership result: PASS
12+
13+
## Files Changed
14+
15+
- docs_build/dev/PROJECT_INSTRUCTIONS.md
16+
- docs_build/dev/ProjectInstructions/addendums/multi_team.md
17+
- docs_build/dev/reports/codex_changed_files.txt
18+
- docs_build/dev/reports/codex_review.diff
19+
- docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance.md
20+
- docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance-manual-validation-notes.md
21+
- docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance-instruction-compliance-checklist.md
22+
23+
## Change Summary
24+
25+
- Added PI Closeout governance to require approved-work merge status, clean synchronized main, open PR review, branch review, active workstream review, deferred work list, and next PI queue recommendations.
26+
- Added required PI closeout report fields.
27+
- Preserved EOD Workstream Closeout as authoritative for final repository state.
28+
- Prohibited PI closeout from implying approval to merge, close PRs, delete branches, or remove deferred work without explicit owner approval.
29+
30+
## Validation
31+
32+
- git diff --check: PASS
33+
- Verified PI Closeout governance exists: PASS
34+
- Verified required PI closeout report fields exist: PASS
35+
- Verified no conflicting governance wording: PASS
36+
- Verified EOD closeout remains authoritative: PASS
37+
38+
## Skipped Lanes
39+
40+
- Playwright: skipped because this is docs/governance-only.
41+
- Samples: skipped because no runtime, sample, or UI files changed.

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
docs_build/dev/PROJECT_INSTRUCTIONS.md
22
docs_build/dev/ProjectInstructions/addendums/multi_team.md
3-
docs_build/dev/reports/PR_26172_OWNER_030-workstream-hygiene-governance.md
4-
docs_build/dev/reports/PR_26172_OWNER_030-workstream-hygiene-governance-manual-validation-notes.md
5-
docs_build/dev/reports/PR_26172_OWNER_030-workstream-hygiene-governance-instruction-compliance-checklist.md
3+
docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance.md
4+
docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance-manual-validation-notes.md
5+
docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance-instruction-compliance-checklist.md
66
docs_build/dev/reports/codex_changed_files.txt
77
docs_build/dev/reports/codex_review.diff

0 commit comments

Comments
 (0)