Skip to content

Commit 5e39a86

Browse files
committed
Merge Text To Speech toolbox path correction
2 parents b01045a + d3f3a1b commit 5e39a86

14 files changed

Lines changed: 2493 additions & 138 deletions
Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
# PR_26171_027 Text To Speech Rebuild Foundation
2+
3+
## Reference source
4+
- Reviewed `archive/v1-v2/tools/old_text2speech-V2` as historical reference only.
5+
- No archived implementation, CSS, event handlers, or runtime code was copied.
6+
7+
## Feature inventory
8+
- Script/message text entry and review.
9+
- Voice/profile selection concepts.
10+
- Emotion or delivery tuning concepts.
11+
- Preview/generate/export workflow concepts.
12+
- Provider choice as a future integration path.
13+
14+
## UX inventory
15+
- Creator needs a clear distinction between design-owned message text and audio-owned generated voice assets.
16+
- Creator needs workflow state labels before provider integration exists.
17+
- Creator needs visible blocked states instead of silent fallback behavior.
18+
- Creator needs future provider readiness notes without exposing fake generation.
19+
20+
## Data model notes
21+
- Message: design-owned text, language, emotion, status, metadata, and optional project linkage.
22+
- Emotion: named delivery intent with safe scalar settings.
23+
- Voice Profile: creator-facing desired voice/provider settings; generated output remains audio-owned.
24+
- Language: BCP-47-style language code and display name.
25+
- Status: draft, ready for preview, pending generation, generated, exported, blocked, archived.
26+
- Audio ownership: generated clips, files, provider artifacts, and export bundles belong to Audio.
27+
28+
## Gap analysis
29+
- Current hidden Voice Output shell had no creator workflow model.
30+
- Current Message Studio speech testing is browser preview oriented and not a generated-audio pipeline.
31+
- Provider adapters require planning before any external service implementation.
32+
- Export requires explicit generated asset references; no browser-owned product data should be persisted.
33+
34+
## Rebuild plan
35+
1. Create a Theme V2 Text To Speech shell under `toolbox/text-to-speech/`.
36+
2. Add a TTS message model foundation with explicit ownership boundaries.
37+
3. Add preview/generate/export shell states with blocked provider behavior.
38+
4. Add provider adapter planning for future OpenAI, ElevenLabs, Azure, and local providers.
39+
5. Keep implementation provider-free until a later scoped PR adds a real adapter.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# PR_26171_029 Text To Speech Tool Shell
2+
3+
Replaced the placeholder at `toolbox/text-to-speech/index.html` with the rebuilt Theme V2 page shell and wired its module from `toolbox/text-to-speech/text2speech.js`.
4+
5+
The active toolbox registration already points to `text-to-speech/index.html`, so registration was preserved. The incorrect root `tools/text2speech/` path was removed. No inline styles, style blocks, inline event handlers, page-local CSS, or tool-local CSS were added.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# PR_26171_031 Text To Speech Message Model
2+
3+
Added a provider-free Text To Speech model foundation for Message, Emotion Profile, Voice Profile, Language, Status, and creator metadata. Message data is marked Design-owned. Generated voice/audio ownership is explicitly marked Audio-owned.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# PR_26171_033 Text To Speech Generation Workflow
2+
3+
Added preview/generate/export workflow shell functions and UI controls. Preview validates readiness. Generate is blocked because no provider adapter is implemented. Export is blocked until an Audio-owned generated asset exists. No fake generation or silent fallback was added.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# PR_26171_035 Text To Speech Provider Adapter Plan
2+
3+
Added future provider planning entries for OpenAI, ElevenLabs, Azure AI Speech, and local providers. Entries document boundaries and required capabilities only; no provider implementation or external network integration was added.
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# Text To Speech Manual Validation Notes
2+
3+
- Reviewed `toolbox/text-to-speech/index.html` for Theme V2 stylesheet usage only.
4+
- Reviewed `toolbox/text-to-speech/text2speech.js` for provider-free model/workflow behavior.
5+
- Confirmed no inline styles, style blocks, inline event handlers, page-local CSS, or tool-local CSS were introduced.
6+
- Confirmed `tools/text2speech/` no longer exists.
7+
- Confirmed the current toolbox registration path remains `text-to-speech/index.html`.
8+
- Confirmed archived `old_text2speech-V2` code was treated as reference material only and not copied.
9+
- Confirmed no external provider integration, fake generation, or silent fallback was introduced.
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# PR_26171 Text To Speech Toolbox Path Correction
2+
3+
## Summary
4+
- Moved the rebuilt Text To Speech shell into the active toolbox path: `toolbox/text-to-speech/`.
5+
- Replaced the placeholder `toolbox/text-to-speech/index.html` with the Theme V2 / Tool Template V2 shell.
6+
- Added `toolbox/text-to-speech/text2speech.js` for provider-free message model, workflow, and adapter planning behavior.
7+
- Removed the incorrect root `tools/text2speech/` path.
8+
- Preserved the existing toolbox registration path `text-to-speech/index.html`.
9+
10+
## Scope
11+
- Text To Speech page/module wiring only.
12+
- Required reports and validation evidence only.
13+
- No archived implementation was copied.
14+
- No provider integration, fake generation, silent fallback, browser-owned product data, page-local CSS, or tool-local CSS was added.
15+
16+
## Corrected Paths
17+
- Active page: `toolbox/text-to-speech/index.html`
18+
- Active module: `toolbox/text-to-speech/text2speech.js`
19+
- Removed path: `tools/text2speech/`
20+
21+
## Project Workspace Note
22+
The validation command `npm run test:workspace-v2` retains a legacy command name. User-facing copy and reports refer to Project Workspace.
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# Text To Speech Validation Report
2+
3+
## Commands
4+
- PASS: `node --test tests/tools/Text2SpeechShell.test.mjs`
5+
- PASS: targeted static validation for `toolbox/text-to-speech/index.html`
6+
- FAIL: `npm run test:workspace-v2`
7+
8+
`npm run test:workspace-v2` is a legacy command name. The user-facing product language is Project Workspace.
9+
10+
## Workspace Lane Failure
11+
- The command ran `tests/playwright/tools/RootToolsFutureState.spec.mjs`.
12+
- 3 tests passed and 2 tests failed.
13+
- Failure 1: `root tools surface links current tool pages without old_* routes` expected the default tool labels without `Message Studio`; the page currently includes `Message Studio`.
14+
- Failure 2: `common header renders primary navigation order across active pages` found a generic `Studio` body-text match after stripping `GameFoundryStudio` / `Game Foundry Studio`.
15+
- Neither failure points to the corrected Text To Speech path, module wiring, or removed `tools/text2speech/` directory.
16+
17+
## Targeted assertions
18+
- Model ownership boundary is Design for messages/profiles and Audio for generated voice assets.
19+
- Preview/generate/export shell does not silently fall back.
20+
- Future provider adapter list is planning-only for OpenAI, ElevenLabs, Azure, and local providers.
21+
- Text To Speech page uses Theme V2 and ToolDisplayMode.
22+
- Text To Speech page wires `toolbox/text-to-speech/text2speech.js`.
23+
- Text To Speech page does not reference `tools/text2speech`.
24+
- `tools/text2speech/` is absent.
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# Text To Speech ZIP Verification Report
2+
3+
## ZIP Target
4+
- `tmp/PR_26171_text2speech_delta.zip`
5+
6+
## Verification Criteria
7+
- ZIP is repo-structured from the repository root.
8+
- ZIP contains the scoped Text To Speech correction files and required reports.
9+
- ZIP does not contain files from `tmp/`.
10+
- ZIP does not contain any `tools/text2speech/` path.
11+
12+
## Expected Scoped Files
13+
- `toolbox/text-to-speech/index.html`
14+
- `toolbox/text-to-speech/text2speech.js`
15+
- `tests/tools/Text2SpeechShell.test.mjs`
16+
- `docs_build/dev/reports/PR_26171_027-text2speech-rebuild-foundation.md`
17+
- `docs_build/dev/reports/PR_26171_029-text2speech-tool-shell.md`
18+
- `docs_build/dev/reports/PR_26171_031-text2speech-message-model.md`
19+
- `docs_build/dev/reports/PR_26171_033-text2speech-generation-workflow.md`
20+
- `docs_build/dev/reports/PR_26171_035-text2speech-provider-adapter-plan.md`
21+
- `docs_build/dev/reports/PR_26171_text2speech-toolbox-path-correction.md`
22+
- `docs_build/dev/reports/PR_26171_text2speech-validation.md`
23+
- `docs_build/dev/reports/PR_26171_text2speech-manual-validation.md`
24+
- `docs_build/dev/reports/PR_26171_text2speech-zip-verification.md`
25+
- `docs_build/dev/reports/codex_changed_files.txt`
26+
- `docs_build/dev/reports/codex_review.diff`
27+
28+
## Result
29+
- PASS: `tmp/PR_26171_text2speech_delta.zip` was created.
30+
- PASS: Archive listing contained 14 entries.
31+
- PASS: No expected files were missing from the archive listing.
32+
- PASS: No archive entries were under `tmp/`.
33+
- PASS: No archive entries were under `tools/text2speech/`.
Lines changed: 34 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,34 @@
1-
docs_build/dev/PROJECT_INSTRUCTIONS.md
2-
docs_build/dev/reports/PR_26171_025-codex-git-workflow-ownership.md
3-
docs_build/dev/reports/PR_26171_025-codex-git-workflow-ownership-validation.md
4-
docs_build/dev/reports/PR_26171_025-codex-git-workflow-ownership-manual-validation.md
5-
docs_build/dev/reports/codex_review.diff
6-
docs_build/dev/reports/codex_changed_files.txt
1+
# git status --short
2+
M docs_build/dev/reports/codex_changed_files.txt
3+
M docs_build/dev/reports/codex_review.diff
4+
M toolbox/text-to-speech/index.html
5+
?? docs_build/dev/reports/PR_26171_027-text2speech-rebuild-foundation.md
6+
?? docs_build/dev/reports/PR_26171_029-text2speech-tool-shell.md
7+
?? docs_build/dev/reports/PR_26171_031-text2speech-message-model.md
8+
?? docs_build/dev/reports/PR_26171_033-text2speech-generation-workflow.md
9+
?? docs_build/dev/reports/PR_26171_035-text2speech-provider-adapter-plan.md
10+
?? docs_build/dev/reports/PR_26171_text2speech-manual-validation.md
11+
?? docs_build/dev/reports/PR_26171_text2speech-toolbox-path-correction.md
12+
?? docs_build/dev/reports/PR_26171_text2speech-validation.md
13+
?? docs_build/dev/reports/PR_26171_text2speech-zip-verification.md
14+
?? tests/tools/Text2SpeechShell.test.mjs
15+
?? toolbox/text-to-speech/text2speech.js
16+
17+
# git ls-files --others --exclude-standard
18+
docs_build/dev/reports/PR_26171_027-text2speech-rebuild-foundation.md
19+
docs_build/dev/reports/PR_26171_029-text2speech-tool-shell.md
20+
docs_build/dev/reports/PR_26171_031-text2speech-message-model.md
21+
docs_build/dev/reports/PR_26171_033-text2speech-generation-workflow.md
22+
docs_build/dev/reports/PR_26171_035-text2speech-provider-adapter-plan.md
23+
docs_build/dev/reports/PR_26171_text2speech-manual-validation.md
24+
docs_build/dev/reports/PR_26171_text2speech-toolbox-path-correction.md
25+
docs_build/dev/reports/PR_26171_text2speech-validation.md
26+
docs_build/dev/reports/PR_26171_text2speech-zip-verification.md
27+
tests/tools/Text2SpeechShell.test.mjs
28+
toolbox/text-to-speech/text2speech.js
29+
30+
# git diff --stat
31+
docs_build/dev/reports/codex_changed_files.txt | 40 +-
32+
docs_build/dev/reports/codex_review.diff | 1428 ++++++++++++++++++++++--
33+
toolbox/text-to-speech/index.html | 76 +-
34+
3 files changed, 1406 insertions(+), 138 deletions(-)

0 commit comments

Comments
 (0)