Remove Controls mapping JSON accordion and add action descriptions - PR_26161_022-controls-action-descriptions

ToolboxAid · ToolboxAid · commit 52362d5b4640 · 2026-06-10T18:57:13.000-04:00
diff --git a/docs_build/dev/reports/codex_changed_files.txt b/docs_build/dev/reports/codex_changed_files.txt
@@ -5,16 +5,16 @@ M docs_build/dev/reports/coverage_changed_js_guardrail.txt
  M toolbox/controls/index.html
  M toolbox/input-mapping-v2/index.html
  M toolbox/input-mapping-v2/input-mapping-v2.js
-?? docs_build/dev/reports/controls-device-specific-input-report.md
+?? docs_build/dev/reports/controls-action-descriptions-report.md
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/controls-device-specific-input-report.md
+docs_build/dev/reports/controls-action-descriptions-report.md
 
 # git diff --stat
-.../dev/reports/coverage_changed_js_guardrail.txt  |   4 +-
- .../dev/reports/playwright_v8_coverage_report.txt  |   8 +-
- tests/playwright/tools/InputMappingV2Tool.spec.mjs |  45 +++++++-
- toolbox/controls/index.html                        |  66 ++++++------
- toolbox/input-mapping-v2/index.html                |  66 ++++++------
- toolbox/input-mapping-v2/input-mapping-v2.js       | 114 +++++++++++++++++----
- 6 files changed, 210 insertions(+), 93 deletions(-)
+.../dev/reports/coverage_changed_js_guardrail.txt  |  2 +-
+ .../dev/reports/playwright_v8_coverage_report.txt  |  8 ++---
+ tests/playwright/tools/InputMappingV2Tool.spec.mjs | 29 +++++++++++++---
+ toolbox/controls/index.html                        |  6 ----
+ toolbox/input-mapping-v2/index.html                |  6 ----
+ toolbox/input-mapping-v2/input-mapping-v2.js       | 40 +++++++++++++---------
+ 6 files changed, 54 insertions(+), 37 deletions(-)
diff --git a/docs_build/dev/reports/codex_review.diff b/docs_build/dev/reports/codex_review.diff
diff --git a/docs_build/dev/reports/controls-action-descriptions-report.md b/docs_build/dev/reports/controls-action-descriptions-report.md
@@ -0,0 +1,58 @@
+# PR_26161_022 Controls Action Descriptions Report
+
+## Branch Validation
+- Current branch: `main`
+- Expected branch: `main`
+- Result: PASS
+
+## Summary
+- Removed the visible Inspector > Mapping JSON accordion from Controls.
+- Preserved internal mapping payload generation for tool output/status logic, without displaying it as an accordion.
+- Added creator-facing descriptions next to every default action in Controls > Actions.
+- Preserved alphabetical action ordering.
+- Preserved device-specific input capture, Controller Profile center placement, State explanation, table editing, Add Mapping, Cancel, Edit, Trash, DB reload persistence, and Wireframe status.
+
+## Impacted Lane
+- runtime
+- recovery/UAT
+
+## Playwright Impacted
+- Yes
+
+## Testing Performed
+- `node --check toolbox/input-mapping-v2/input-mapping-v2.js` - PASS
+- `node --check tests/playwright/tools/InputMappingV2Tool.spec.mjs` - PASS
+- `rg --pcre2 -n "<style|style=|<script(?![^>]*\\bsrc=)|on(click|change|input|submit|keydown|keyup|pointerdown|mousedown|mouseup)=" toolbox/input-mapping-v2/index.html toolbox/controls/index.html` - PASS, no inline CSS/JS/event handlers found
+- `git diff --check` - PASS
+- `npx playwright test tests/playwright/tools/InputMappingV2Tool.spec.mjs --workers=1 --reporter=line` - PASS, 5 passed
+
+## Playwright Behavior Covered
+- Mapping JSON accordion no longer appears.
+- Mapping JSON DOM output is not visible.
+- All listed actions display descriptions.
+- Action labels remain alphabetically sorted.
+- Device-specific capture still swaps Keyboard, Mouse, and Gamepad capture controls by selected Input Device.
+- Captured mappings persist after reload.
+- Devices, Status, controller profiles, table editing, Add Mapping, Cancel, Edit, and Trash continue to work.
+
+## V8 Coverage
+- Report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- Changed runtime JS covered: `toolbox/input-mapping-v2/input-mapping-v2.js`
+- Coverage result: 91% function coverage, 105/116 functions
+
+## Manual Validation Steps
+1. Open `/toolbox/input-mapping-v2/index.html`.
+2. Confirm the Inspector column shows Devices and Status, with no Mapping JSON accordion.
+3. Confirm Controls > Actions lists Cancel through Thrust alphabetically.
+4. Confirm each action has a short creator-facing description beside it.
+5. Add a mapping, capture a keyboard input, save, reload, and confirm the mapping remains.
+6. Edit the mapping and confirm device-specific capture controls still appear for the selected device.
+
+## Skipped Lanes
+- Full samples validation was skipped as required by the PR instructions; this change is scoped to Controls/Input Mapping UI and targeted behavior tests.
+- Full workspace contract lane was skipped because no Workspace V2 contract/runtime files changed; workspace return remains covered by targeted Controls Playwright.
+
+## Runtime Scope Confirmation
+- Controls remains Wireframe.
+- Controls mapping and controller profile data remain persisted through the shared DB/mock adapter.
+- No sample JSON alignment, auth behavior, production DB behavior, engine runtime behavior, or unrelated rewrites were added.
diff --git a/docs_build/dev/reports/coverage_changed_js_guardrail.txt b/docs_build/dev/reports/coverage_changed_js_guardrail.txt
@@ -6,7 +6,7 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(93%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1125/1125; executed functions 111/120
+(91%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1133/1133; executed functions 105/116
 
 Guardrail warnings:
 (100%) none - no changed runtime JS coverage warnings
diff --git a/docs_build/dev/reports/playwright_v8_coverage_report.txt b/docs_build/dev/reports/playwright_v8_coverage_report.txt
@@ -12,19 +12,19 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(89%) Toolbox Index - exercised 4 runtime JS files
+(88%) Toolbox Index - exercised 4 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(93%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1125/1125; executed functions 111/120
+(91%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1133/1133; executed functions 105/116
 
 Files with executed line/function counts where available:
 (53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
 (58%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 603/603; executed functions 30/52
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
 (75%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 21/28
-(93%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1125/1125; executed functions 111/120
+(91%) toolbox/input-mapping-v2/input-mapping-v2.js - executed lines 1133/1133; executed functions 105/116
 (100%) toolbox/input-mapping-v2/input-mapping-api-client.js - executed lines 12/12; executed functions 2/2
 (100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
 
@@ -33,4 +33,4 @@ Uncovered or low-coverage changed JS files:
 
 Changed JS files considered:
 (0%) tests/playwright/tools/InputMappingV2Tool.spec.mjs - changed JS file not collected as browser runtime coverage
-(93%) toolbox/input-mapping-v2/input-mapping-v2.js - changed JS file with browser V8 coverage
+(91%) toolbox/input-mapping-v2/input-mapping-v2.js - changed JS file with browser V8 coverage
diff --git a/tests/playwright/tools/InputMappingV2Tool.spec.mjs b/tests/playwright/tools/InputMappingV2Tool.spec.mjs
@@ -21,6 +21,24 @@ const DEFAULT_ACTION_LABELS = [
   "Thrust",
 ];
 
+const DEFAULT_ACTION_DESCRIPTIONS = [
+  "Back out of a menu or choice.",
+  "Accept a choice or prompt.",
+  "Use the primary attack or tool.",
+  "Use nearby objects or prompts.",
+  "Make the object jump.",
+  "Move the object downward.",
+  "Move the object left.",
+  "Move the object right.",
+  "Move the object upward.",
+  "Pause gameplay or open the pause menu.",
+  "Turn the object counterclockwise.",
+  "Turn the object clockwise.",
+  "Highlight or choose menu items.",
+  "Begin gameplay or open the start menu.",
+  "Push the object forward.",
+];
+
 test.beforeEach(async ({ page }) => {
   await installPlaywrightStorageIsolation(page, {
     lane: "input-mapping-v2",
@@ -141,7 +159,8 @@ test("Controls Input Mapping launch panels, defaults, diagnostics, and workspace
     await expect(page.locator(".tool-center-panel [data-controller-profile-planning]")).toBeVisible();
     await expect(page.getByRole("heading", { name: "Mappings" })).toBeVisible();
     await expect(page.locator("[data-input-state-explanation]")).toHaveText("State: Active means the mapping is available to the game. Disabled means the mapping is saved but ignored by the game until re-enabled.");
-    await expect(page.getByText("Mapping JSON", { exact: true })).toBeVisible();
+    await expect(page.getByText("Mapping JSON", { exact: true })).toHaveCount(0);
+    await expect(page.locator("[data-input-mapping-json]")).toHaveCount(0);
     await expect(page.getByText("Devices", { exact: true })).toBeVisible();
     await expect(page.getByText("Status", { exact: true })).toBeVisible();
     await expect(page.locator("[data-input-return-workspace]")).toBeVisible();
@@ -176,7 +195,8 @@ test("Controls Input Mapping launch panels, defaults, diagnostics, and workspace
     await expect(page.locator("[data-input-selected-action]")).toHaveText("Selected Action: Cancel");
     await expect(page.locator("[data-input-selected-object]")).toHaveText("Selected Object: Global");
     await expect(page.locator("[data-input-action-select] option")).toHaveText(DEFAULT_ACTION_LABELS);
-    await expect(page.locator("[data-input-default-actions] li")).toHaveText(DEFAULT_ACTION_LABELS);
+    await expect(page.locator("[data-input-action-label]")).toHaveText(DEFAULT_ACTION_LABELS);
+    await expect(page.locator("[data-input-action-description]")).toHaveText(DEFAULT_ACTION_DESCRIPTIONS);
     expect(DEFAULT_ACTION_LABELS).toEqual([...DEFAULT_ACTION_LABELS].sort((left, right) => left.localeCompare(right)));
     await expect(page.locator("[data-input-action-select]")).toContainText("Pause");
     await expect(page.locator("[data-input-action-select]")).toContainText("Select");
@@ -438,8 +458,7 @@ test("Controls Input Mapping captures KeyA, keeps input click safe, and deletes
     await expect(page.locator("[data-input-mapping-list]")).toContainText("Move Left");
     await expect(page.locator("[data-input-mapping-list]")).toContainText("Keyboard");
     await expect(page.locator("[data-input-token]")).toHaveText("Keyboard KeyA");
-    await expect(page.locator("[data-input-mapping-json]")).toContainText('"action": "moveLeft"');
-    await expect(page.locator("[data-input-mapping-json]")).toContainText('"label": "Keyboard KeyA"');
+    await expect(page.locator("[data-input-mapping-json]")).toHaveCount(0);
     await expect(page.locator("[data-input-output-status]")).toHaveText("Complete");
 
     let records = await inputMappingRecords(page);
@@ -481,6 +500,8 @@ test("Controls compatibility route uses rebuilt Input Mapping surface", async ({
 
   try {
     await expect(page.getByRole("heading", { name: "Input Mapping" })).toBeVisible();
+    await expect(page.getByText("Mapping JSON", { exact: true })).toHaveCount(0);
+    await expect(page.locator("[data-input-mapping-json]")).toHaveCount(0);
     await expect(page.locator("summary").filter({ hasText: "Capture" })).toHaveCount(0);
     await expect(page.locator("aside").first().locator("summary").filter({ hasText: "Controller Profiles" })).toHaveCount(0);
     await expect(page.locator(".tool-center-panel [data-controller-profile-planning]")).toBeVisible();
diff --git a/toolbox/controls/index.html b/toolbox/controls/index.html
@@ -135,12 +135,6 @@ <h3>Controller Profiles</h3>
                             <h2>Inspector</h2>
                         </div>
                         <div class="accordion-stack">
-                            <details class="vertical-accordion" open>
-                                <summary>Mapping JSON</summary>
-                                <div class="accordion-body content-stack">
-                                    <pre data-input-mapping-json>{}</pre>
-                                </div>
-                            </details>
                             <details class="vertical-accordion" open>
                                 <summary>Devices</summary>
                                 <div class="accordion-body content-stack">
diff --git a/toolbox/input-mapping-v2/index.html b/toolbox/input-mapping-v2/index.html
@@ -135,12 +135,6 @@ <h3>Controller Profiles</h3>
                             <h2>Inspector</h2>
                         </div>
                         <div class="accordion-stack">
-                            <details class="vertical-accordion" open>
-                                <summary>Mapping JSON</summary>
-                                <div class="accordion-body content-stack">
-                                    <pre data-input-mapping-json>{}</pre>
-                                </div>
-                            </details>
                             <details class="vertical-accordion" open>
                                 <summary>Devices</summary>
                                 <div class="accordion-body content-stack">
diff --git a/toolbox/input-mapping-v2/input-mapping-v2.js b/toolbox/input-mapping-v2/input-mapping-v2.js
@@ -2,21 +2,21 @@ import { createObjectsToolApiRepository } from "../objects/objects-api-client.js
 import { createInputMappingToolApiRepository } from "./input-mapping-api-client.js";
 
 const DEFAULT_ACTIONS = Object.freeze([
-  Object.freeze({ id: "cancel", label: "Cancel" }),
-  Object.freeze({ id: "confirm", label: "Confirm" }),
-  Object.freeze({ id: "fire", label: "Fire" }),
-  Object.freeze({ id: "interact", label: "Interact" }),
-  Object.freeze({ id: "jump", label: "Jump" }),
-  Object.freeze({ id: "moveDown", label: "Move Down" }),
-  Object.freeze({ id: "moveLeft", label: "Move Left" }),
-  Object.freeze({ id: "moveRight", label: "Move Right" }),
-  Object.freeze({ id: "moveUp", label: "Move Up" }),
-  Object.freeze({ id: "pause", label: "Pause" }),
-  Object.freeze({ id: "rotateLeft", label: "Rotate Left" }),
-  Object.freeze({ id: "rotateRight", label: "Rotate Right" }),
-  Object.freeze({ id: "select", label: "Select" }),
-  Object.freeze({ id: "start", label: "Start" }),
-  Object.freeze({ id: "thrust", label: "Thrust" }),
+  Object.freeze({ description: "Back out of a menu or choice.", id: "cancel", label: "Cancel" }),
+  Object.freeze({ description: "Accept a choice or prompt.", id: "confirm", label: "Confirm" }),
+  Object.freeze({ description: "Use the primary attack or tool.", id: "fire", label: "Fire" }),
+  Object.freeze({ description: "Use nearby objects or prompts.", id: "interact", label: "Interact" }),
+  Object.freeze({ description: "Make the object jump.", id: "jump", label: "Jump" }),
+  Object.freeze({ description: "Move the object downward.", id: "moveDown", label: "Move Down" }),
+  Object.freeze({ description: "Move the object left.", id: "moveLeft", label: "Move Left" }),
+  Object.freeze({ description: "Move the object right.", id: "moveRight", label: "Move Right" }),
+  Object.freeze({ description: "Move the object upward.", id: "moveUp", label: "Move Up" }),
+  Object.freeze({ description: "Pause gameplay or open the pause menu.", id: "pause", label: "Pause" }),
+  Object.freeze({ description: "Turn the object counterclockwise.", id: "rotateLeft", label: "Rotate Left" }),
+  Object.freeze({ description: "Turn the object clockwise.", id: "rotateRight", label: "Rotate Right" }),
+  Object.freeze({ description: "Highlight or choose menu items.", id: "select", label: "Select" }),
+  Object.freeze({ description: "Begin gameplay or open the start menu.", id: "start", label: "Start" }),
+  Object.freeze({ description: "Push the object forward.", id: "thrust", label: "Thrust" }),
 ].sort((left, right) => left.label.localeCompare(right.label, undefined, { sensitivity: "base" })));
 
 const DEVICE_OPTIONS = Object.freeze([
@@ -423,7 +423,15 @@ function renderDefaults() {
   }
   elements.defaultActions.replaceChildren(...DEFAULT_ACTIONS.map((action) => {
     const item = document.createElement("li");
-    item.textContent = action.label;
+    item.className = "content-split";
+    const label = document.createElement("strong");
+    label.dataset.inputActionLabel = action.id;
+    label.textContent = action.label;
+    const description = document.createElement("span");
+    description.className = "status";
+    description.dataset.inputActionDescription = action.id;
+    description.textContent = action.description;
+    item.append(label, description);
     return item;
   }));
 }
